[Branch,~linaro-maintainers/linaro-image-tools/trunk] Rev 313: Add a couple XXX/TODO comments for things that need to be fixed.

Message ID 20110405112245.6051.88234.launchpad@loganberry.canonical.com
State Accepted
Headers show

Commit Message

Guilherme Salgado April 5, 2011, 11:22 a.m.
------------------------------------------------------------
revno: 313
committer: Guilherme Salgado <guilherme.salgado@linaro.org>
branch nick: trunk
timestamp: Tue 2011-04-05 08:06:49 -0300
message:
  Add a couple XXX/TODO comments for things that need to be fixed.
modified:
  linaro_image_tools/media_create/boards.py
  linaro_image_tools/media_create/partitions.py


--
lp:linaro-image-tools
https://code.launchpad.net/~linaro-maintainers/linaro-image-tools/trunk

You are subscribed to branch lp:linaro-image-tools.
To unsubscribe from this branch go to https://code.launchpad.net/~linaro-maintainers/linaro-image-tools/trunk/+edit-subscription

Patch

=== modified file 'linaro_image_tools/media_create/boards.py'
--- linaro_image_tools/media_create/boards.py	2011-04-05 09:26:47 +0000
+++ linaro_image_tools/media_create/boards.py	2011-04-05 11:06:49 +0000
@@ -195,6 +195,9 @@ 
         return '%s,%s,%s,*\n%s,,,-' % (
             boot_start, boot_len, partition_type, root_start)
 
+    # TODO: Create separate config classes for android and move this method
+    # into them, also renaming it to get_sfdisk_cmd() so that we don't need
+    # the image_type check in partitions.py.
     @classmethod
     def get_android_sfdisk_cmd(cls, should_align_boot_part=False):
         if cls.fat_size == 32:

=== modified file 'linaro_image_tools/media_create/partitions.py'
--- linaro_image_tools/media_create/partitions.py	2011-03-31 18:44:16 +0000
+++ linaro_image_tools/media_create/partitions.py	2011-04-05 11:06:49 +0000
@@ -407,6 +407,8 @@ 
             ['parted', '-s', media.path, 'mklabel', 'msdos'], as_root=True)
         proc.wait()
 
+    # XXX: We should get rid of this by using separate config classes for
+    # android -- see comment in get_android_sfdisk_cmd() for more details.
     if image_type == "ANDROID":
         sfdisk_cmd = board_config.get_android_sfdisk_cmd(
             should_align_boot_part=should_align_boot_part)