[2/2] IPA ICF: make algorithm stable to survive -fcompare-debug

Message ID 17cd3b41-f814-4e3b-c70c-df057af49861@suse.cz
State New
Headers show

Commit Message

Martin Liška Jan. 11, 2017, 10:48 a.m.
On 01/11/2017 11:28 AM, Jakub Jelinek wrote:
> On Wed, Jan 11, 2017 at 11:21:08AM +0100, Christophe Lyon wrote:

>> Since then, I've noticed that

>>   gcc.dg/tree-ssa/flatten-3.c scan-assembler cycle[123][: \t\n]

>> now fails on aarch64 and arm targets.

> 

> It fails on x86_64-linux and i686-linux too.

> 

> 	Jakub

> 


Ok, problem is that we used to merge:

Semantic equality hit:doubleindirect1->subcycle1
Semantic equality hit:doubleindirect1->doublesubcycle1
Semantic equality hit:subcycle->doublesubcycle

and after my patch it changed to:

Semantic equality hit:doublesubcycle->subcycle
Semantic equality hit:doublesubcycle1->subcycle1
Semantic equality hit:doublesubcycle1->doubleindirect1

As output is grepped for a cycle[123], so of them would be merged.
Thus, adding -fno-ipa-icf would be the right fix.

Ready to be installed?
Thanks,
Martin

Comments

Richard Biener Jan. 11, 2017, 11:20 a.m. | #1
On Wed, Jan 11, 2017 at 11:48 AM, Martin Liška <mliska@suse.cz> wrote:
> On 01/11/2017 11:28 AM, Jakub Jelinek wrote:

>> On Wed, Jan 11, 2017 at 11:21:08AM +0100, Christophe Lyon wrote:

>>> Since then, I've noticed that

>>>   gcc.dg/tree-ssa/flatten-3.c scan-assembler cycle[123][: \t\n]

>>> now fails on aarch64 and arm targets.

>>

>> It fails on x86_64-linux and i686-linux too.

>>

>>       Jakub

>>

>

> Ok, problem is that we used to merge:

>

> Semantic equality hit:doubleindirect1->subcycle1

> Semantic equality hit:doubleindirect1->doublesubcycle1

> Semantic equality hit:subcycle->doublesubcycle

>

> and after my patch it changed to:

>

> Semantic equality hit:doublesubcycle->subcycle

> Semantic equality hit:doublesubcycle1->subcycle1

> Semantic equality hit:doublesubcycle1->doubleindirect1

>

> As output is grepped for a cycle[123], so of them would be merged.

> Thus, adding -fno-ipa-icf would be the right fix.

>

> Ready to be installed?


Ok.

Richard.

> Thanks,

> Martin

Patch hide | download patch | download mbox

From 2facdc8b5730568ead389e7d4af8a4f6b04e9cbc Mon Sep 17 00:00:00 2001
From: marxin <mliska@suse.cz>
Date: Wed, 11 Jan 2017 11:46:14 +0100
Subject: [PATCH] Fix flatten-3.c test-case.

gcc/testsuite/ChangeLog:

2017-01-11  Martin Liska  <mliska@suse.cz>

	* gcc.dg/tree-ssa/flatten-3.c: Add -fno-ipa-icf to dg-options.
---
 gcc/testsuite/gcc.dg/tree-ssa/flatten-3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/gcc.dg/tree-ssa/flatten-3.c b/gcc/testsuite/gcc.dg/tree-ssa/flatten-3.c
index a1edb910e9d..153165c72e3 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/flatten-3.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/flatten-3.c
@@ -1,5 +1,5 @@ 
 /* { dg-do compile } */
-/* { dg-options -O2 } */
+/* { dg-options -O2 -fno-ipa-icf } */
 
 extern void do_something_usefull();
 /* Check that we finish compiling even if instructed to
-- 
2.11.0