From patchwork Thu Jan 12 21:55:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Fischofer X-Patchwork-Id: 91237 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp1848525qgi; Thu, 12 Jan 2017 13:55:27 -0800 (PST) X-Received: by 10.107.30.14 with SMTP id e14mr14825206ioe.135.1484258127458; Thu, 12 Jan 2017 13:55:27 -0800 (PST) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id a7si9309324ioa.131.2017.01.12.13.55.27; Thu, 12 Jan 2017 13:55:27 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id D737060BF7; Thu, 12 Jan 2017 21:55:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 4B8456077E; Thu, 12 Jan 2017 21:55:23 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 3720D607DA; Thu, 12 Jan 2017 21:55:21 +0000 (UTC) Received: from mail-ot0-f178.google.com (mail-ot0-f178.google.com [74.125.82.178]) by lists.linaro.org (Postfix) with ESMTPS id D4F7A60657 for ; Thu, 12 Jan 2017 21:55:19 +0000 (UTC) Received: by mail-ot0-f178.google.com with SMTP id 73so3481796otj.0 for ; Thu, 12 Jan 2017 13:55:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=OFuKA04+ucYyWGPaF6TTvB2IZkPpqlM+1Ke/0fV05Kg=; b=RkYOpcwfzdkJGlZh2S4qV06lXM7CnVhrirEsHNPsP8lULkwkIsQasJJ/S6sA4/wWOa qjnewbFw3yHS/F3Lkoc8iHMZS+Jd5ibfnWAapnADNIFj40TkTtxRU4BJ2EA+bla7FUbs NhtX+nWeHceKMNFX8nZX5n2Mp7gGVbLWeEbfF5xYRNo5aT+46LLiUupc1KG3YWJU/0uL UD4XYPQ62LGcrKdONyYaY9pn51zD9y8BSinCoAAvyptvnLNSf0cOMJTKaO3/N0DjsL96 cQ6EzQsGEEYoS/7FWWB6eV0l25Hhx3evrW6kYz5U1zmbMRA1aApMrLHpEW611s86WHQW uRUg== X-Gm-Message-State: AIkVDXIid5tqsmZ5RONQYUu0hsSiTHn9QE+9a573UJbiWe2tPAV2qSbasaUschi46Z/eGv6+mzY= X-Received: by 10.157.18.182 with SMTP id g51mr8789421otg.273.1484258119202; Thu, 12 Jan 2017 13:55:19 -0800 (PST) Received: from localhost.localdomain (cpe-70-121-83-241.austin.res.rr.com. [70.121.83.241]) by smtp.gmail.com with ESMTPSA id h74sm4973724oic.9.2017.01.12.13.55.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Jan 2017 13:55:18 -0800 (PST) From: Bill Fischofer To: lng-odp@lists.linaro.org Date: Thu, 12 Jan 2017 15:55:15 -0600 Message-Id: <20170112215515.4234-1-bill.fischofer@linaro.org> X-Mailer: git-send-email 2.9.3 Subject: [lng-odp] [API-NEXT PATCH] linux-generic: packet: tune alloc/free performance for non-reference paths X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" As reported in Bug https://bugs.linaro.org/show_bug.cgi?id=2816 packet alloc/free performance for non-references appears significantly degraded after the introduction of packet reference support. Add fastpaths for non-reference packet frees to optimize this. Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_packet.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) -- 2.9.3 diff --git a/platform/linux-generic/odp_packet.c b/platform/linux-generic/odp_packet.c index 170965a..fa2303b 100644 --- a/platform/linux-generic/odp_packet.c +++ b/platform/linux-generic/odp_packet.c @@ -603,14 +603,23 @@ static inline void packet_free(odp_packet_hdr_t *pkt_hdr) { odp_packet_hdr_t *ref_hdr; uint32_t ref_count; + int num_seg; do { ref_hdr = pkt_hdr->ref_hdr; ref_count = packet_ref_count(pkt_hdr) - 1; - free_bufs(pkt_hdr, 0, pkt_hdr->buf_hdr.segcount); + num_seg = pkt_hdr->buf_hdr.segcount; - if (ref_count == 1) - pkt_hdr->unshared_len = pkt_hdr->frame_len; + if (odp_likely((CONFIG_PACKET_MAX_SEGS == 1 || num_seg == 1) && + ref_count == 0)) { + buffer_free_multi((odp_buffer_t *) + &pkt_hdr->buf_hdr.handle.handle, 1); + } else { + free_bufs(pkt_hdr, 0, num_seg); + + if (ref_count == 1) + pkt_hdr->unshared_len = pkt_hdr->frame_len; + } pkt_hdr = ref_hdr; } while (pkt_hdr);