| Message ID | 1484313256-25993-11-git-send-email-ulf.hansson@linaro.org |
|---|---|
| State | New |
| Headers | show |
On 2017/1/13 21:14, Ulf Hansson wrote: > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > --- > include/linux/mmc/mmc.h | 44 -------------------------------------------- > 1 file changed, 44 deletions(-) > Looks quite strightforward, but it will be better if adding a commit msg body here. Anyway, Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com> > diff --git a/include/linux/mmc/mmc.h b/include/linux/mmc/mmc.h > index 8f78543..7406d9b 100644 > --- a/include/linux/mmc/mmc.h > +++ b/include/linux/mmc/mmc.h > @@ -184,50 +184,6 @@ static inline bool mmc_op_multi(u32 opcode) > #define R2_SPI_OUT_OF_RANGE (1 << 15) /* or CSD overwrite */ > #define R2_SPI_CSD_OVERWRITE R2_SPI_OUT_OF_RANGE > > -/* These are unpacked versions of the actual responses */ > - > -struct _mmc_csd { > - u8 csd_structure; > - u8 spec_vers; > - u8 taac; > - u8 nsac; > - u8 tran_speed; > - u16 ccc; > - u8 read_bl_len; > - u8 read_bl_partial; > - u8 write_blk_misalign; > - u8 read_blk_misalign; > - u8 dsr_imp; > - u16 c_size; > - u8 vdd_r_curr_min; > - u8 vdd_r_curr_max; > - u8 vdd_w_curr_min; > - u8 vdd_w_curr_max; > - u8 c_size_mult; > - union { > - struct { /* MMC system specification version 3.1 */ > - u8 erase_grp_size; > - u8 erase_grp_mult; > - } v31; > - struct { /* MMC system specification version 2.2 */ > - u8 sector_size; > - u8 erase_grp_size; > - } v22; > - } erase; > - u8 wp_grp_size; > - u8 wp_grp_enable; > - u8 default_ecc; > - u8 r2w_factor; > - u8 write_bl_len; > - u8 write_bl_partial; > - u8 file_format_grp; > - u8 copy; > - u8 perm_write_protect; > - u8 tmp_write_protect; > - u8 file_format; > - u8 ecc; > -}; > - > /* > * OCR bits are mostly in host.h > */ > -- Best Regards Shawn Lin -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 16 January 2017 at 04:07, Shawn Lin <shawn.lin@rock-chips.com> wrote: > On 2017/1/13 21:14, Ulf Hansson wrote: >> >> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> >> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> >> --- >> include/linux/mmc/mmc.h | 44 -------------------------------------------- >> 1 file changed, 44 deletions(-) >> > > Looks quite strightforward, but it will be better if adding a > commit msg body here. Anyway, I didn't know what to put there besides what is already said in the header. :-) Anyway, I try to elaborate a bit and add something. [...] Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/mmc/mmc.h b/include/linux/mmc/mmc.h index 8f78543..7406d9b 100644 --- a/include/linux/mmc/mmc.h +++ b/include/linux/mmc/mmc.h @@ -184,50 +184,6 @@ static inline bool mmc_op_multi(u32 opcode) #define R2_SPI_OUT_OF_RANGE (1 << 15) /* or CSD overwrite */ #define R2_SPI_CSD_OVERWRITE R2_SPI_OUT_OF_RANGE -/* These are unpacked versions of the actual responses */ - -struct _mmc_csd { - u8 csd_structure; - u8 spec_vers; - u8 taac; - u8 nsac; - u8 tran_speed; - u16 ccc; - u8 read_bl_len; - u8 read_bl_partial; - u8 write_blk_misalign; - u8 read_blk_misalign; - u8 dsr_imp; - u16 c_size; - u8 vdd_r_curr_min; - u8 vdd_r_curr_max; - u8 vdd_w_curr_min; - u8 vdd_w_curr_max; - u8 c_size_mult; - union { - struct { /* MMC system specification version 3.1 */ - u8 erase_grp_size; - u8 erase_grp_mult; - } v31; - struct { /* MMC system specification version 2.2 */ - u8 sector_size; - u8 erase_grp_size; - } v22; - } erase; - u8 wp_grp_size; - u8 wp_grp_enable; - u8 default_ecc; - u8 r2w_factor; - u8 write_bl_len; - u8 write_bl_partial; - u8 file_format_grp; - u8 copy; - u8 perm_write_protect; - u8 tmp_write_protect; - u8 file_format; - u8 ecc; -}; - /* * OCR bits are mostly in host.h */