From patchwork Tue Jan 17 12:44:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 91638 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp470598qgi; Tue, 17 Jan 2017 04:46:31 -0800 (PST) X-Received: by 10.84.241.203 with SMTP id t11mr58690900plm.18.1484657191484; Tue, 17 Jan 2017 04:46:31 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k63si8497668pfj.144.2017.01.17.04.46.31; Tue, 17 Jan 2017 04:46:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-samsung-soc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-samsung-soc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-samsung-soc-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751213AbdAQMqa (ORCPT + 4 others); Tue, 17 Jan 2017 07:46:30 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:15426 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751060AbdAQMqE (ORCPT ); Tue, 17 Jan 2017 07:46:04 -0500 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OJX0041LCR0ZE70@mailout2.w1.samsung.com>; Tue, 17 Jan 2017 12:45:00 +0000 (GMT) Received: from eusmges4.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20170117124459eucas1p2bb60bd198a1b223439eda867bb2c9304~aj8Qrf3Av0756707567eucas1p2H; Tue, 17 Jan 2017 12:44:59 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges4.samsung.com (EUCPMTA) with SMTP id A6.EB.28517.BC11E785; Tue, 17 Jan 2017 12:44:59 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20170117124459eucas1p160494d6c7509e0d24bfcc73087492430~aj8QFKBtz1114911149eucas1p1_; Tue, 17 Jan 2017 12:44:59 +0000 (GMT) X-AuditID: cbfec7f4-f79716d000006f65-c0-587e11cb824f Received: from eusync2.samsung.com ( [203.254.199.212]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 76.A5.06687.4021E785; Tue, 17 Jan 2017 12:45:56 +0000 (GMT) Received: from AMDC2765.digital.local ([106.116.147.25]) by eusync2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OJX00GNRCQPHB20@eusync2.samsung.com>; Tue, 17 Jan 2017 12:44:59 +0000 (GMT) From: Marek Szyprowski To: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org Cc: Marek Szyprowski , Sylwester Nawrocki , Krzysztof Kozlowski , Linus Walleij , Tomasz Figa , Bartlomiej Zolnierkiewicz Subject: [PATCH v2 05/13] pinctrl: samsung: Remove messages for failed memory allocation Date: Tue, 17 Jan 2017 13:44:36 +0100 Message-id: <1484657084-26227-6-git-send-email-m.szyprowski@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1484657084-26227-1-git-send-email-m.szyprowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAAzWRfUgTcRjH+93ddrfl7DpH/TL1jw0jjHyBgUdWNBK6oCCDUpSslceUnMpu To3QkebLqikZdc5M0SxZ5GqzVb6ETplNoxmYFTqNJAxLKGaQJpHb1X+fh+fzPA9fHgKlprFI Iq/AwOoLNPkKsRRzeVZ8u8c3l2ckvm/eQT/m7SLa53uE0zfW7iO0Y35KRDtb1wAduDYCaN73 AqEfjvhxevhbjYi29a6BA1LmudWPMw5bnZiZmeoXM867FYylxwaYgCPmmDhTujeHzc8zsvqE /WekuTUT77CihbjSheUFzASalWZAEJBUwcbqMDOQrOMWODFrF5uBlKDITgD5VS8abFBkAMAf v9MESQXvmFr+SfcAdNptIqEwIfDTg15R0BKTSdC8ZA5ZcrISwCb/AB4sUNKCwIBzAAStCDIT djUMhiYwMhbOrfYhQZaRDGyyNImFezHQ62kMORLyMPy1YkeCiyB5BYeuDyOIECIaOgZRwU+F 1vZeTOAIuDjagwscBetqhxCB6wG8dHmXwDyAr5dkAqfA4dE3oVsoGQ6vu26hwnoZrK2mBGTg 4qRRsNXwS9UTIIS/DeCYpRtvAFFtYIMNyNliTqdlOVU8p9FxxQXa+HOFOgdYf/n4n9HlZ6DD s8cNSAIowmS8/2IGJdIYuTKdG0ACVchlLWR5BiXL0ZRdYPWFp/XF+SznBtsJTLFV1t82mU6R Wo2BPc+yRaz+fxchJJEm0CGvMqcO8DPdcY0SVeLcZ6+jfuPxkxGZ42Nz2RYLpU7+eGQIby5x 3wy3eNvbv2afUCcrK7piZ9RkSQm/KbpTmWt9etWz+l2R0/pz205DQr92nz3hUEoN4EvnDw46 EINVnZT2yjgmnU6f0DuzdMq+rNlh16lK1Bg4O/Ty7VEFxuVqkuJQPaf5CxbzSGHuAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrLLMWRmVeSWpSXmKPExsVy+t/xK7osQnURBle+MllsnLGe1eL8+Q3s FlP+LGey2PT4GqvF5vl/GC0+9x5htJhxfh+Txdojd9ktDr9pZ7VYtesPowOXx85Zd9k9Nq3q ZPO4c20Pm8fmJfUefVtWMXp83iQXwBblZpORmpiSWqSQmpecn5KZl26rFBripmuhpJCXmJtq qxSh6xsSpKRQlphTCuQZGaABB+cA92AlfbsEt4z2C9dZCp5rVTz/8pylgXG2chcjJ4eEgInE vIa5bBC2mMSFe+vBbCGBJYwSSzebdjFyAdlNTBJNM/cwgyTYBAwlut52sYEkRASaGSUalvSC OcwCE5gkZn5qYAKpEhaIkrh5ZRNYB4uAqsT9X7vB4rwCHhIz+2ZCrZOTOHlsMiuIzSngKfHj 53omiNUeEufv72OdwMi7gJFhFaNIamlxbnpusaFecWJucWleul5yfu4mRmDQbzv2c/MOxksb gw8xCnAwKvHwOtyuiRBiTSwrrsw9xCjBwawkwjtXoC5CiDclsbIqtSg/vqg0J7X4EKMp0FET maVEk/OBEZlXEm9oYmhuaWhkbGFhbmSkJM5b8uFKuJBAemJJanZqakFqEUwfEwenVANj0vPV wR/eT/fZ9nbK5n3lX9but5/6/ttxHVuZ6OkfMtcW8T6YmPKsYAmH0qftqsLvnZSm3+S0epG6 /t7CKc+am2rVyqIPvI3P2POnxnIhD1+S09EXkx0Uv033ZSk0l5Z5/jFy8vXc1F7N5afmcZv3 7Z9x8EvppovtU2RKDUWm/m6x1F1uO9f3ihJLcUaioRZzUXEiAAf653iQAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170117124459eucas1p160494d6c7509e0d24bfcc73087492430 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?utf-8?q?Marek_Szyprowski=1BSRPOL-Kernel_=28TP=29=1B?= =?utf-8?b?7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?utf-8?q?Marek_Szyprowski=1BSRPOL-Kernel_=28TP=29=1BSam?= =?utf-8?q?sung_Electronics=1BSenior_Software_Engineer?= X-Sender-Code: =?utf-8?q?C10=1BEHQ=1BC10CD02CD027392?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170117124459eucas1p160494d6c7509e0d24bfcc73087492430 X-RootMTR: 20170117124459eucas1p160494d6c7509e0d24bfcc73087492430 References: <1484657084-26227-1-git-send-email-m.szyprowski@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Memory subsystem already prints message about failed memory allocation, there is no need to do it in the drivers. Signed-off-by: Marek Szyprowski Reviewed-by: Krzysztof Kozlowski --- drivers/pinctrl/samsung/pinctrl-exynos.c | 8 ++------ drivers/pinctrl/samsung/pinctrl-s3c64xx.c | 12 +++--------- drivers/pinctrl/samsung/pinctrl-samsung.c | 24 ++++++------------------ 3 files changed, 11 insertions(+), 33 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c index 24814db251a7..bf753a596209 100644 --- a/drivers/pinctrl/samsung/pinctrl-exynos.c +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c @@ -528,10 +528,8 @@ static int exynos_eint_wkup_init(struct samsung_pinctrl_drv_data *d) weint_data = devm_kzalloc(dev, bank->nr_pins * sizeof(*weint_data), GFP_KERNEL); - if (!weint_data) { - dev_err(dev, "could not allocate memory for weint_data\n"); + if (!weint_data) return -ENOMEM; - } for (idx = 0; idx < bank->nr_pins; ++idx) { irq = irq_of_parse_and_map(bank->of_node, idx); @@ -559,10 +557,8 @@ static int exynos_eint_wkup_init(struct samsung_pinctrl_drv_data *d) muxed_data = devm_kzalloc(dev, sizeof(*muxed_data) + muxed_banks*sizeof(struct samsung_pin_bank *), GFP_KERNEL); - if (!muxed_data) { - dev_err(dev, "could not allocate memory for muxed_data\n"); + if (!muxed_data) return -ENOMEM; - } irq_set_chained_handler_and_data(irq, exynos_irq_demux_eint16_31, muxed_data); diff --git a/drivers/pinctrl/samsung/pinctrl-s3c64xx.c b/drivers/pinctrl/samsung/pinctrl-s3c64xx.c index 4c632812ccff..f17890aa6e25 100644 --- a/drivers/pinctrl/samsung/pinctrl-s3c64xx.c +++ b/drivers/pinctrl/samsung/pinctrl-s3c64xx.c @@ -489,10 +489,8 @@ static int s3c64xx_eint_gpio_init(struct samsung_pinctrl_drv_data *d) data = devm_kzalloc(dev, sizeof(*data) + nr_domains * sizeof(*data->domains), GFP_KERNEL); - if (!data) { - dev_err(dev, "failed to allocate handler data\n"); + if (!data) return -ENOMEM; - } data->drvdata = d; bank = d->pin_banks; @@ -715,10 +713,8 @@ static int s3c64xx_eint_eint0_init(struct samsung_pinctrl_drv_data *d) return -ENODEV; data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); - if (!data) { - dev_err(dev, "could not allocate memory for wkup eint data\n"); + if (!data) return -ENOMEM; - } data->drvdata = d; for (i = 0; i < NUM_EINT0_IRQ; ++i) { @@ -751,10 +747,8 @@ static int s3c64xx_eint_eint0_init(struct samsung_pinctrl_drv_data *d) ddata = devm_kzalloc(dev, sizeof(*ddata) + nr_eints, GFP_KERNEL); - if (!ddata) { - dev_err(dev, "failed to allocate domain data\n"); + if (!ddata) return -ENOMEM; - } ddata->bank = bank; bank->irq_domain = irq_domain_add_linear(bank->of_node, diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c index 3bc925f61b71..b11e67e85460 100644 --- a/drivers/pinctrl/samsung/pinctrl-samsung.c +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c @@ -93,10 +93,8 @@ static int reserve_map(struct device *dev, struct pinctrl_map **map, return 0; new_map = krealloc(*map, sizeof(*new_map) * new_num, GFP_KERNEL); - if (!new_map) { - dev_err(dev, "krealloc(map) failed\n"); + if (!new_map) return -ENOMEM; - } memset(new_map + old_num, 0, (new_num - old_num) * sizeof(*new_map)); @@ -133,10 +131,8 @@ static int add_map_configs(struct device *dev, struct pinctrl_map **map, dup_configs = kmemdup(configs, num_configs * sizeof(*dup_configs), GFP_KERNEL); - if (!dup_configs) { - dev_err(dev, "kmemdup(configs) failed\n"); + if (!dup_configs) return -ENOMEM; - } (*map)[*num_maps].type = PIN_MAP_TYPE_CONFIGS_GROUP; (*map)[*num_maps].data.configs.group_or_pin = group; @@ -156,10 +152,8 @@ static int add_config(struct device *dev, unsigned long **configs, new_configs = krealloc(*configs, sizeof(*new_configs) * new_num, GFP_KERNEL); - if (!new_configs) { - dev_err(dev, "krealloc(configs) failed\n"); + if (!new_configs) return -ENOMEM; - } new_configs[old_num] = config; @@ -756,10 +750,8 @@ static struct samsung_pmx_func *samsung_pinctrl_create_functions( functions = devm_kzalloc(dev, func_cnt * sizeof(*functions), GFP_KERNEL); - if (!functions) { - dev_err(dev, "failed to allocate memory for function list\n"); + if (!functions) return ERR_PTR(-EINVAL); - } func = functions; /* @@ -850,10 +842,8 @@ static int samsung_pinctrl_register(struct platform_device *pdev, pindesc = devm_kzalloc(&pdev->dev, sizeof(*pindesc) * drvdata->nr_pins, GFP_KERNEL); - if (!pindesc) { - dev_err(&pdev->dev, "mem alloc for pin descriptors failed\n"); + if (!pindesc) return -ENOMEM; - } ctrldesc->pins = pindesc; ctrldesc->npins = drvdata->nr_pins; @@ -867,10 +857,8 @@ static int samsung_pinctrl_register(struct platform_device *pdev, */ pin_names = devm_kzalloc(&pdev->dev, sizeof(char) * PIN_NAME_LENGTH * drvdata->nr_pins, GFP_KERNEL); - if (!pin_names) { - dev_err(&pdev->dev, "mem alloc for pin names failed\n"); + if (!pin_names) return -ENOMEM; - } /* for each pin, the name of the pin is pin-bank name + pin number */ for (bank = 0; bank < drvdata->nr_banks; bank++) {