[v2,1/5] usb: musb: da8xx: Remove CPPI 3.0 quirk and methods

Message ID 20170117143528.11404-2-abailon@baylibre.com
State Superseded
Headers show
Series
  • usb: musb: da8xx: Add DMA support
Related show

Commit Message

Alexandre Bailon Jan. 17, 2017, 2:35 p.m.
DA8xx driver is registering and using the CPPI 3.0 DMA controller but
actually, the DA8xx has a CPPI 4.1 DMA controller.
Remove the CPPI 3.0 quirk and methods.

Signed-off-by: Alexandre Bailon <abailon@baylibre.com>

---
 drivers/usb/musb/da8xx.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

-- 
2.10.2

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Sergei Shtylyov Jan. 17, 2017, 4:17 p.m. | #1
On 01/17/2017 05:35 PM, Alexandre Bailon wrote:

> DA8xx driver is registering and using the CPPI 3.0 DMA controller but

> actually, the DA8xx has a CPPI 4.1 DMA controller.

> Remove the CPPI 3.0 quirk and methods.

>

> Signed-off-by: Alexandre Bailon <abailon@baylibre.com>


Fixes: f8e9f34f80a2 ("usb: musb: Fix up DMA related macros")
Fixes: 7f6283ed6fe8 ("usb: musb: Set up function pointers for DMA")
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>


MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tony Lindgren Jan. 17, 2017, 4:26 p.m. | #2
* Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> [170117 08:18]:
> On 01/17/2017 05:35 PM, Alexandre Bailon wrote:

> 

> > DA8xx driver is registering and using the CPPI 3.0 DMA controller but

> > actually, the DA8xx has a CPPI 4.1 DMA controller.

> > Remove the CPPI 3.0 quirk and methods.

> > 

> > Signed-off-by: Alexandre Bailon <abailon@baylibre.com>

> 

> Fixes: f8e9f34f80a2 ("usb: musb: Fix up DMA related macros")

> Fixes: 7f6283ed6fe8 ("usb: musb: Set up function pointers for DMA")

> Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>


Thanks for fixing this:

Acked-by: Tony Lindgren <tony@atomide.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c
index e89708d..cd3d763 100644
--- a/drivers/usb/musb/da8xx.c
+++ b/drivers/usb/musb/da8xx.c
@@ -458,15 +458,11 @@  static inline u8 get_vbus_power(struct device *dev)
 }
 
 static const struct musb_platform_ops da8xx_ops = {
-	.quirks		= MUSB_DMA_CPPI | MUSB_INDEXED_EP,
+	.quirks		= MUSB_INDEXED_EP,
 	.init		= da8xx_musb_init,
 	.exit		= da8xx_musb_exit,
 
 	.fifo_mode	= 2,
-#ifdef CONFIG_USB_TI_CPPI_DMA
-	.dma_init	= cppi_dma_controller_create,
-	.dma_exit	= cppi_dma_controller_destroy,
-#endif
 	.enable		= da8xx_musb_enable,
 	.disable	= da8xx_musb_disable,