[v2,2/5] net: ethernet: ti: cpsw: don't disable interrupts in ndo_open

Message ID 1484845107-30331-3-git-send-email-ivan.khoronzhuk@linaro.org
State New
Headers show
  • net: ethernet: ti: cpsw: correct common res usage
Related show

Commit Message

Ivan Khoronzhuk Jan. 19, 2017, 4:58 p.m.
No need to disable interrupts if no open devices,
they are disabled anyway.

Even no need to disable interrupts if some ndev is opened, In this
case shared resources are not touched, only parameters of ndev shell,
so no reason to disable them also. Removed lines have proved it.

So, no need in redundant check and interrupt disable.

Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>

 drivers/net/ethernet/ti/cpsw.c | 2 --
 1 file changed, 2 deletions(-)


To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index 296ddf2..f798905 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -1480,8 +1480,6 @@  static int cpsw_ndo_open(struct net_device *ndev)
 		return ret;
-	if (!cpsw_common_res_usage_state(cpsw))
-		cpsw_intr_disable(cpsw);
 	/* Notify the stack of the actual queue counts. */