| Message ID | 20170119104739.4376-4-bjorn.andersson@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/4] phy: qcom-ufs: Don't kfree devres resource | expand |
On Thu, Jan 19, 2017 at 4:17 PM, Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > The error paths of the common qcom-ufs functions for registering the > phy, acquiring clocks and acquiring regulators all print specific error > messages before returning an error, so there is no value in printing yet > another - more generic - message when this occur. > > Cc: Subhash Jadavani <subhashj@codeaurora.org> > Cc: Vivek Gautam <vivek.gautam@codeaurora.org> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- Reviewed-by: Vivek Gautam <vivek.gautam@codeaurora.org> Regards Vivek > drivers/phy/phy-qcom-ufs-qmp-14nm.c | 15 +++------------ > drivers/phy/phy-qcom-ufs-qmp-20nm.c | 12 ++---------- > 2 files changed, 5 insertions(+), 22 deletions(-) > > diff --git a/drivers/phy/phy-qcom-ufs-qmp-14nm.c b/drivers/phy/phy-qcom-ufs-qmp-14nm.c > index c71c84734916..12a1b498dc4b 100644 > --- a/drivers/phy/phy-qcom-ufs-qmp-14nm.c > +++ b/drivers/phy/phy-qcom-ufs-qmp-14nm.c > @@ -132,27 +132,18 @@ static int ufs_qcom_phy_qmp_14nm_probe(struct platform_device *pdev) > &ufs_qcom_phy_qmp_14nm_phy_ops, &phy_14nm_ops); > > if (!generic_phy) { > - dev_err(dev, "%s: ufs_qcom_phy_generic_probe() failed\n", > - __func__); > err = -EIO; > goto out; > } > > err = ufs_qcom_phy_init_clks(phy_common); > - if (err) { > - dev_err(phy_common->dev, > - "%s: ufs_qcom_phy_init_clks() failed %d\n", > - __func__, err); > + if (err) > goto out; > - } > > err = ufs_qcom_phy_init_vregulators(phy_common); > - if (err) { > - dev_err(phy_common->dev, > - "%s: ufs_qcom_phy_init_vregulators() failed %d\n", > - __func__, err); > + if (err) > goto out; > - } > + > phy_common->vdda_phy.max_uV = UFS_PHY_VDDA_PHY_UV; > phy_common->vdda_phy.min_uV = UFS_PHY_VDDA_PHY_UV; > > diff --git a/drivers/phy/phy-qcom-ufs-qmp-20nm.c b/drivers/phy/phy-qcom-ufs-qmp-20nm.c > index 1a26a64e06d3..4f68acb58b73 100644 > --- a/drivers/phy/phy-qcom-ufs-qmp-20nm.c > +++ b/drivers/phy/phy-qcom-ufs-qmp-20nm.c > @@ -190,25 +190,17 @@ static int ufs_qcom_phy_qmp_20nm_probe(struct platform_device *pdev) > &ufs_qcom_phy_qmp_20nm_phy_ops, &phy_20nm_ops); > > if (!generic_phy) { > - dev_err(dev, "%s: ufs_qcom_phy_generic_probe() failed\n", > - __func__); > err = -EIO; > goto out; > } > > err = ufs_qcom_phy_init_clks(phy_common); > - if (err) { > - dev_err(phy_common->dev, "%s: ufs_qcom_phy_init_clks() failed %d\n", > - __func__, err); > + if (err) > goto out; > - } > > err = ufs_qcom_phy_init_vregulators(phy_common); > - if (err) { > - dev_err(phy_common->dev, "%s: ufs_qcom_phy_init_vregulators() failed %d\n", > - __func__, err); > + if (err) > goto out; > - } > > ufs_qcom_phy_qmp_20nm_advertise_quirks(phy_common); > > -- > 2.11.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/phy/phy-qcom-ufs-qmp-14nm.c b/drivers/phy/phy-qcom-ufs-qmp-14nm.c index c71c84734916..12a1b498dc4b 100644 --- a/drivers/phy/phy-qcom-ufs-qmp-14nm.c +++ b/drivers/phy/phy-qcom-ufs-qmp-14nm.c @@ -132,27 +132,18 @@ static int ufs_qcom_phy_qmp_14nm_probe(struct platform_device *pdev) &ufs_qcom_phy_qmp_14nm_phy_ops, &phy_14nm_ops); if (!generic_phy) { - dev_err(dev, "%s: ufs_qcom_phy_generic_probe() failed\n", - __func__); err = -EIO; goto out; } err = ufs_qcom_phy_init_clks(phy_common); - if (err) { - dev_err(phy_common->dev, - "%s: ufs_qcom_phy_init_clks() failed %d\n", - __func__, err); + if (err) goto out; - } err = ufs_qcom_phy_init_vregulators(phy_common); - if (err) { - dev_err(phy_common->dev, - "%s: ufs_qcom_phy_init_vregulators() failed %d\n", - __func__, err); + if (err) goto out; - } + phy_common->vdda_phy.max_uV = UFS_PHY_VDDA_PHY_UV; phy_common->vdda_phy.min_uV = UFS_PHY_VDDA_PHY_UV; diff --git a/drivers/phy/phy-qcom-ufs-qmp-20nm.c b/drivers/phy/phy-qcom-ufs-qmp-20nm.c index 1a26a64e06d3..4f68acb58b73 100644 --- a/drivers/phy/phy-qcom-ufs-qmp-20nm.c +++ b/drivers/phy/phy-qcom-ufs-qmp-20nm.c @@ -190,25 +190,17 @@ static int ufs_qcom_phy_qmp_20nm_probe(struct platform_device *pdev) &ufs_qcom_phy_qmp_20nm_phy_ops, &phy_20nm_ops); if (!generic_phy) { - dev_err(dev, "%s: ufs_qcom_phy_generic_probe() failed\n", - __func__); err = -EIO; goto out; } err = ufs_qcom_phy_init_clks(phy_common); - if (err) { - dev_err(phy_common->dev, "%s: ufs_qcom_phy_init_clks() failed %d\n", - __func__, err); + if (err) goto out; - } err = ufs_qcom_phy_init_vregulators(phy_common); - if (err) { - dev_err(phy_common->dev, "%s: ufs_qcom_phy_init_vregulators() failed %d\n", - __func__, err); + if (err) goto out; - } ufs_qcom_phy_qmp_20nm_advertise_quirks(phy_common);
The error paths of the common qcom-ufs functions for registering the phy, acquiring clocks and acquiring regulators all print specific error messages before returning an error, so there is no value in printing yet another - more generic - message when this occur. Cc: Subhash Jadavani <subhashj@codeaurora.org> Cc: Vivek Gautam <vivek.gautam@codeaurora.org> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> --- drivers/phy/phy-qcom-ufs-qmp-14nm.c | 15 +++------------ drivers/phy/phy-qcom-ufs-qmp-20nm.c | 12 ++---------- 2 files changed, 5 insertions(+), 22 deletions(-) -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html