[7/8] ARM: dts: STiH407-family: Use new Pinctrl groups

Message ID 20170124134310.27512-8-lee.jones@linaro.org
State New
Headers show
Series
  • serial: st-asc: Allow handling of RTS line
Related show

Commit Message

Lee Jones Jan. 24, 2017, 1:43 p.m.
Having just defined some new Pinctrl groups for when when HW flow-
control is {en,dis}abled, let's reference them for use within the
driver.

Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 arch/arm/boot/dts/stih407-family.dtsi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

-- 
2.10.2

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Peter Griffin Jan. 25, 2017, 11:54 a.m. | #1
Hi Lee,

On Tue, 24 Jan 2017, Lee Jones wrote:

> Having just defined some new Pinctrl groups for when when HW flow-

> control is {en,dis}abled, let's reference them for use within the

> driver.

> 

> Signed-off-by: Lee Jones <lee.jones@linaro.org>


Same as previous comment, your enabling hw flow control for all
stih407 family boards. I've not checked the schematics for them
but as hw flow control is dependent on board wiring, IMO this
should be added in board specific file.

regards,

Peter.

> ---

>  arch/arm/boot/dts/stih407-family.dtsi | 5 +++--

>  1 file changed, 3 insertions(+), 2 deletions(-)

> 

> diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi

> index c8b2944..9789978 100644

> --- a/arch/arm/boot/dts/stih407-family.dtsi

> +++ b/arch/arm/boot/dts/stih407-family.dtsi

> @@ -222,8 +222,9 @@

>  			compatible = "st,asc";

>  			reg = <0x9830000 0x2c>;

>  			interrupts = <GIC_SPI 122 IRQ_TYPE_NONE>;

> -			pinctrl-names = "default";

> -			pinctrl-0 = <&pinctrl_serial0>;

> +			pinctrl-names = "default", "manual-rts";

> +			pinctrl-0 = <&pinctrl_serial0_flowctrl>;

> +			pinctrl-1 = <&pinctrl_serial0>;

>  			clocks = <&clk_s_c0_flexgen CLK_EXT2F_A9>;

>  

>  			status = "disabled";

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
index c8b2944..9789978 100644
--- a/arch/arm/boot/dts/stih407-family.dtsi
+++ b/arch/arm/boot/dts/stih407-family.dtsi
@@ -222,8 +222,9 @@ 
 			compatible = "st,asc";
 			reg = <0x9830000 0x2c>;
 			interrupts = <GIC_SPI 122 IRQ_TYPE_NONE>;
-			pinctrl-names = "default";
-			pinctrl-0 = <&pinctrl_serial0>;
+			pinctrl-names = "default", "manual-rts";
+			pinctrl-0 = <&pinctrl_serial0_flowctrl>;
+			pinctrl-1 = <&pinctrl_serial0>;
 			clocks = <&clk_s_c0_flexgen CLK_EXT2F_A9>;
 
 			status = "disabled";