| Message ID | 1485277900-22730-1-git-send-email-ard.biesheuvel@linaro.org |
|---|---|
| State | Accepted |
| Commit | 79ba11d24b28ead94b976c4d7c8bf8e6c349eb36 |
| Headers | show |
On Tue, Jan 24, 2017 at 05:11:40PM +0000, Ard Biesheuvel wrote: > Memory regions marked as NOMAP should not be used for general allocation > by the kernel, and should not even be covered by the linear mapping > (hence the name). However, drivers or other subsystems (such as ACPI) > that access the firmware directly may legally access them, which means > it is also reasonable for such drivers to claim them by invoking > request_resource(). Currently, this is prevented by the fact that arm64's > request_standard_resources() marks reserved regions as IORESOURCE_BUSY. > > So drop the IORESOURCE_BUSY flag from these requests. > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > --- > arch/arm64/kernel/setup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Did you find this my inspection, or has somebody reported a problem? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On 24 January 2017 at 18:01, Will Deacon <will.deacon@arm.com> wrote: > On Tue, Jan 24, 2017 at 05:11:40PM +0000, Ard Biesheuvel wrote: >> Memory regions marked as NOMAP should not be used for general allocation >> by the kernel, and should not even be covered by the linear mapping >> (hence the name). However, drivers or other subsystems (such as ACPI) >> that access the firmware directly may legally access them, which means >> it is also reasonable for such drivers to claim them by invoking >> request_resource(). Currently, this is prevented by the fact that arm64's >> request_standard_resources() marks reserved regions as IORESOURCE_BUSY. >> >> So drop the IORESOURCE_BUSY flag from these requests. >> >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> >> --- >> arch/arm64/kernel/setup.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Did you find this my inspection, or has somebody reported a problem? > Hanjun (whom I forgot to cc) reported an issue with the ACPI EINJ (error injection) code, which may call request_resource() on UEFI reserved regions. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On 2017/1/25 2:13, Ard Biesheuvel wrote: > On 24 January 2017 at 18:01, Will Deacon <will.deacon@arm.com> wrote: >> On Tue, Jan 24, 2017 at 05:11:40PM +0000, Ard Biesheuvel wrote: >>> Memory regions marked as NOMAP should not be used for general allocation >>> by the kernel, and should not even be covered by the linear mapping >>> (hence the name). However, drivers or other subsystems (such as ACPI) >>> that access the firmware directly may legally access them, which means >>> it is also reasonable for such drivers to claim them by invoking >>> request_resource(). Currently, this is prevented by the fact that arm64's >>> request_standard_resources() marks reserved regions as IORESOURCE_BUSY. >>> >>> So drop the IORESOURCE_BUSY flag from these requests. >>> >>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> >>> --- >>> arch/arm64/kernel/setup.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Did you find this my inspection, or has somebody reported a problem? >> > > Hanjun (whom I forgot to cc) reported an issue with the ACPI EINJ > (error injection) code, which may call request_resource() on UEFI > reserved regions. Yes, we were testing ACPI error ejection thought the register region, the register region is reported by firmware in EINJ table which the table is marked as reserved, then in the kernel will failed to request the memory region because all the reserved memory block is set to IORESOURCE_BUSY before this patch. Tested this patch and error ejecting works OK. Thanks Hanjun _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c index b051367e2149..888295e46b53 100644 --- a/arch/arm64/kernel/setup.c +++ b/arch/arm64/kernel/setup.c @@ -208,7 +208,7 @@ static void __init request_standard_resources(void) res = alloc_bootmem_low(sizeof(*res)); if (memblock_is_nomap(region)) { res->name = "reserved"; - res->flags = IORESOURCE_MEM | IORESOURCE_BUSY; + res->flags = IORESOURCE_MEM; } else { res->name = "System RAM"; res->flags = IORESOURCE_SYSTEM_RAM | IORESOURCE_BUSY;
Memory regions marked as NOMAP should not be used for general allocation by the kernel, and should not even be covered by the linear mapping (hence the name). However, drivers or other subsystems (such as ACPI) that access the firmware directly may legally access them, which means it is also reasonable for such drivers to claim them by invoking request_resource(). Currently, this is prevented by the fact that arm64's request_standard_resources() marks reserved regions as IORESOURCE_BUSY. So drop the IORESOURCE_BUSY flag from these requests. Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> --- arch/arm64/kernel/setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel