From patchwork Tue Jan 24 17:45:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 92384 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp1829831qgi; Tue, 24 Jan 2017 09:45:42 -0800 (PST) X-Received: by 10.98.192.216 with SMTP id g85mr40113258pfk.117.1485279942790; Tue, 24 Jan 2017 09:45:42 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u5si19984577pgh.266.2017.01.24.09.45.42; Tue, 24 Jan 2017 09:45:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750765AbdAXRpl (ORCPT + 7 others); Tue, 24 Jan 2017 12:45:41 -0500 Received: from mail-ot0-f195.google.com ([74.125.82.195]:35860 "EHLO mail-ot0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750797AbdAXRpj (ORCPT ); Tue, 24 Jan 2017 12:45:39 -0500 Received: by mail-ot0-f195.google.com with SMTP id 36so20452459otx.3; Tue, 24 Jan 2017 09:45:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Kg+GV/0aENg7rfmtqthWXL8IIquGmInJY9hC/+/H524=; b=TI+RW/WE8B7H2iPQMvTVnv//BRDQO17cVQy4ZRozwg4yEk0qzdZ+a4yUUcMcq+fahS 4oZXteBJ7Nj0+6xz+Wq89xDVjDV6RoH+HUHZpWNabmLFppI9N0AEWV2wE3jnruA3gd8d C5BVq4KoiDvcGbJOW9sMeu41whM1HMRYosPdermmdFISLsn9ky8p7XLA30T6dXAP4XkB yY2Ke2yS9dO03cVx3J1dXKGaTgHAFT1vhONZoW5vhKe6TDMrdixpSEgjcA39q9iHUtdU BwNbETE3yCgVt+AeB190Bwnkfz4/4zSFKkXw7evoPr8tZ/r8O+e0rVngUVB1/ckdOdir mbMg== X-Gm-Message-State: AIkVDXKDFoeGM5Ij2BylE3eWDSTe2EPvlLJ5vWznVVlwZIo92y8prhM36ylrauIpHMl4hQ== X-Received: by 10.157.27.154 with SMTP id z26mr18821883otd.181.1485279938699; Tue, 24 Jan 2017 09:45:38 -0800 (PST) Received: from rob-hp-laptop.herring.priv (72-48-98-129.dyn.grandenetworks.net. [72.48.98.129]) by smtp.googlemail.com with ESMTPSA id w84sm10736088oiw.21.2017.01.24.09.45.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Jan 2017 09:45:38 -0800 (PST) From: Rob Herring To: David Gibson Cc: devicetree@vger.kernel.org, devicetree-compiler@vger.kernel.org Subject: [PATCH 4/5] checks: Add infrastructure for setting bus type of nodes Date: Tue, 24 Jan 2017 11:45:33 -0600 Message-Id: <20170124174534.3865-5-robh@kernel.org> X-Mailer: git-send-email 2.10.1 In-Reply-To: <20170124174534.3865-1-robh@kernel.org> References: <20170124174534.3865-1-robh@kernel.org> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org In preparation to support bus specific checks, add the necessary infrastructure to determine and set the bus type for nodes. Signed-off-by: Rob Herring --- checks.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++ dtc.h | 11 +++++++++++ 2 files changed, 62 insertions(+) -- 2.10.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Signed-off-by: Rob Herring diff --git a/checks.c b/checks.c index 8e310d69ca3d..5ef63a6a4317 100644 --- a/checks.c +++ b/checks.c @@ -587,6 +587,53 @@ static void fixup_path_references(struct check *c, struct dt_info *dti, } ERROR(path_references, fixup_path_references, NULL, &duplicate_node_names); +struct bus_type *bus_types[] = { + NULL +}; + +static void fixup_bus_type(struct check *c, struct dt_info *dti, + struct node *node) +{ + struct bus_type **bus; + + for (bus = bus_types; *bus != NULL; bus++) { + if (!(*bus)->bridge_is_type(node)) + continue; + + node->bus_type = *bus; + break; + } +} +ERROR(bus_type, fixup_bus_type, NULL); + +static void check_bus_bridge(struct check *c, struct dt_info *dti, + struct node *node) +{ + struct bus_type *bt; + + if (!node->bus_type) + return; + + bt = node->bus_type; + if (bt->check_bridge) + bt->check_bridge(c, dti, node); +} +WARNING(bus_bridge, check_bus_bridge, NULL); + +static void check_bus_device(struct check *c, struct dt_info *dti, + struct node *node) +{ + struct bus_type *bt; + + if (!node->parent || !node->parent->bus_type) + return; + + bt = node->parent->bus_type; + if (bt->check_device) + bt->check_device(c, dti, node); +} +WARNING(bus_device, check_bus_device, NULL); + /* * Semantic checks */ @@ -753,6 +800,7 @@ static struct check *check_table[] = { &explicit_phandles, &phandle_references, &path_references, + &bus_type, &address_cells_is_cell, &size_cells_is_cell, &interrupt_cells_is_cell, &device_type_is_string, &model_is_string, &status_is_string, @@ -764,6 +812,9 @@ static struct check *check_table[] = { &unit_address_vs_reg, + &bus_bridge, + &bus_device, + &avoid_default_addr_size, &obsolete_chosen_interrupt_controller, diff --git a/dtc.h b/dtc.h index c6f125c68ba8..f27397cd7622 100644 --- a/dtc.h +++ b/dtc.h @@ -136,6 +136,16 @@ struct label { struct label *next; }; +struct check; +struct node; +struct dt_info; + +struct bus_type { + bool (*bridge_is_type)(struct node *node); + void (*check_bridge)(struct check *c, struct dt_info *dti, struct node *node); + void (*check_device)(struct check *c, struct dt_info *dti, struct node *node); +}; + struct property { bool deleted; char *name; @@ -162,6 +172,7 @@ struct node { int addr_cells, size_cells; struct label *labels; + struct bus_type *bus_type; }; #define for_each_label_withdel(l0, l) \