| Message ID | 1339577229-32443-1-git-send-email-sachin.kamat@linaro.org |
|---|---|
| State | Accepted |
| Headers | show |
> -----Original Message----- > From: Sachin Kamat [mailto:sachin.kamat@linaro.org] > Sent: Wednesday, June 13, 2012 5:47 PM > To: dri-devel@lists.freedesktop.org > Cc: inki.dae@samsung.com; airlied@linux.ie; sachin.kamat@linaro.org; > patches@linaro.org > Subject: [PATCH] drm/exynos: Add missing static storage class specifier > > Fixes the following sparse warning: > drivers/gpu/drm/exynos/exynos_drm_connector.c:199:20: > warning: symbol 'exynos_drm_best_encoder' was not declared. Should it be > static? > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- > drivers/gpu/drm/exynos/exynos_drm_connector.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_connector.c > b/drivers/gpu/drm/exynos/exynos_drm_connector.c > index bf791fa..d956819 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_connector.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_connector.c > @@ -196,7 +196,8 @@ static int exynos_drm_connector_mode_valid(struct > drm_connector *connector, > return ret; > } > > -struct drm_encoder *exynos_drm_best_encoder(struct drm_connector > *connector) > +static struct drm_encoder *exynos_drm_best_encoder( > + struct drm_connector *connector) > { > struct drm_device *dev = connector->dev; > struct exynos_drm_connector *exynos_connector = > -- > 1.7.4.1 Applied. Thanks, Inki Dae
diff --git a/drivers/gpu/drm/exynos/exynos_drm_connector.c b/drivers/gpu/drm/exynos/exynos_drm_connector.c index bf791fa..d956819 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_connector.c +++ b/drivers/gpu/drm/exynos/exynos_drm_connector.c @@ -196,7 +196,8 @@ static int exynos_drm_connector_mode_valid(struct drm_connector *connector, return ret; } -struct drm_encoder *exynos_drm_best_encoder(struct drm_connector *connector) +static struct drm_encoder *exynos_drm_best_encoder( + struct drm_connector *connector) { struct drm_device *dev = connector->dev; struct exynos_drm_connector *exynos_connector =
Fixes the following sparse warning: drivers/gpu/drm/exynos/exynos_drm_connector.c:199:20: warning: symbol 'exynos_drm_best_encoder' was not declared. Should it be static? Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- drivers/gpu/drm/exynos/exynos_drm_connector.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)