From patchwork Sat Jan 28 23:25:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 92769 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp847177qgi; Sat, 28 Jan 2017 15:26:01 -0800 (PST) X-Received: by 10.98.80.146 with SMTP id g18mr16361579pfj.74.1485645961305; Sat, 28 Jan 2017 15:26:01 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3si8337414pli.45.2017.01.28.15.26.01; Sat, 28 Jan 2017 15:26:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752553AbdA1X0A (ORCPT + 1 other); Sat, 28 Jan 2017 18:26:00 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:38045 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751947AbdA1X0A (ORCPT ); Sat, 28 Jan 2017 18:26:00 -0500 Received: by mail-wm0-f51.google.com with SMTP id r126so35378690wmr.1 for ; Sat, 28 Jan 2017 15:25:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Twhl3TaN4Yleujf68Qk0fFCweF7qBJDAw0TmYcZHr54=; b=H+eQ04wRWLbglT2mBmDQzrkwVCPRoKuYmGbvlzDWGL/qKQ2TXGdTjbDpMtot01GLjK 2eJu3sTpINiyWRAbD+12nf3Prejkilsmgbyr76KBlaDggKCYAq2hrBOgewFl1wEVD47S pUYE31+JU5sHXVpOV9BoiHLALekNRB0WudMrY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Twhl3TaN4Yleujf68Qk0fFCweF7qBJDAw0TmYcZHr54=; b=eZ0LZyczZncToBJqAzDuu1kFF2+ua44NJjTE+rcOBbFxwq7clsHk4fXpkMJaQ950gl DDa57XlRuTO1o5xa8lJApqTnyhwtiwbgClU6XEnU+LD0ZKiUrXO6Q8x9iiYtAsUaN49+ c5ntqJB3WvS1Z8KIRSZX9YM1BpyLBB8zNhm+SI3TDgiGejWMjvyk7ZoxyVq+ChJF7jls QsYmiaHQ+VyyNInNBPGAnMGmltwqOCSFKstcVfeEtQq5hxRVZbcNzPIyyEHsrAlasfC2 pDqThaoCORVuOpADDHDY2kFAFJeD4+sK8J6K0MtwYn6DnbDVukCgqDupevBEG3S7Vx3B dKOQ== X-Gm-Message-State: AIkVDXJidYgKrp0W7okfFyrEYuEUb+GjrlDZ/fbZ4zuLecXcVAlocY53I1PUx53Mi3xDgN8o X-Received: by 10.28.44.66 with SMTP id s63mr7876758wms.77.1485645958397; Sat, 28 Jan 2017 15:25:58 -0800 (PST) Received: from localhost.localdomain ([160.163.215.165]) by smtp.gmail.com with ESMTPSA id 33sm14992064wrd.34.2017.01.28.15.25.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 28 Jan 2017 15:25:57 -0800 (PST) From: Ard Biesheuvel To: linux-crypto@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, herbert@gondor.apana.org.au, Ard Biesheuvel Subject: [PATCH v3 03/10] crypto: arm/chacha20 - remove cra_alignmask Date: Sat, 28 Jan 2017 23:25:32 +0000 Message-Id: <1485645939-17126-4-git-send-email-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1485645939-17126-1-git-send-email-ard.biesheuvel@linaro.org> References: <1485645939-17126-1-git-send-email-ard.biesheuvel@linaro.org> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Remove the unnecessary alignmask: it is much more efficient to deal with the misalignment in the core algorithm than relying on the crypto API to copy the data to a suitably aligned buffer. Signed-off-by: Ard Biesheuvel --- arch/arm/crypto/chacha20-neon-glue.c | 1 - 1 file changed, 1 deletion(-) -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/crypto/chacha20-neon-glue.c b/arch/arm/crypto/chacha20-neon-glue.c index 592f75ae4fa1..59a7be08e80c 100644 --- a/arch/arm/crypto/chacha20-neon-glue.c +++ b/arch/arm/crypto/chacha20-neon-glue.c @@ -94,7 +94,6 @@ static struct skcipher_alg alg = { .base.cra_priority = 300, .base.cra_blocksize = 1, .base.cra_ctxsize = sizeof(struct chacha20_ctx), - .base.cra_alignmask = 1, .base.cra_module = THIS_MODULE, .min_keysize = CHACHA20_KEY_SIZE,