| Message ID | 1485937664-25545-1-git-send-email-kishon@ti.com |
|---|---|
| State | Superseded |
| Headers | show |
Quoting Kishon Vijay Abraham I (2017-02-01 00:27:44) > commit e2427b09ba929c2b9 (phy: Add support for Qualcomm's USB HS phy") > while using extcon API's in qcom-usb-hs failed to add > 'depends on EXTCON' resulting in the following compile errors if > EXTCON is not enabled. > drivers/built-in.o: In function `qcom_usb_hs_phy_power_off': > phy-qcom-usb-hs.c:(.text+0x1089): undefined reference to `extcon_unregister_notifier' > drivers/built-in.o: In function `qcom_usb_hs_phy_probe': > phy-qcom-usb-hs.c:(.text+0x11b5): undefined reference to `extcon_get_edev_by_phandle' > drivers/built-in.o: In function `qcom_usb_hs_phy_power_on': > phy-qcom-usb-hs.c:(.text+0x128e): undefined reference to `extcon_get_state' > phy-qcom-usb-hs.c:(.text+0x12a9): undefined reference to `extcon_register_notifier' > > Fix it here. > > Fixes: 9994a33865f4 e2427b09ba929c2b9 (phy: Add support for Qualcomm's USB > HS phy") > > Cc: Stephen Boyd <stephen.boyd@linaro.org> > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> The extcon is optional in the binding, so "depends on EXTCON" is incorrect. It should follow the modular or non-modular nature of extcon if extcon is enabled and still compile if extcon is disabled. So we want this instead. Care to replace it with this patch? ----8<----diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index bb5cf6f49b06..3c2822457784 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -441,6 +441,7 @@ config PHY_QCOM_UFS config PHY_QCOM_USB_HS tristate "Qualcomm USB HS PHY module" depends on USB_ULPI_BUS + depends on EXTCON || !EXTCON # if EXTCON=m, this cannot be built-in select GENERIC_PHY help Support for the USB high-speed ULPI compliant phy on Qualcomm
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index bb5cf6f..c11aba6 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -440,6 +440,7 @@ config PHY_QCOM_UFS config PHY_QCOM_USB_HS tristate "Qualcomm USB HS PHY module" + depends on EXTCON depends on USB_ULPI_BUS select GENERIC_PHY help
commit e2427b09ba929c2b9 (phy: Add support for Qualcomm's USB HS phy") while using extcon API's in qcom-usb-hs failed to add 'depends on EXTCON' resulting in the following compile errors if EXTCON is not enabled. drivers/built-in.o: In function `qcom_usb_hs_phy_power_off': phy-qcom-usb-hs.c:(.text+0x1089): undefined reference to `extcon_unregister_notifier' drivers/built-in.o: In function `qcom_usb_hs_phy_probe': phy-qcom-usb-hs.c:(.text+0x11b5): undefined reference to `extcon_get_edev_by_phandle' drivers/built-in.o: In function `qcom_usb_hs_phy_power_on': phy-qcom-usb-hs.c:(.text+0x128e): undefined reference to `extcon_get_state' phy-qcom-usb-hs.c:(.text+0x12a9): undefined reference to `extcon_register_notifier' Fix it here. Fixes: 9994a33865f4 e2427b09ba929c2b9 (phy: Add support for Qualcomm's USB HS phy") Cc: Stephen Boyd <stephen.boyd@linaro.org> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> --- drivers/phy/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 1.7.9.5