diff mbox

gdb 7.12: fix armv8b build

Message ID 20170202102828.19819-1-koen.kooi@linaro.org
State Accepted
Commit 0635a96d82f5f5dd65a2d45ddca7559dea847916
Headers show

Commit Message

Koen Kooi Feb. 2, 2017, 10:28 a.m. UTC
Backport fix from GDB upstream to fix big-endian aarch64 build.

Signed-off-by: Koen Kooi <koen.kooi@linaro.org>

---
 meta/recipes-devtools/gdb/gdb-7.12.inc             |  1 +
 .../cb93dc7f262978bafe36397a41a56e409a302042.patch | 42 ++++++++++++++++++++++
 2 files changed, 43 insertions(+)
 create mode 100644 meta/recipes-devtools/gdb/gdb/cb93dc7f262978bafe36397a41a56e409a302042.patch

-- 
2.9.3

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Ross Burton Feb. 2, 2017, 12:04 p.m. UTC | #1
On 2 February 2017 at 10:28, Koen Kooi <koen.kooi@linaro.org> wrote:

> +++ b/meta/recipes-devtools/gdb/gdb/cb93dc7f262978bafe36397a41a56e

> 409a302042.patch

> @@ -0,0 +1,42 @@

> +From cb93dc7f262978bafe36397a41a56e409a302042 Mon Sep 17 00:00:00 2001

> +From: Yao Qi <yao.qi@linaro.org>

> +Date: Mon, 24 Oct 2016 10:59:11 +0100

> +Subject: [PATCH] [GDBserver] Fix conversion warning

> +

> +I got the following warning if I build GDBserver for aarch64_be-linux-gnu,

> +

> +git/gdb/gdbserver/linux-aarch64-low.c:1539:39: error: invalid conversion

> from 'void*' to 'uint32_t* {aka unsigned int*}' [-fpermissive]

> +   uint32_t *le_buf = xmalloc (byte_len);

> +                                       ^

> +The patch is to fix the warning.

> +

> +gdb/gdbserver:

> +

> +2016-10-24  Yao Qi  <yao.qi@linaro.org>

> +

> +       PR server/20733

> +       * linux-aarch64-low.c (append_insns): Cast the return value to

> +       'uint32_t *'.

> +

> +Upstream-status: Backport

>


That's not the nicest patch filename, and needs a S-o-b.

Ross
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
diff mbox

Patch

diff --git a/meta/recipes-devtools/gdb/gdb-7.12.inc b/meta/recipes-devtools/gdb/gdb-7.12.inc
index 2faddc5..7eea65f 100644
--- a/meta/recipes-devtools/gdb/gdb-7.12.inc
+++ b/meta/recipes-devtools/gdb/gdb-7.12.inc
@@ -15,6 +15,7 @@  SRC_URI = "http://ftp.gnu.org/gnu/gdb/gdb-${PV}.tar.xz \
            file://0008-Use-exorted-definitions-of-SIGRTMIN.patch \
            file://0009-Change-order-of-CFLAGS.patch \
            file://0010-resolve-restrict-keyword-conflict.patch \
+	   file://cb93dc7f262978bafe36397a41a56e409a302042.patch \
 "
 SRC_URI[md5sum] = "a0a3a00f7499b0c5278ba8676745d180"
 SRC_URI[sha256sum] = "834ff3c5948b30718343ea57b11cbc3235d7995c6a4f3a5cecec8c8114164f94"
diff --git a/meta/recipes-devtools/gdb/gdb/cb93dc7f262978bafe36397a41a56e409a302042.patch b/meta/recipes-devtools/gdb/gdb/cb93dc7f262978bafe36397a41a56e409a302042.patch
new file mode 100644
index 0000000..a3f488a
--- /dev/null
+++ b/meta/recipes-devtools/gdb/gdb/cb93dc7f262978bafe36397a41a56e409a302042.patch
@@ -0,0 +1,42 @@ 
+From cb93dc7f262978bafe36397a41a56e409a302042 Mon Sep 17 00:00:00 2001
+From: Yao Qi <yao.qi@linaro.org>
+Date: Mon, 24 Oct 2016 10:59:11 +0100
+Subject: [PATCH] [GDBserver] Fix conversion warning
+
+I got the following warning if I build GDBserver for aarch64_be-linux-gnu,
+
+git/gdb/gdbserver/linux-aarch64-low.c:1539:39: error: invalid conversion from 'void*' to 'uint32_t* {aka unsigned int*}' [-fpermissive]
+   uint32_t *le_buf = xmalloc (byte_len);
+                                       ^
+The patch is to fix the warning.
+
+gdb/gdbserver:
+
+2016-10-24  Yao Qi  <yao.qi@linaro.org>
+
+	PR server/20733
+	* linux-aarch64-low.c (append_insns): Cast the return value to
+	'uint32_t *'.
+
+Upstream-status: Backport
+
+---
+ gdb/gdbserver/linux-aarch64-low.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/gdb/gdbserver/linux-aarch64-low.c b/gdb/gdbserver/linux-aarch64-low.c
+index e54a8ba..ae80cdd 100644
+--- a/gdb/gdbserver/linux-aarch64-low.c
++++ b/gdb/gdbserver/linux-aarch64-low.c
+@@ -1536,7 +1536,7 @@ append_insns (CORE_ADDR *to, size_t len, const uint32_t *buf)
+ {
+   size_t byte_len = len * sizeof (uint32_t);
+ #if (__BYTE_ORDER == __BIG_ENDIAN)
+-  uint32_t *le_buf = xmalloc (byte_len);
++  uint32_t *le_buf = (uint32_t *) xmalloc (byte_len);
+   size_t i;
+ 
+   for (i = 0; i < len; i++)
+-- 
+2.9.3
+