diff mbox

board: ti: am57xx: enable input on mmc clock

Message ID 20170208131359.32681-1-nsekhar@ti.com
State Accepted
Commit 411278b858732ccc12ae48715b3934514c904bd4
Headers show

Commit Message

Sekhar Nori Feb. 8, 2017, 1:13 p.m. UTC
As per the latest pinmux data available for AM572x EVM,
rev A3, input should be enabled on MMC clock lines for
MMC2/2/3 for stable operation.

Further, AM572x TRM, SPRUHZ6, Revised June 2016, in
section 18.4.6.1.1 "Pad Configuration Registers" states
that input should be enabled for MMC 2/3/4 clock lines.

Enable input on MMC1 and MMC3 clock to match the latest
pinmux data. Input is already enabled on MMC2 clock for
BeagleBoard x15. Further, input is already enabled on all
MMCx clocks for other AM57xx boards (AM572x and AM571x
IDK).

Tested with HS and UHS SD card on AM572x EVM Rev A3.

Signed-off-by: Sekhar Nori <nsekhar@ti.com>

---
 board/ti/am57xx/mux_data.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.9.0

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Comments

Lokesh Vutla Feb. 8, 2017, 1:37 p.m. UTC | #1
On Wednesday 08 February 2017 06:43 PM, Sekhar Nori wrote:
> As per the latest pinmux data available for AM572x EVM,

> rev A3, input should be enabled on MMC clock lines for

> MMC2/2/3 for stable operation.

> 

> Further, AM572x TRM, SPRUHZ6, Revised June 2016, in

> section 18.4.6.1.1 "Pad Configuration Registers" states

> that input should be enabled for MMC 2/3/4 clock lines.

> 

> Enable input on MMC1 and MMC3 clock to match the latest

> pinmux data. Input is already enabled on MMC2 clock for

> BeagleBoard x15. Further, input is already enabled on all

> MMCx clocks for other AM57xx boards (AM572x and AM571x

> IDK).

> 

> Tested with HS and UHS SD card on AM572x EVM Rev A3.

> 

> Signed-off-by: Sekhar Nori <nsekhar@ti.com>


Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>


Thanks and regards,
Lokesh
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Tom Rini April 9, 2017, 1:14 a.m. UTC | #2
On Wed, Feb 08, 2017 at 06:43:59PM +0530, Sekhar Nori wrote:

> As per the latest pinmux data available for AM572x EVM,

> rev A3, input should be enabled on MMC clock lines for

> MMC2/2/3 for stable operation.

> 

> Further, AM572x TRM, SPRUHZ6, Revised June 2016, in

> section 18.4.6.1.1 "Pad Configuration Registers" states

> that input should be enabled for MMC 2/3/4 clock lines.

> 

> Enable input on MMC1 and MMC3 clock to match the latest

> pinmux data. Input is already enabled on MMC2 clock for

> BeagleBoard x15. Further, input is already enabled on all

> MMCx clocks for other AM57xx boards (AM572x and AM571x

> IDK).

> 

> Tested with HS and UHS SD card on AM572x EVM Rev A3.

> 

> Signed-off-by: Sekhar Nori <nsekhar@ti.com>

> Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>


Applied to u-boot/master, thanks!

-- 
Tom
diff mbox

Patch

diff --git a/board/ti/am57xx/mux_data.h b/board/ti/am57xx/mux_data.h
index 2f5243ee7ad9..42150b0401cf 100644
--- a/board/ti/am57xx/mux_data.h
+++ b/board/ti/am57xx/mux_data.h
@@ -212,7 +212,7 @@  const struct pad_conf_entry core_padconf_array_essential_x15[] = {
 	{MCASP5_FSX, (M3 | PIN_OUTPUT_PULLDOWN)},	/* mcasp5_fsx.uart9_txd */
 	{MCASP5_AXR0, (M3 | PIN_INPUT_PULLDOWN)},	/* mcasp5_axr0.uart9_ctsn */
 	{MCASP5_AXR1, (M3 | PIN_OUTPUT_PULLUP)},	/* mcasp5_axr1.uart9_rtsn */
-	{MMC1_CLK, (M0 | PIN_OUTPUT_PULLUP)},	/* mmc1_clk.mmc1_clk */
+	{MMC1_CLK, (M0 | PIN_INPUT_PULLUP)},	/* mmc1_clk.mmc1_clk */
 	{MMC1_CMD, (M0 | PIN_INPUT_PULLUP)},	/* mmc1_cmd.mmc1_cmd */
 	{MMC1_DAT0, (M0 | PIN_INPUT_PULLUP)},	/* mmc1_dat0.mmc1_dat0 */
 	{MMC1_DAT1, (M0 | PIN_INPUT_PULLUP)},	/* mmc1_dat1.mmc1_dat1 */
@@ -221,7 +221,7 @@  const struct pad_conf_entry core_padconf_array_essential_x15[] = {
 	{MMC1_SDCD, (M14 | PIN_INPUT_PULLUP)},	/* mmc1_sdcd.gpio6_27 */
 	{GPIO6_10, (M10 | PIN_OUTPUT_PULLDOWN)},	/* gpio6_10.ehrpwm2A */
 	{GPIO6_11, (M0 | PIN_INPUT_PULLUP)},	/* gpio6_11.gpio6_11 */
-	{MMC3_CLK, (M0 | PIN_OUTPUT_PULLUP | MANUAL_MODE)},	/* mmc3_clk.mmc3_clk */
+	{MMC3_CLK, (M0 | PIN_INPUT_PULLUP | MANUAL_MODE)},	/* mmc3_clk.mmc3_clk */
 	{MMC3_CMD, (M0 | PIN_INPUT_PULLUP | MANUAL_MODE)},	/* mmc3_cmd.mmc3_cmd */
 	{MMC3_DAT0, (M0 | PIN_INPUT_PULLUP | MANUAL_MODE)},	/* mmc3_dat0.mmc3_dat0 */
 	{MMC3_DAT1, (M0 | PIN_INPUT_PULLUP | MANUAL_MODE)},	/* mmc3_dat1.mmc3_dat1 */