diff mbox

mmc: sdhci-cadence: fix bit shift of read data from PHY port

Message ID 1487070340-8988-1-git-send-email-yamada.masahiro@socionext.com
State Accepted
Commit 4e03f628b464e0580abadf5161eaa38c61d20943
Headers show

Commit Message

Masahiro Yamada Feb. 14, 2017, 11:05 a.m. UTC
This macro is currently unused, but it may be useful for debug use.
Fix it just in case.

Fixes: ff6af28faff5 ("mmc: sdhci-cadence: add Cadence SD4HC support")
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

---

 drivers/mmc/host/sdhci-cadence.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.7.4

Comments

Adrian Hunter Feb. 14, 2017, 11:28 a.m. UTC | #1
On 14/02/17 13:05, Masahiro Yamada wrote:
> This macro is currently unused, but it may be useful for debug use.

> Fix it just in case.

> 

> Fixes: ff6af28faff5 ("mmc: sdhci-cadence: add Cadence SD4HC support")

> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>


Acked-by: Adrian Hunter <adrian.hunter@intel.com>


> ---

> 

>  drivers/mmc/host/sdhci-cadence.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/mmc/host/sdhci-cadence.c b/drivers/mmc/host/sdhci-cadence.c

> index 4b0ecb9..5ffa2e5 100644

> --- a/drivers/mmc/host/sdhci-cadence.c

> +++ b/drivers/mmc/host/sdhci-cadence.c

> @@ -25,7 +25,7 @@

>  #define   SDHCI_CDNS_HRS04_ACK			BIT(26)

>  #define   SDHCI_CDNS_HRS04_RD			BIT(25)

>  #define   SDHCI_CDNS_HRS04_WR			BIT(24)

> -#define   SDHCI_CDNS_HRS04_RDATA_SHIFT		12

> +#define   SDHCI_CDNS_HRS04_RDATA_SHIFT		16

>  #define   SDHCI_CDNS_HRS04_WDATA_SHIFT		8

>  #define   SDHCI_CDNS_HRS04_ADDR_SHIFT		0

>  

>
Ulf Hansson Feb. 15, 2017, 10:42 a.m. UTC | #2
On 14 February 2017 at 12:05, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> This macro is currently unused, but it may be useful for debug use.

> Fix it just in case.

>

> Fixes: ff6af28faff5 ("mmc: sdhci-cadence: add Cadence SD4HC support")

> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

> ---

>

>  drivers/mmc/host/sdhci-cadence.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/drivers/mmc/host/sdhci-cadence.c b/drivers/mmc/host/sdhci-cadence.c

> index 4b0ecb9..5ffa2e5 100644

> --- a/drivers/mmc/host/sdhci-cadence.c

> +++ b/drivers/mmc/host/sdhci-cadence.c

> @@ -25,7 +25,7 @@

>  #define   SDHCI_CDNS_HRS04_ACK                 BIT(26)

>  #define   SDHCI_CDNS_HRS04_RD                  BIT(25)

>  #define   SDHCI_CDNS_HRS04_WR                  BIT(24)

> -#define   SDHCI_CDNS_HRS04_RDATA_SHIFT         12

> +#define   SDHCI_CDNS_HRS04_RDATA_SHIFT         16

>  #define   SDHCI_CDNS_HRS04_WDATA_SHIFT         8

>  #define   SDHCI_CDNS_HRS04_ADDR_SHIFT          0

>

> --

> 2.7.4

>


Thanks, applied for next!

Kind regards
Uffe
diff mbox

Patch

diff --git a/drivers/mmc/host/sdhci-cadence.c b/drivers/mmc/host/sdhci-cadence.c
index 4b0ecb9..5ffa2e5 100644
--- a/drivers/mmc/host/sdhci-cadence.c
+++ b/drivers/mmc/host/sdhci-cadence.c
@@ -25,7 +25,7 @@ 
 #define   SDHCI_CDNS_HRS04_ACK			BIT(26)
 #define   SDHCI_CDNS_HRS04_RD			BIT(25)
 #define   SDHCI_CDNS_HRS04_WR			BIT(24)
-#define   SDHCI_CDNS_HRS04_RDATA_SHIFT		12
+#define   SDHCI_CDNS_HRS04_RDATA_SHIFT		16
 #define   SDHCI_CDNS_HRS04_WDATA_SHIFT		8
 #define   SDHCI_CDNS_HRS04_ADDR_SHIFT		0