| Message ID | 20170221210923.17442-1-maxim.uvarov@linaro.org |
|---|---|
| State | Accepted |
| Commit | 63a39fabe4924d142d2df041d817f732eb4fdafb |
| Headers | show |
On Tue, Feb 21, 2017 at 3:09 PM, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > On main page for each commit Codecov does tests. This > patch lowers expectations for 'codecov/project' to make > it pass and as the result combined mark check (travis + codecov) > green under commit on main page. > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> > --- > .codecov.yml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/.codecov.yml b/.codecov.yml > index 86bcd1dc..36270d61 100644 > --- a/.codecov.yml > +++ b/.codecov.yml > @@ -7,7 +7,9 @@ coverage: > round: down > range: "50...75" > status: > - project: yes > + project: > + target: 70% > + threshold: 5% > Are we doing this just to make the charts pretty? Or is this consistent with what other projects are doing? > patch: yes > changes: yes > > -- > 2.11.0.295.gd7dffce > >
On 22 February 2017 at 00:32, Bill Fischofer <bill.fischofer@linaro.org> wrote: > > On Tue, Feb 21, 2017 at 3:09 PM, Maxim Uvarov <maxim.uvarov@linaro.org> > wrote: > >> On main page for each commit Codecov does tests. This >> patch lowers expectations for 'codecov/project' to make >> it pass and as the result combined mark check (travis + codecov) >> green under commit on main page. >> >> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> >> --- >> .codecov.yml | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/.codecov.yml b/.codecov.yml >> index 86bcd1dc..36270d61 100644 >> --- a/.codecov.yml >> +++ b/.codecov.yml >> @@ -7,7 +7,9 @@ coverage: >> round: down >> range: "50...75" >> status: >> - project: yes >> + project: >> + target: 70% >> + threshold: 5% >> > > Are we doing this just to make the charts pretty? Or is this consistent > with what other projects are doing? > > Yes, that is only to make charts pretty. Codecov is 3-rd party integration service which is linked with github. On merge commit it tests patch and project for code coverage and provides link. Threshold value says that 5% is acceptable degradation change for single patch. Default value is not set and it fails even for 0.001%. But because test execution and travis are linked to single block in web single test fail make hole block fail. So I want to make it's pretty and pass for now. Then get some stats and if will be needed then adjust numbers for charts. Maxim. > patch: yes >> changes: yes >> >> -- >> 2.11.0.295.gd7dffce >> >> >
Ok, thanks. I agree. We can adjust after we complete the move to GitHub. Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org> On Wed, Feb 22, 2017 at 2:02 AM, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > > > On 22 February 2017 at 00:32, Bill Fischofer <bill.fischofer@linaro.org> > wrote: > >> >> On Tue, Feb 21, 2017 at 3:09 PM, Maxim Uvarov <maxim.uvarov@linaro.org> >> wrote: >> >>> On main page for each commit Codecov does tests. This >>> patch lowers expectations for 'codecov/project' to make >>> it pass and as the result combined mark check (travis + codecov) >>> green under commit on main page. >>> >>> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> >>> --- >>> .codecov.yml | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/.codecov.yml b/.codecov.yml >>> index 86bcd1dc..36270d61 100644 >>> --- a/.codecov.yml >>> +++ b/.codecov.yml >>> @@ -7,7 +7,9 @@ coverage: >>> round: down >>> range: "50...75" >>> status: >>> - project: yes >>> + project: >>> + target: 70% >>> + threshold: 5% >>> >> >> Are we doing this just to make the charts pretty? Or is this consistent >> with what other projects are doing? >> >> > > Yes, that is only to make charts pretty. > Codecov is 3-rd party integration service which is linked with github. On > merge commit it tests patch and project for code coverage and provides > link. Threshold value says that 5% is acceptable degradation change for > single patch. Default value is not set and it fails even for 0.001%. But > because test execution and travis are linked to single block in web single > test fail make hole block fail. So I want to make it's pretty and pass for > now. Then get some stats and if will be needed then adjust numbers for > charts. > > Maxim. > > >> patch: yes >>> changes: yes >>> >>> -- >>> 2.11.0.295.gd7dffce >>> >>> >> >
diff --git a/.codecov.yml b/.codecov.yml index 86bcd1dc..36270d61 100644 --- a/.codecov.yml +++ b/.codecov.yml @@ -7,7 +7,9 @@ coverage: round: down range: "50...75" status: - project: yes + project: + target: 70% + threshold: 5% patch: yes changes: yes
On main page for each commit Codecov does tests. This patch lowers expectations for 'codecov/project' to make it pass and as the result combined mark check (travis + codecov) green under commit on main page. Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> --- .codecov.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.11.0.295.gd7dffce