[4/4] api: crypto: add definitions for SHA-1 HMAC authentication

Message ID 20170221224127.31314-4-dmitry.ereminsolenikov@linaro.org
State New
Headers show
Series
  • [1/4] example: ipsec_offload: enable compilation
Related show

Commit Message

Dmitry Eremin-Solenikov Feb. 21, 2017, 10:41 p.m.
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

---
 include/odp/api/spec/crypto.h | 9 +++++++++
 1 file changed, 9 insertions(+)

-- 
2.11.0

Comments

Bill Fischofer Feb. 21, 2017, 11:46 p.m. | #1
API change needs Petri's review.

On Tue, Feb 21, 2017 at 4:41 PM, Dmitry Eremin-Solenikov <
dmitry.ereminsolenikov@linaro.org> wrote:

> Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

> ---

>  include/odp/api/spec/crypto.h | 9 +++++++++

>  1 file changed, 9 insertions(+)

>

> diff --git a/include/odp/api/spec/crypto.h b/include/odp/api/spec/crypto.h

> index 9855bf98..cdff8e94 100644

> --- a/include/odp/api/spec/crypto.h

> +++ b/include/odp/api/spec/crypto.h

> @@ -102,6 +102,12 @@ typedef enum {

>          */

>         ODP_AUTH_ALG_MD5_HMAC,

>

> +       /** HMAC-SHA-1

> +        *

> +        *  SHA-1 algorithm in HMAC mode

> +        */

> +       ODP_AUTH_ALG_SHA1_HMAC,

> +

>         /** HMAC-SHA-256

>          *

>          *  SHA-256 algorithm in HMAC mode

> @@ -117,6 +123,9 @@ typedef enum {

>         /** @deprecated  Use ODP_AUTH_ALG_MD5_HMAC instead */

>         ODP_AUTH_ALG_MD5_96,

>

> +       /** @deprecated  Use ODP_AUTH_ALG_SHA1_HMAC instead */

> +       ODP_AUTH_ALG_SHA1_96,

> +

>         /** @deprecated  Use ODP_AUTH_ALG_SHA256_HMAC instead */

>         ODP_AUTH_ALG_SHA256_128,

>

> --

> 2.11.0

>

>
Maxim Uvarov Feb. 22, 2017, 8:04 a.m. | #2
patch prefix has to be API-NEXT also.

Maxim.

On 22 February 2017 at 02:46, Bill Fischofer <bill.fischofer@linaro.org>
wrote:

> API change needs Petri's review.

>

> On Tue, Feb 21, 2017 at 4:41 PM, Dmitry Eremin-Solenikov <

> dmitry.ereminsolenikov@linaro.org> wrote:

>

> > Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@

> linaro.org>

> > ---

> >  include/odp/api/spec/crypto.h | 9 +++++++++

> >  1 file changed, 9 insertions(+)

> >

> > diff --git a/include/odp/api/spec/crypto.h

> b/include/odp/api/spec/crypto.h

> > index 9855bf98..cdff8e94 100644

> > --- a/include/odp/api/spec/crypto.h

> > +++ b/include/odp/api/spec/crypto.h

> > @@ -102,6 +102,12 @@ typedef enum {

> >          */

> >         ODP_AUTH_ALG_MD5_HMAC,

> >

> > +       /** HMAC-SHA-1

> > +        *

> > +        *  SHA-1 algorithm in HMAC mode

> > +        */

> > +       ODP_AUTH_ALG_SHA1_HMAC,

> > +

> >         /** HMAC-SHA-256

> >          *

> >          *  SHA-256 algorithm in HMAC mode

> > @@ -117,6 +123,9 @@ typedef enum {

> >         /** @deprecated  Use ODP_AUTH_ALG_MD5_HMAC instead */

> >         ODP_AUTH_ALG_MD5_96,

> >

> > +       /** @deprecated  Use ODP_AUTH_ALG_SHA1_HMAC instead */

> > +       ODP_AUTH_ALG_SHA1_96,

> > +

> >         /** @deprecated  Use ODP_AUTH_ALG_SHA256_HMAC instead */

> >         ODP_AUTH_ALG_SHA256_128,

> >

> > --

> > 2.11.0

> >

> >

>
Savolainen, Petri (Nokia - FI/Espoo) Feb. 22, 2017, 11:43 a.m. | #3
From: Maxim Uvarov [mailto:maxim.uvarov@linaro.org] 

Sent: Wednesday, February 22, 2017 10:05 AM
To: Bill Fischofer <bill.fischofer@linaro.org>
Cc: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>; Petri Savolainen <petri.savolainen@linaro.org>; lng-odp-forward <lng-odp@lists.linaro.org>
Subject: Re: [lng-odp] [PATCH 4/4] api: crypto: add definitions for SHA-1 HMAC authentication

patch prefix has to be API-NEXT also.
Maxim.


I'll modify this one (add also sha-512) and send an updated version shortly. I'll include the abi patch also.

-Petri

Patch hide | download patch | download mbox

diff --git a/include/odp/api/spec/crypto.h b/include/odp/api/spec/crypto.h
index 9855bf98..cdff8e94 100644
--- a/include/odp/api/spec/crypto.h
+++ b/include/odp/api/spec/crypto.h
@@ -102,6 +102,12 @@  typedef enum {
 	 */
 	ODP_AUTH_ALG_MD5_HMAC,
 
+	/** HMAC-SHA-1
+	 *
+	 *  SHA-1 algorithm in HMAC mode
+	 */
+	ODP_AUTH_ALG_SHA1_HMAC,
+
 	/** HMAC-SHA-256
 	 *
 	 *  SHA-256 algorithm in HMAC mode
@@ -117,6 +123,9 @@  typedef enum {
 	/** @deprecated  Use ODP_AUTH_ALG_MD5_HMAC instead */
 	ODP_AUTH_ALG_MD5_96,
 
+	/** @deprecated  Use ODP_AUTH_ALG_SHA1_HMAC instead */
+	ODP_AUTH_ALG_SHA1_96,
+
 	/** @deprecated  Use ODP_AUTH_ALG_SHA256_HMAC instead */
 	ODP_AUTH_ALG_SHA256_128,