From patchwork Wed Mar 1 16:02:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Purdie X-Patchwork-Id: 94717 Delivered-To: patch@linaro.org Received: by 10.140.20.113 with SMTP id 104csp1865860qgi; Wed, 1 Mar 2017 08:04:15 -0800 (PST) X-Received: by 10.84.225.150 with SMTP id u22mr11116545plj.91.1488384254951; Wed, 01 Mar 2017 08:04:14 -0800 (PST) Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id a1si4932815pgf.369.2017.03.01.08.04.14; Wed, 01 Mar 2017 08:04:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org Received: from review.yoctoproject.org (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id 37DD5775A5; Wed, 1 Mar 2017 16:03:07 +0000 (UTC) X-Original-To: openembedded-core@lists.openembedded.org Delivered-To: openembedded-core@lists.openembedded.org Received: from dan.rpsys.net (5751f4a1.skybroadband.com [87.81.244.161]) by mail.openembedded.org (Postfix) with ESMTP id 3202877562 for ; Wed, 1 Mar 2017 16:02:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id v21G2poA011997; Wed, 1 Mar 2017 16:02:51 GMT Received: from dan.rpsys.net ([127.0.0.1]) by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id LWFEQvhqttJQ; Wed, 1 Mar 2017 16:02:51 +0000 (GMT) Received: from hex ([192.168.3.34]) (authenticated bits=0) by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id v21G2kYO011983 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 1 Mar 2017 16:02:47 GMT Received: from richard by hex with local (Exim 4.86_2) (envelope-from ) id 1cj6iE-0004oU-Ry; Wed, 01 Mar 2017 16:02:46 +0000 From: Richard Purdie To: openembedded-core@lists.openembedded.org Date: Wed, 1 Mar 2017 16:02:42 +0000 Message-Id: <1488384162-18397-12-git-send-email-richard.purdie@linuxfoundation.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1488384162-18397-1-git-send-email-richard.purdie@linuxfoundation.org> References: <1488384162-18397-1-git-send-email-richard.purdie@linuxfoundation.org> Subject: [OE-core] [PATCH 12/12] oeqa/sdkext: don't skip tests if there isn't a toolchain X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: openembedded-core-bounces@lists.openembedded.org Errors-To: openembedded-core-bounces@lists.openembedded.org From: Ross Burton Skipping the tests if a toolchain wasn't installed out of the box (for example, a minimal eSDK) doesn't make sense as the first thing the tests should do is install a toolchain. Signed-off-by: Ross Burton Signed-off-by: Richard Purdie --- meta/lib/oeqa/sdkext/cases/devtool.py | 7 ------- 1 file changed, 7 deletions(-) -- 2.7.4 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core diff --git a/meta/lib/oeqa/sdkext/cases/devtool.py b/meta/lib/oeqa/sdkext/cases/devtool.py index 63431aa..1072fb6 100644 --- a/meta/lib/oeqa/sdkext/cases/devtool.py +++ b/meta/lib/oeqa/sdkext/cases/devtool.py @@ -7,7 +7,6 @@ import subprocess from oeqa.sdkext.case import OESDKExtTestCase from oeqa.core.decorator.depends import OETestDepends from oeqa.core.decorator.oeid import OETestID -from oeqa.core.decorator.data import skipIfNotDataVar class DevtoolTest(OESDKExtTestCase): @classmethod @@ -51,25 +50,21 @@ class DevtoolTest(OESDKExtTestCase): @OETestID(1605) @OETestDepends(['test_devtool_location']) - @skipIfNotDataVar('SDK_INCLUDE_TOOLCHAIN', '1', 'SDK does not include toolchain') def test_devtool_build_make(self): self._test_devtool_build(self.myapp_dst) @OETestID(1606) @OETestDepends(['test_devtool_location']) - @skipIfNotDataVar('SDK_INCLUDE_TOOLCHAIN', '1', 'SDK does not include toolchain') def test_devtool_build_esdk_package(self): self._test_devtool_build_package(self.myapp_dst) @OETestID(1607) @OETestDepends(['test_devtool_location']) - @skipIfNotDataVar('SDK_INCLUDE_TOOLCHAIN', '1', 'SDK does not include toolchain') def test_devtool_build_cmake(self): self._test_devtool_build(self.myapp_cmake_dst) @OETestID(1608) @OETestDepends(['test_devtool_location']) - @skipIfNotDataVar('SDK_INCLUDE_TOOLCHAIN', '1', 'SDK does not include toolchain') def test_extend_autotools_recipe_creation(self): req = 'https://github.com/rdfa/librdfa' recipe = "librdfa" @@ -81,7 +76,6 @@ class DevtoolTest(OESDKExtTestCase): @OETestID(1609) @OETestDepends(['test_devtool_location']) - @skipIfNotDataVar('SDK_INCLUDE_TOOLCHAIN', '1', 'SDK does not include toolchain') def test_devtool_kernelmodule(self): docfile = 'https://github.com/umlaeute/v4l2loopback.git' recipe = 'v4l2loopback-driver' @@ -93,7 +87,6 @@ class DevtoolTest(OESDKExtTestCase): @OETestID(1610) @OETestDepends(['test_devtool_location']) - @skipIfNotDataVar('SDK_INCLUDE_TOOLCHAIN', '1', 'SDK does not include toolchain') def test_recipes_for_nodejs(self): package_nodejs = "npm://registry.npmjs.org;name=winston;version=2.2.0" self._run('devtool add %s ' % package_nodejs)