diff mbox

[edk2] ArmVirtPkg: apply PE/COFF memory protection to DxeCore as well

Message ID 1488885897-10345-1-git-send-email-ard.biesheuvel@linaro.org
State Accepted
Commit cc8de57bce3e79cac172568769af15d32b0e6b17
Headers show

Commit Message

Ard Biesheuvel March 7, 2017, 11:24 a.m. UTC
Include DXE_CORE in the BuildOptions that are set to force 4 KB section
alignment for PE/COFF images in order to allow them to be mapped with
strict memory permissions.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 ArmVirtPkg/ArmVirt.dsc.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.7.4

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Laszlo Ersek March 7, 2017, 1:56 p.m. UTC | #1
On 03/07/17 12:24, Ard Biesheuvel wrote:
> Include DXE_CORE in the BuildOptions that are set to force 4 KB section

> alignment for PE/COFF images in order to allow them to be mapped with

> strict memory permissions.

> 

> Contributed-under: TianoCore Contribution Agreement 1.0

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---

>  ArmVirtPkg/ArmVirt.dsc.inc | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc

> index e2d3dcce7945..f61fd0680612 100644

> --- a/ArmVirtPkg/ArmVirt.dsc.inc

> +++ b/ArmVirtPkg/ArmVirt.dsc.inc

> @@ -17,7 +17,7 @@ [Defines]

>    DEFINE DEBUG_PRINT_ERROR_LEVEL = 0x8000004F

>    DEFINE TTY_TERMINAL            = FALSE

>  

> -[BuildOptions.common.EDKII.DXE_DRIVER,BuildOptions.common.EDKII.UEFI_DRIVER,BuildOptions.common.EDKII.UEFI_APPLICATION]

> +[BuildOptions.common.EDKII.DXE_CORE,BuildOptions.common.EDKII.DXE_DRIVER,BuildOptions.common.EDKII.UEFI_DRIVER,BuildOptions.common.EDKII.UEFI_APPLICATION]

>    GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000

>  

>  [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER]

> 


Reviewed-by: Laszlo Ersek <lersek@redhat.com>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ard Biesheuvel March 8, 2017, 9:43 a.m. UTC | #2
On 7 March 2017 at 14:56, Laszlo Ersek <lersek@redhat.com> wrote:
> On 03/07/17 12:24, Ard Biesheuvel wrote:

>> Include DXE_CORE in the BuildOptions that are set to force 4 KB section

>> alignment for PE/COFF images in order to allow them to be mapped with

>> strict memory permissions.

>>

>> Contributed-under: TianoCore Contribution Agreement 1.0

>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

>> ---

>>  ArmVirtPkg/ArmVirt.dsc.inc | 2 +-

>>  1 file changed, 1 insertion(+), 1 deletion(-)

>>

>> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc

>> index e2d3dcce7945..f61fd0680612 100644

>> --- a/ArmVirtPkg/ArmVirt.dsc.inc

>> +++ b/ArmVirtPkg/ArmVirt.dsc.inc

>> @@ -17,7 +17,7 @@ [Defines]

>>    DEFINE DEBUG_PRINT_ERROR_LEVEL = 0x8000004F

>>    DEFINE TTY_TERMINAL            = FALSE

>>

>> -[BuildOptions.common.EDKII.DXE_DRIVER,BuildOptions.common.EDKII.UEFI_DRIVER,BuildOptions.common.EDKII.UEFI_APPLICATION]

>> +[BuildOptions.common.EDKII.DXE_CORE,BuildOptions.common.EDKII.DXE_DRIVER,BuildOptions.common.EDKII.UEFI_DRIVER,BuildOptions.common.EDKII.UEFI_APPLICATION]

>>    GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000

>>

>>  [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER]

>>

>

> Reviewed-by: Laszlo Ersek <lersek@redhat.com>


Thanks, pushed.
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
diff mbox

Patch

diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
index e2d3dcce7945..f61fd0680612 100644
--- a/ArmVirtPkg/ArmVirt.dsc.inc
+++ b/ArmVirtPkg/ArmVirt.dsc.inc
@@ -17,7 +17,7 @@  [Defines]
   DEFINE DEBUG_PRINT_ERROR_LEVEL = 0x8000004F
   DEFINE TTY_TERMINAL            = FALSE
 
-[BuildOptions.common.EDKII.DXE_DRIVER,BuildOptions.common.EDKII.UEFI_DRIVER,BuildOptions.common.EDKII.UEFI_APPLICATION]
+[BuildOptions.common.EDKII.DXE_CORE,BuildOptions.common.EDKII.DXE_DRIVER,BuildOptions.common.EDKII.UEFI_DRIVER,BuildOptions.common.EDKII.UEFI_APPLICATION]
   GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
 
 [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER]