From patchwork Tue Mar 14 15:23:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 95314 Delivered-To: patch@linaro.org Received: by 10.140.89.134 with SMTP id v6csp79457qgd; Tue, 14 Mar 2017 16:24:36 -0700 (PDT) X-Received: by 10.84.205.70 with SMTP id o6mr321841plh.176.1489533876586; Tue, 14 Mar 2017 16:24:36 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x63si114906pgb.253.2017.03.14.16.24.36; Tue, 14 Mar 2017 16:24:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751267AbdCNXYf (ORCPT + 4 others); Tue, 14 Mar 2017 19:24:35 -0400 Received: from mail-pf0-f176.google.com ([209.85.192.176]:33353 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750965AbdCNXYe (ORCPT ); Tue, 14 Mar 2017 19:24:34 -0400 Received: by mail-pf0-f176.google.com with SMTP id w189so547885pfb.0 for ; Tue, 14 Mar 2017 16:24:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=766HhcwZj59pildxt9lVP6B19ZTR6xZ/IKEqC+f5GCI=; b=S971+lE5ONCUEmNgnfc2Ye8FxNIk7yYKZfILVlWmv+34c5OVZQiEnreZZMDpRKzeHl b1SfZxHN7xSQscEmxz7wv8RVVz/GkWjACnY1xhQHbdnzPJkK8U41nf8old/DnOD6c17S bdp0ofgy5FaExc12pPjt5LVFLkQ8gbPpKfkQ0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=766HhcwZj59pildxt9lVP6B19ZTR6xZ/IKEqC+f5GCI=; b=oBLdmlEklgfK2+lXwKAu3/YnLK5w6DdnLG8ESH94XQJzXCL7lo1Rdyo3jD6pjwngu4 5N9ta4nydqkpDX5H31+QD90L8ZSjv34vXYf7Z5zjcP7oUZDOXULKgxkqp7X45ds0cLC8 xLIjKZX6CJ7ukqJAE0iNrNOlKIUOt6I43ePI6GIVobIJXStkpLWB/fGmbdOQTEHx35KY dYT/Pqf11sIijWYg7O6NUKwy/OHzhRguZUFPTUREVaZR+FX21yHqkqtztpMcVHfjrM78 g6oCPj0raT5bWwg9H+PBLcHKdiNrMPPKnpzI/5l9WxbJhrFJL21m3/sgVqpNb0BJw/eA sk0g== X-Gm-Message-State: AFeK/H2vZ1V+nWmvKZsVoUM7MBk2z7oeYby9zzlT+2fpEoUy/qyNgH7hwdmUVP6jGcaeJKDK X-Received: by 10.98.137.75 with SMTP id v72mr230029pfd.190.1489533873301; Tue, 14 Mar 2017 16:24:33 -0700 (PDT) Received: from localhost.localdomain (ip68-111-223-48.sd.sd.cox.net. [68.111.223.48]) by smtp.gmail.com with ESMTPSA id b77sm118386pfl.2.2017.03.14.16.24.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Mar 2017 16:24:32 -0700 (PDT) From: Bjorn Andersson To: Linus Walleij Cc: linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Timur Tabi , stable@vger.kernel.org, Stephen Boyd Subject: [PATCH] pinctrl: qcom: Don't clear status bit on irq_unmask Date: Tue, 14 Mar 2017 08:23:26 -0700 Message-Id: <20170314152326.9424-1-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.12.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Clearing the status bit on irq_unmask will discard any pending interrupt that did arrive after the irq_ack, i.e. while the IRQ handler function was executing. Fixes: f365be092572 ("pinctrl: Add Qualcomm TLMM driver") Cc: stable@vger.kernel.org Cc: Stephen Boyd Reported-by: Timur Tabi Signed-off-by: Bjorn Andersson --- drivers/pinctrl/qcom/pinctrl-msm.c | 4 ---- 1 file changed, 4 deletions(-) -- 2.12.0 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c index f8e9e1c2b2f6..faf038978650 100644 --- a/drivers/pinctrl/qcom/pinctrl-msm.c +++ b/drivers/pinctrl/qcom/pinctrl-msm.c @@ -594,10 +594,6 @@ static void msm_gpio_irq_unmask(struct irq_data *d) raw_spin_lock_irqsave(&pctrl->lock, flags); - val = readl(pctrl->regs + g->intr_status_reg); - val &= ~BIT(g->intr_status_bit); - writel(val, pctrl->regs + g->intr_status_reg); - val = readl(pctrl->regs + g->intr_cfg_reg); val |= BIT(g->intr_enable_bit); writel(val, pctrl->regs + g->intr_cfg_reg);