diff mbox series

[Linaro-uefi,Linaro-uefi,v1,05/21] Hisilicon D02/D03/D05: update uefi version to rock1.6

Message ID 1490015485-53685-6-git-send-email-chenhui.sun@linaro.org
State New
Headers show
Series D02/D03 platforms bug fix | expand

Commit Message

Chenhui Sun March 20, 2017, 1:11 p.m. UTC 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chenhui Sun <sunchenhui@huawei.com>
Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
Signed-off-by: Yi Li <phoenix.liyi@huawei.com>
---
 Platforms/Hisilicon/D02/Pv660D02.dsc | 2 +-
 Platforms/Hisilicon/D03/D03.dsc      | 2 +-
 Platforms/Hisilicon/D05/D05.dsc      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Comments

Leif Lindholm March 21, 2017, 2:34 p.m. UTC | #1 
We discussed this back in December, for the previous iteration:
https://lists.linaro.org/pipermail/linaro-uefi/2016-December/003730.html

The suggestion then was to move over to using the FIRMWARE_VER
mechanism, and Heyi said he was going to look into this after the
release. This does not appear to have happened.

Will you have time to revisit this less confusing option while I am
away on holiday?

Regards,

Leif

On Mon, Mar 20, 2017 at 09:11:09PM +0800, Chenhui Sun wrote:
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Chenhui Sun <sunchenhui@huawei.com>
> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
> Signed-off-by: Yi Li <phoenix.liyi@huawei.com>
> ---
>  Platforms/Hisilicon/D02/Pv660D02.dsc | 2 +-
>  Platforms/Hisilicon/D03/D03.dsc      | 2 +-
>  Platforms/Hisilicon/D05/D05.dsc      | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Platforms/Hisilicon/D02/Pv660D02.dsc b/Platforms/Hisilicon/D02/Pv660D02.dsc
> index b611579..3f2ea31 100644
> --- a/Platforms/Hisilicon/D02/Pv660D02.dsc
> +++ b/Platforms/Hisilicon/D02/Pv660D02.dsc
> @@ -145,7 +145,7 @@
>    gHisiTokenSpaceGuid.PcdPcieSmmuBaseAddress|0xb0040000
>    gHisiTokenSpaceGuid.PcdDsaSmmuBaseAddress|0xc0040000
>    gHisiTokenSpaceGuid.PcdAlgSmmuBaseAddress|0xd0040000
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D02 UEFI 16.08 RC1"
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D02 UEFI ROCK1.6"
>  
>    gHisiTokenSpaceGuid.PcdSystemProductName|L"D02"
>    gHisiTokenSpaceGuid.PcdSystemVersion|L"Estuary"
> diff --git a/Platforms/Hisilicon/D03/D03.dsc b/Platforms/Hisilicon/D03/D03.dsc
> index 9c73494..b44a5a3 100644
> --- a/Platforms/Hisilicon/D03/D03.dsc
> +++ b/Platforms/Hisilicon/D03/D03.dsc
> @@ -170,7 +170,7 @@
>    gHisiTokenSpaceGuid.PcdAlgSmmuBaseAddress|0xd0040000
>  
>  
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D03 UEFI 16.12 Release"
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D03 UEFI ROCK1.6"
>  
>    gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18"
>  
> diff --git a/Platforms/Hisilicon/D05/D05.dsc b/Platforms/Hisilicon/D05/D05.dsc
> index 2877da0..b17903c 100644
> --- a/Platforms/Hisilicon/D05/D05.dsc
> +++ b/Platforms/Hisilicon/D05/D05.dsc
> @@ -188,7 +188,7 @@
>  
>    gHisiTokenSpaceGuid.PcdIsMPBoot|1
>    gHisiTokenSpaceGuid.PcdSocketMask|0x3
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D05 UEFI 16.12 Release"
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D05 UEFI ROCK1.6"
>  
>    gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18"
>  
> -- 
> 1.9.1
>
gary guo March 23, 2017, 1:26 a.m. UTC | #2 
Hi Leif,

I'm sorry I forgot to look into this...

Regards,

Heyi


在 3/21/2017 10:34 PM, Leif Lindholm 写道:
> We discussed this back in December, for the previous iteration:
> https://lists.linaro.org/pipermail/linaro-uefi/2016-December/003730.html
>
> The suggestion then was to move over to using the FIRMWARE_VER
> mechanism, and Heyi said he was going to look into this after the
> release. This does not appear to have happened.
>
> Will you have time to revisit this less confusing option while I am
> away on holiday?
>
> Regards,
>
> Leif
>
> On Mon, Mar 20, 2017 at 09:11:09PM +0800, Chenhui Sun wrote:
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Chenhui Sun <sunchenhui@huawei.com>
>> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
>> Signed-off-by: Yi Li <phoenix.liyi@huawei.com>
>> ---
>>   Platforms/Hisilicon/D02/Pv660D02.dsc | 2 +-
>>   Platforms/Hisilicon/D03/D03.dsc      | 2 +-
>>   Platforms/Hisilicon/D05/D05.dsc      | 2 +-
>>   3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/Platforms/Hisilicon/D02/Pv660D02.dsc b/Platforms/Hisilicon/D02/Pv660D02.dsc
>> index b611579..3f2ea31 100644
>> --- a/Platforms/Hisilicon/D02/Pv660D02.dsc
>> +++ b/Platforms/Hisilicon/D02/Pv660D02.dsc
>> @@ -145,7 +145,7 @@
>>     gHisiTokenSpaceGuid.PcdPcieSmmuBaseAddress|0xb0040000
>>     gHisiTokenSpaceGuid.PcdDsaSmmuBaseAddress|0xc0040000
>>     gHisiTokenSpaceGuid.PcdAlgSmmuBaseAddress|0xd0040000
>> -  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D02 UEFI 16.08 RC1"
>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D02 UEFI ROCK1.6"
>>   
>>     gHisiTokenSpaceGuid.PcdSystemProductName|L"D02"
>>     gHisiTokenSpaceGuid.PcdSystemVersion|L"Estuary"
>> diff --git a/Platforms/Hisilicon/D03/D03.dsc b/Platforms/Hisilicon/D03/D03.dsc
>> index 9c73494..b44a5a3 100644
>> --- a/Platforms/Hisilicon/D03/D03.dsc
>> +++ b/Platforms/Hisilicon/D03/D03.dsc
>> @@ -170,7 +170,7 @@
>>     gHisiTokenSpaceGuid.PcdAlgSmmuBaseAddress|0xd0040000
>>   
>>   
>> -  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D03 UEFI 16.12 Release"
>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D03 UEFI ROCK1.6"
>>   
>>     gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18"
>>   
>> diff --git a/Platforms/Hisilicon/D05/D05.dsc b/Platforms/Hisilicon/D05/D05.dsc
>> index 2877da0..b17903c 100644
>> --- a/Platforms/Hisilicon/D05/D05.dsc
>> +++ b/Platforms/Hisilicon/D05/D05.dsc
>> @@ -188,7 +188,7 @@
>>   
>>     gHisiTokenSpaceGuid.PcdIsMPBoot|1
>>     gHisiTokenSpaceGuid.PcdSocketMask|0x3
>> -  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D05 UEFI 16.12 Release"
>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D05 UEFI ROCK1.6"
>>   
>>     gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18"
>>   
>> -- 
>> 1.9.1
>>
Chenhui Sun March 24, 2017, 7:46 a.m. UTC | #3 
Hi Leif,


在 2017/3/21 22:34, Leif Lindholm 写道:
> We discussed this back in December, for the previous iteration:
> https://lists.linaro.org/pipermail/linaro-uefi/2016-December/003730.html
>
> The suggestion then was to move over to using the FIRMWARE_VER
> mechanism, and Heyi said he was going to look into this after the
> release. This does not appear to have happened.
>
> Will you have time to revisit this less confusing option while I am
> away on holiday?
Ok, I will look at FIRMWARE_VER mechanism,
maybe I will drop this path first.

Regards,
Chenhui
> Regards,
>
> Leif
>
> On Mon, Mar 20, 2017 at 09:11:09PM +0800, Chenhui Sun wrote:
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Chenhui Sun <sunchenhui@huawei.com>
>> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
>> Signed-off-by: Yi Li <phoenix.liyi@huawei.com>
>> ---
>>   Platforms/Hisilicon/D02/Pv660D02.dsc | 2 +-
>>   Platforms/Hisilicon/D03/D03.dsc      | 2 +-
>>   Platforms/Hisilicon/D05/D05.dsc      | 2 +-
>>   3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/Platforms/Hisilicon/D02/Pv660D02.dsc b/Platforms/Hisilicon/D02/Pv660D02.dsc
>> index b611579..3f2ea31 100644
>> --- a/Platforms/Hisilicon/D02/Pv660D02.dsc
>> +++ b/Platforms/Hisilicon/D02/Pv660D02.dsc
>> @@ -145,7 +145,7 @@
>>     gHisiTokenSpaceGuid.PcdPcieSmmuBaseAddress|0xb0040000
>>     gHisiTokenSpaceGuid.PcdDsaSmmuBaseAddress|0xc0040000
>>     gHisiTokenSpaceGuid.PcdAlgSmmuBaseAddress|0xd0040000
>> -  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D02 UEFI 16.08 RC1"
>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D02 UEFI ROCK1.6"
>>   
>>     gHisiTokenSpaceGuid.PcdSystemProductName|L"D02"
>>     gHisiTokenSpaceGuid.PcdSystemVersion|L"Estuary"
>> diff --git a/Platforms/Hisilicon/D03/D03.dsc b/Platforms/Hisilicon/D03/D03.dsc
>> index 9c73494..b44a5a3 100644
>> --- a/Platforms/Hisilicon/D03/D03.dsc
>> +++ b/Platforms/Hisilicon/D03/D03.dsc
>> @@ -170,7 +170,7 @@
>>     gHisiTokenSpaceGuid.PcdAlgSmmuBaseAddress|0xd0040000
>>   
>>   
>> -  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D03 UEFI 16.12 Release"
>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D03 UEFI ROCK1.6"
>>   
>>     gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18"
>>   
>> diff --git a/Platforms/Hisilicon/D05/D05.dsc b/Platforms/Hisilicon/D05/D05.dsc
>> index 2877da0..b17903c 100644
>> --- a/Platforms/Hisilicon/D05/D05.dsc
>> +++ b/Platforms/Hisilicon/D05/D05.dsc
>> @@ -188,7 +188,7 @@
>>   
>>     gHisiTokenSpaceGuid.PcdIsMPBoot|1
>>     gHisiTokenSpaceGuid.PcdSocketMask|0x3
>> -  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D05 UEFI 16.12 Release"
>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D05 UEFI ROCK1.6"
>>   
>>     gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18"
>>   
>> -- 
>> 1.9.1
>>
diff mbox series

Patch

diff --git a/Platforms/Hisilicon/D02/Pv660D02.dsc b/Platforms/Hisilicon/D02/Pv660D02.dsc
index b611579..3f2ea31 100644
--- a/Platforms/Hisilicon/D02/Pv660D02.dsc
+++ b/Platforms/Hisilicon/D02/Pv660D02.dsc
@@ -145,7 +145,7 @@ 
   gHisiTokenSpaceGuid.PcdPcieSmmuBaseAddress|0xb0040000
   gHisiTokenSpaceGuid.PcdDsaSmmuBaseAddress|0xc0040000
   gHisiTokenSpaceGuid.PcdAlgSmmuBaseAddress|0xd0040000
-  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D02 UEFI 16.08 RC1"
+  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D02 UEFI ROCK1.6"
 
   gHisiTokenSpaceGuid.PcdSystemProductName|L"D02"
   gHisiTokenSpaceGuid.PcdSystemVersion|L"Estuary"
diff --git a/Platforms/Hisilicon/D03/D03.dsc b/Platforms/Hisilicon/D03/D03.dsc
index 9c73494..b44a5a3 100644
--- a/Platforms/Hisilicon/D03/D03.dsc
+++ b/Platforms/Hisilicon/D03/D03.dsc
@@ -170,7 +170,7 @@ 
   gHisiTokenSpaceGuid.PcdAlgSmmuBaseAddress|0xd0040000
 
 
-  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D03 UEFI 16.12 Release"
+  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D03 UEFI ROCK1.6"
 
   gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18"
 
diff --git a/Platforms/Hisilicon/D05/D05.dsc b/Platforms/Hisilicon/D05/D05.dsc
index 2877da0..b17903c 100644
--- a/Platforms/Hisilicon/D05/D05.dsc
+++ b/Platforms/Hisilicon/D05/D05.dsc
@@ -188,7 +188,7 @@ 
 
   gHisiTokenSpaceGuid.PcdIsMPBoot|1
   gHisiTokenSpaceGuid.PcdSocketMask|0x3
-  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D05 UEFI 16.12 Release"
+  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D05 UEFI ROCK1.6"
 
   gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18"