From patchwork Tue Mar 21 05:24:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 95597 Delivered-To: patch@linaro.org Received: by 10.140.89.233 with SMTP id v96csp1275046qgd; Mon, 20 Mar 2017 22:34:42 -0700 (PDT) X-Received: by 10.84.194.1 with SMTP id g1mr45080401pld.98.1490074482136; Mon, 20 Mar 2017 22:34:42 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f72si14200073pfk.341.2017.03.20.22.34.41; Mon, 20 Mar 2017 22:34:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756376AbdCUFea (ORCPT + 21 others); Tue, 21 Mar 2017 01:34:30 -0400 Received: from mail-pf0-f182.google.com ([209.85.192.182]:35233 "EHLO mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755253AbdCUFeZ (ORCPT ); Tue, 21 Mar 2017 01:34:25 -0400 Received: by mail-pf0-f182.google.com with SMTP id 20so27578842pfk.2 for ; Mon, 20 Mar 2017 22:34:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=zlnfZCgnqDzIidr016TdLFXpMUR6DXVTvjX9ouRwIU0=; b=J2YikuOnhF55jORltiiif7HFxH+0MEgYs3fNRJHZocW6AgZUloMSCWh5p97LXrSFYr RWo19H/TNixPFZqd8bu5C2HtAexs+GCufwsPTGI/cKXdwvgyRM+xPh2E5yQuvs/V2n4G oIYlcoHQe2jSgxoDiij/+gZ34/k6WArj1JQp0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zlnfZCgnqDzIidr016TdLFXpMUR6DXVTvjX9ouRwIU0=; b=lrX4atuKFDYYxXWOKlLH5s9C+UXH6yyQBLiSGQKeQACYzVAklUY7rmsBkd+3pNO8md rFQXMjk+F7lKTEy3zebmS7mBJmduJRBPhDoXlaZJSgJjVbkUpWwnupx5i+TUioyQz6fp U5pBYrDrC1gbszsS9VRXAFCMWzAZZZg7QfPLr05vCw72ZYj7Rp/v1J9ppSRCXHqgbzup QD2xlTJrdpnKQN45j6lmIFEWGWLKEpAAVlyZ+0Whd5b9j30QcL6ePa1Er68w5lKoCBS6 2ZfBkLNE36FCqdhymBXOdR0ArjLURt9fEUAFH/pOu7X4BIOvYy+CkLnJ+/X/IOeky82e OjTw== X-Gm-Message-State: AFeK/H28KdAFzurzEToAQW+locJa2/VFnYUmnL7lyfl3HQnNv+P7Q31r7LRo8b0DHJhGBws5 X-Received: by 10.84.129.67 with SMTP id 61mr45260368plb.16.1490073906680; Mon, 20 Mar 2017 22:25:06 -0700 (PDT) Received: from localhost ([122.171.239.200]) by smtp.gmail.com with ESMTPSA id z19sm20679405pfd.81.2017.03.20.22.25.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Mar 2017 22:25:05 -0700 (PDT) From: Viresh Kumar To: Stephen Warren , Thierry Reding , Alexandre Courbot Cc: linaro-kernel@lists.linaro.org, Viresh Kumar , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] soc/tegra: pmc: Don't allocate struct tegra_powergate on stack Date: Tue, 21 Mar 2017 10:54:53 +0530 Message-Id: <3fe40fcd427e49cbeac31e14721fea569d230b6e.1490073884.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.12.0.432.g71c3a4f4ba37 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The size of the struct tegra_powergate is quite big and if any more fields are added to the internal genpd structure, following warnings are thrown: drivers/soc/tegra/pmc.c:577:1: warning: the frame size of 1176 bytes is larger than 1024 bytes [-Wframe-larger-than=] Avoid such warnings by allocating the structure dynamically. Signed-off-by: Viresh Kumar --- drivers/soc/tegra/pmc.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) -- 2.12.0.432.g71c3a4f4ba37 diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c index e233dd5dcab3..c94196b939a4 100644 --- a/drivers/soc/tegra/pmc.c +++ b/drivers/soc/tegra/pmc.c @@ -557,22 +557,28 @@ EXPORT_SYMBOL(tegra_powergate_remove_clamping); int tegra_powergate_sequence_power_up(unsigned int id, struct clk *clk, struct reset_control *rst) { - struct tegra_powergate pg; + struct tegra_powergate *pg; int err; if (!tegra_powergate_is_available(id)) return -EINVAL; - pg.id = id; - pg.clks = &clk; - pg.num_clks = 1; - pg.resets = &rst; - pg.num_resets = 1; + pg = kzalloc(sizeof(*pg), GFP_KERNEL); + if (!pg) + return -ENOMEM; + + pg->id = id; + pg->clks = &clk; + pg->num_clks = 1; + pg->resets = &rst; + pg->num_resets = 1; - err = tegra_powergate_power_up(&pg, false); + err = tegra_powergate_power_up(pg, false); if (err) pr_err("failed to turn on partition %d: %d\n", id, err); + kfree(pg); + return err; } EXPORT_SYMBOL(tegra_powergate_sequence_power_up);