media: s5p-mfc: Fix unbalanced call to clock management

Message ID
State New
Headers show

Commit Message

Marek Szyprowski March 22, 2017, 7:53 a.m.
Clock should be turned off after calling s5p_mfc_init_hw() from the
watchdog worker, like it is already done in the s5p_mfc_open() which also
calls this function.

Signed-off-by: Marek Szyprowski <>

Fixes: af93574678108 ("[media] MFC: Add MFC 5.1 V4L2 driver")
CC: # v3.7+
This issue was there from the beggining of the driver, but this patch applies
cleanly only to v3.7+ kernels.
 drivers/media/platform/s5p-mfc/s5p_mfc.c | 1 +
 1 file changed, 1 insertion(+)



diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c
index 0c7ef6251252..76d4681a1c79 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c
@@ -211,6 +211,7 @@  static void s5p_mfc_watchdog_worker(struct work_struct *work)
 		ret = s5p_mfc_init_hw(dev);
+		s5p_mfc_clock_off();
 		if (ret)
 			mfc_err("Failed to reinit FW\n");