From patchwork Wed Mar 22 14:07:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 95773 Delivered-To: patch@linaro.org Received: by 10.140.89.233 with SMTP id v96csp261801qgd; Wed, 22 Mar 2017 07:19:02 -0700 (PDT) X-Received: by 10.98.18.66 with SMTP id a63mr46419130pfj.188.1490192342236; Wed, 22 Mar 2017 07:19:02 -0700 (PDT) Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [65.50.211.133]) by mx.google.com with ESMTPS id q87si1406310pfi.271.2017.03.22.07.19.02 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Mar 2017 07:19:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 65.50.211.133 as permitted sender) client-ip=65.50.211.133; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org; dkim=neutral (body hash did not verify) header.i=@infradead.org; dkim=neutral (body hash did not verify) header.i=@nifty.com; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=linux-mtd-bounces+patch=linaro.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=YpEmrrGVoM0ZQBe5Sl2+ZSd4hJerp+rHfRznQZcgwzU=; b=tEj+q5kwfPOnHwK8e4PweHV6Sa uqDlHoRIbORb66dswTngzeLhbZmouvU8f5Y+d3ljByDyh6PUgi2ydCv5srNCGgZrmw1kJKm/7EbNU b7B9B2Y4YVYV1sCqOzdboyiHgyOFktOxhUR1JH1KzaUHE7cT91qngFrn3ne5zXPCaTqnEexV/K8d/ fUyZaJ8mKG6bjOJmCkcplX2nyTmcn+Zu35X3DWEMLovsiI6/pO8xOLRpwUFp5syWooXyi+4t4/huj pUjsOfbFq4xyORSPJfLU2qUrVLstxYBFd7sHHWLlhA5mK+BP70lFRUX01eQ32Da5yhpi+46xfv14S W4Kk+2jQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cqh6H-0000lp-IM; Wed, 22 Mar 2017 14:18:57 +0000 Received: from casper.infradead.org ([2001:770:15f::2]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cqh5d-00082r-GJ for linux-mtd@bombadil.infradead.org; Wed, 22 Mar 2017 14:18:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=k0OolJzglYZESV6rxKJganwnwaMw8DLMYS5PnlGJdLg=; b=HD1nefNRhgp90CEHvqlAN9Iws ViwkINY4a5DCRxIlbkqaJd3XSv8TssYghYXJEozDToJa41rpuNFP/VbFjYIuUt+ORJYXwKkjwTK9x QB0OilAIMjsodJdDhAqyAmpaj4ZWku8K0knfTkT2L2T0zLWclr8e7stHeCEwFyRCEba/OZsIYkJD6 oA4o7/Ns9/92DFUbUquwHESVQ9X8wDVbo90f0xYp68WNUIZEZ7XFN+9YDV9v+1XKvcrwaK7zT28MJ Y6hKpWz7yiCETuRXmUsmjcptLIhyKIN8iMYWpeg4Lp8peFiHeZi7J9vOLHW49omgKOuQx2FJ0wUi5 Nuwq/qKTQ==; Received: from conuserg-07.nifty.com ([210.131.2.74]) by casper.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cqgxZ-0007sp-13 for linux-mtd@lists.infradead.org; Wed, 22 Mar 2017 14:10:01 +0000 Received: from pug.jp.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id v2ME8LDY010154; Wed, 22 Mar 2017 23:08:45 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com v2ME8LDY010154 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1490191726; bh=k0OolJzglYZESV6rxKJganwnwaMw8DLMYS5PnlGJdLg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L6s0kCGev3bs6Kv2FsueqM3W/KAyFw3PPXTtXiDhx7f3gXupvHz4ssZdhrqv5Vb5i 7RpFcSPDEJIWm81m4u8ufrN3m5ZLa73dxhmZnsxT97M4YusznjjLJwYWzsJvNlba3v qcKMYJ5X1ZNAHwsiKqNCBoK2iVSn4r49UHkbfwAn6eJbwo3hj4K64UQ0/nr254Yrof dddoaQur8Zf4E09GHtNIIrhXZSpGPxUJj/bnzxD4tyTS1dwCF9WNBohVKJBhN0G/5L Q6lueSLkqtdVyLVMUwCYV9UxCi9HExGUYgzzZgTwPV+tLWBtUmEhAGBcMS6W4DHtLA dbLb8V9s1QhvQ== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-mtd@lists.infradead.org Subject: [PATCH v2 15/53] mtd: nand: denali_dt: remove dma-mask DT property Date: Wed, 22 Mar 2017 23:07:22 +0900 Message-Id: <1490191680-14481-16-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1490191680-14481-1-git-send-email-yamada.masahiro@socionext.com> References: <1490191680-14481-1-git-send-email-yamada.masahiro@socionext.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170322_140957_676636_34F5522A X-CRM114-Status: GOOD ( 12.76 ) X-Spam-Score: -1.2 (-) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-1.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: laurent.monat@idquantique.com, Boris Brezillon , thorsten.christiansson@idquantique.com, Richard Weinberger , Marek Vasut , Masahiro Yamada , Artem Bityutskiy , Cyrille Pitchen , Jason Roberts , linux-kernel@vger.kernel.org, Mark Rutland , Dinh Nguyen , devicetree@vger.kernel.org, Rob Herring , Masami Hiramatsu , Chuanxiao Dong , Jassi Brar , Brian Norris , Enrico Jorns , David Woodhouse , Graham Moore MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+patch=linaro.org@lists.infradead.org The driver sets appropriate DMA mask. Delete the "dma-mask" DT property. See [1] for negative comments for this binding. [1] https://lkml.org/lkml/2016/2/8/57 Signed-off-by: Masahiro Yamada Acked-by: Rob Herring --- Changes in v2: None Documentation/devicetree/bindings/mtd/denali-nand.txt | 2 -- drivers/mtd/nand/denali_dt.c | 9 --------- 2 files changed, 11 deletions(-) -- 2.7.4 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ diff --git a/Documentation/devicetree/bindings/mtd/denali-nand.txt b/Documentation/devicetree/bindings/mtd/denali-nand.txt index 6f4ab4c..e593bbe 100644 --- a/Documentation/devicetree/bindings/mtd/denali-nand.txt +++ b/Documentation/devicetree/bindings/mtd/denali-nand.txt @@ -6,7 +6,6 @@ Required properties: - reg : should contain registers location and length for data and reg. - reg-names: Should contain the reg names "nand_data" and "denali_reg" - interrupts : The interrupt number. - - dm-mask : DMA bit mask The device tree may optionally contain sub-nodes describing partitions of the address space. See partition.txt for more detail. @@ -20,5 +19,4 @@ nand: nand@ff900000 { reg = <0xff900000 0x100000>, <0xffb80000 0x10000>; reg-names = "nand_data", "denali_reg"; interrupts = <0 144 4>; - dma-mask = <0xffffffff>; }; diff --git a/drivers/mtd/nand/denali_dt.c b/drivers/mtd/nand/denali_dt.c index 9577bfd..b8a8284 100644 --- a/drivers/mtd/nand/denali_dt.c +++ b/drivers/mtd/nand/denali_dt.c @@ -46,8 +46,6 @@ static const struct of_device_id denali_nand_dt_ids[] = { }; MODULE_DEVICE_TABLE(of, denali_nand_dt_ids); -static u64 denali_dma_mask; - static int denali_dt_probe(struct platform_device *ofdev) { struct resource *denali_reg, *nand_data; @@ -83,13 +81,6 @@ static int denali_dt_probe(struct platform_device *ofdev) if (IS_ERR(denali->flash_mem)) return PTR_ERR(denali->flash_mem); - if (!of_property_read_u32(ofdev->dev.of_node, - "dma-mask", (u32 *)&denali_dma_mask)) { - denali->dev->dma_mask = &denali_dma_mask; - } else { - denali->dev->dma_mask = NULL; - } - dt->clk = devm_clk_get(&ofdev->dev, NULL); if (IS_ERR(dt->clk)) { dev_err(&ofdev->dev, "no clk available\n");