From patchwork Wed Mar 22 14:07:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 95774 Delivered-To: patch@linaro.org Received: by 10.140.89.233 with SMTP id v96csp261869qgd; Wed, 22 Mar 2017 07:19:10 -0700 (PDT) X-Received: by 10.99.101.67 with SMTP id z64mr45206710pgb.78.1490192350329; Wed, 22 Mar 2017 07:19:10 -0700 (PDT) Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [65.50.211.133]) by mx.google.com with ESMTPS id 92si1995163plc.124.2017.03.22.07.19.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Mar 2017 07:19:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 65.50.211.133 as permitted sender) client-ip=65.50.211.133; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org; dkim=neutral (body hash did not verify) header.i=@infradead.org; dkim=neutral (body hash did not verify) header.i=@nifty.com; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=linux-mtd-bounces+patch=linaro.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=ezxp7aymU8xuspjDB+n0HrSA6QJIKzNAXtU/p1mg/YI=; b=ONozmI6RZA5BxTwij+ULqGi4Gc TYzXHJ2WMw0NYeJiLWk3Um7Ew+5YnNxwUdtPApOHImNA4xMuCF8lWzlAGZYKzePXGqP1Yc6SP04Ji dhhNS4UKZRvO+QguaeGYRoua7QD1s+4i3SfYOopicbM7qTeloQ364gTAuTsc03MLTQCktbtVjY7xG vzBekiY2XChUiv5JdaTc6PU41KZT6+gmKThCOchPVRV2MZKjBCtfWDumfKIUSkB1CLQssAPYSp9ek cE+e04RfyJ7Y4XZLfxH0r/1t8DTkP3hBmATXzOrThztaty9KMvLM+h74Ls87IAnbxgl98LaPI0Axr GPqmSykg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cqh6T-00010b-2t; Wed, 22 Mar 2017 14:19:09 +0000 Received: from casper.infradead.org ([2001:770:15f::2]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cqh5d-0007mZ-FV for linux-mtd@bombadil.infradead.org; Wed, 22 Mar 2017 14:18:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ETbm79CiIOZbgKFV5qv7tXWHCr+CVtF1sohZbi3+yhw=; b=MDOYIO+0efWUo24b9fpq5VJvW H/VzzHk4ry9216cTRFRlFObmbs6g7iRUGGlctoyyyGB/QG+/4/c76m0vmvip6g8YyWhPdnRDT71du NpQJZkDmikBOj5ybU4vaoVUPgLjVNM7IY5g+8aQfLZRhR1j8IAaabKS86xvH4/Sdbjvia80o4b43O 00N2nI1XRz4dbIotC5A8lGob797BaSHCKUxQ+SKgc/LbBVUfLijH/FG6W6jvOSQUB4O3QvsTLxTkk vqMHsh87JiRIyBWGtJ/Lz5U2OMvd4jHbpgI0ZWIAgEX0c66Hii0iimZfputKXsW/6MZJorxFMgHm/ mA5dP6vkA==; Received: from conuserg-07.nifty.com ([210.131.2.74]) by casper.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cqgxk-0007tq-S4 for linux-mtd@lists.infradead.org; Wed, 22 Mar 2017 14:10:10 +0000 Received: from pug.jp.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id v2ME8LDh010154; Wed, 22 Mar 2017 23:08:59 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com v2ME8LDh010154 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1490191740; bh=ETbm79CiIOZbgKFV5qv7tXWHCr+CVtF1sohZbi3+yhw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ClIVyXptmag6IdtB8IZBbrUU09cFssjkX+4mDMf5En4QqUPIOX4THCqohenuiZWVV tSsKbfK31/7URE59+V/UJ8MRbR0jBRsecVoHnna+bV+As7QVD3mLzBhCBhWtiICrF6 Wx7E4mjfT3IAYw6ARgqdltisNSJCoHPNqj1Js6fSM0iLbXXd+cONinkVcud9IY13jJ UjP8xtXMLsy1Iwgc/mcEImZb/vZJFsMvmH1U3R9Ll1jmHXuk1Ax6cWgnGmsovzIsfM 5Yx5zwk1naHpmgL5yUsELXHYY0azQQJURH3U7epBIoI6J7RThGXlUWqImX8Wedac7F hvUK3ddluj0Pw== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-mtd@lists.infradead.org Subject: [PATCH v2 24/53] mtd: nand: denali: remove meaningless writes to read-only registers Date: Wed, 22 Mar 2017 23:07:31 +0900 Message-Id: <1490191680-14481-25-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1490191680-14481-1-git-send-email-yamada.masahiro@socionext.com> References: <1490191680-14481-1-git-send-email-yamada.masahiro@socionext.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170322_141009_381584_52193E40 X-CRM114-Status: GOOD ( 13.44 ) X-Spam-Score: -1.2 (-) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-1.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: laurent.monat@idquantique.com, Boris Brezillon , thorsten.christiansson@idquantique.com, Richard Weinberger , Marek Vasut , Masahiro Yamada , Artem Bityutskiy , Cyrille Pitchen , Jason Roberts , linux-kernel@vger.kernel.org, Dinh Nguyen , Masami Hiramatsu , Chuanxiao Dong , Jassi Brar , Brian Norris , Enrico Jorns , David Woodhouse , Graham Moore MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+patch=linaro.org@lists.infradead.org The write accesses to LOGICAL_PAGE_{DATA,SPARE}_SIZE have no effect because the Denali User's Guide says these registers are read-only. The hardware automatically multiplies the main/spare size by the number of devices and update LOGICAL_PAGE_{DATA,SPARE}_SIZE. Signed-off-by: Masahiro Yamada --- Changes in v2: None drivers/mtd/nand/denali.c | 16 ---------------- 1 file changed, 16 deletions(-) -- 2.7.4 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c index 3da0a0e..5e89709 100644 --- a/drivers/mtd/nand/denali.c +++ b/drivers/mtd/nand/denali.c @@ -342,8 +342,6 @@ static void get_samsung_nand_para(struct denali_nand_info *denali, static void get_toshiba_nand_para(struct denali_nand_info *denali) { - uint32_t tmp; - /* * Workaround to fix a controller bug which reports a wrong * spare area size for some kind of Toshiba NAND device @@ -351,10 +349,6 @@ static void get_toshiba_nand_para(struct denali_nand_info *denali) if ((ioread32(denali->flash_reg + DEVICE_MAIN_AREA_SIZE) == 4096) && (ioread32(denali->flash_reg + DEVICE_SPARE_AREA_SIZE) == 64)) { iowrite32(216, denali->flash_reg + DEVICE_SPARE_AREA_SIZE); - tmp = ioread32(denali->flash_reg + DEVICES_CONNECTED) * - ioread32(denali->flash_reg + DEVICE_SPARE_AREA_SIZE); - iowrite32(tmp, - denali->flash_reg + LOGICAL_PAGE_SPARE_SIZE); #if SUPPORT_15BITECC iowrite32(15, denali->flash_reg + ECC_CORRECTION); #elif SUPPORT_8BITECC @@ -366,22 +360,12 @@ static void get_toshiba_nand_para(struct denali_nand_info *denali) static void get_hynix_nand_para(struct denali_nand_info *denali, uint8_t device_id) { - uint32_t main_size, spare_size; - switch (device_id) { case 0xD5: /* Hynix H27UAG8T2A, H27UBG8U5A or H27UCG8VFA */ case 0xD7: /* Hynix H27UDG8VEM, H27UCG8UDM or H27UCG8V5A */ iowrite32(128, denali->flash_reg + PAGES_PER_BLOCK); iowrite32(4096, denali->flash_reg + DEVICE_MAIN_AREA_SIZE); iowrite32(224, denali->flash_reg + DEVICE_SPARE_AREA_SIZE); - main_size = 4096 * - ioread32(denali->flash_reg + DEVICES_CONNECTED); - spare_size = 224 * - ioread32(denali->flash_reg + DEVICES_CONNECTED); - iowrite32(main_size, - denali->flash_reg + LOGICAL_PAGE_DATA_SIZE); - iowrite32(spare_size, - denali->flash_reg + LOGICAL_PAGE_SPARE_SIZE); iowrite32(0, denali->flash_reg + DEVICE_WIDTH); #if SUPPORT_15BITECC iowrite32(15, denali->flash_reg + ECC_CORRECTION);