diff mbox

[V2] sanity: explain where TMPDIR is if we're telling the user to delete it

Message ID 1491322446-18058-1-git-send-email-ross.burton@intel.com
State Accepted
Commit c03de901213846d7c8cc2a12a97034273aa904c3
Headers show

Commit Message

Ross Burton April 4, 2017, 4:14 p.m. UTC
Signed-off-by: Ross Burton <ross.burton@intel.com>

---
 meta/classes/sanity.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.8.1

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Paul Eggleton April 4, 2017, 10:46 p.m. UTC | #1
On Wednesday, 5 April 2017 5:02:05 AM NZST Patchwork wrote:
> * Issue             Patch line too long (current length 214)

> [test_max_line_length] Suggested fix    Shorten the corresponding patch

> line (max length supported 180) Patch           

> meta/classes/sanity.bbclass

>   Line             +            status.addresult("The layout of TMPDIR

> changed for Recipe Specific  ...


I'm not sure we need to be checking for this. If our code strictly adhered to 
a maximum line length already then maybe, but the vast majority of it doesn't 
at the moment.

Cheers,
Paul


-- 

Paul Eggleton
Intel Open Source Technology Centre
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
diff mbox

Patch

diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index 94c78b5..e8064ac 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -589,7 +589,7 @@  def sanity_handle_abichanges(status, d):
             with open(abifile, "w") as f:
                 f.write(current_abi)
         elif int(abi) <= 11 and current_abi == "12":
-            status.addresult("The layout of TMPDIR changed for Recipe Specific Sysroots.\nConversion doesn't make sense and this change will rebuild everything so please start with a clean TMPDIR.\n")
+            status.addresult("The layout of TMPDIR changed for Recipe Specific Sysroots.\nConversion doesn't make sense and this change will rebuild everything so please delete TMPDIR (%s).\n" % d.getVar("TMPDIR"))
         elif (abi != current_abi):
             # Code to convert from one ABI to another could go here if possible.
             status.addresult("Error, TMPDIR has changed its layout version number (%s to %s) and you need to either rebuild, revert or adjust it at your own risk.\n" % (abi, current_abi))