From patchwork Wed Apr 5 10:31:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Amit Pundir X-Patchwork-Id: 96811 Delivered-To: patch@linaro.org Received: by 10.140.89.233 with SMTP id v96csp195944qgd; Wed, 5 Apr 2017 03:33:15 -0700 (PDT) X-Received: by 10.99.119.69 with SMTP id s66mr28929571pgc.196.1491388395487; Wed, 05 Apr 2017 03:33:15 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s128si20242483pgc.85.2017.04.05.03.33.15; Wed, 05 Apr 2017 03:33:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753016AbdDEKdO (ORCPT + 6 others); Wed, 5 Apr 2017 06:33:14 -0400 Received: from mail-pg0-f41.google.com ([74.125.83.41]:33801 "EHLO mail-pg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933163AbdDEKco (ORCPT ); Wed, 5 Apr 2017 06:32:44 -0400 Received: by mail-pg0-f41.google.com with SMTP id 21so6027368pgg.1 for ; Wed, 05 Apr 2017 03:32:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OJiFDfsyOV1PrZSb2b5R31fUn8CXjSJkXlkTLmqQins=; b=KFZmmVNrc4h/zOSCF5JhjO+8C4V8CnTnggptH1YAYGAP5Sd0rV4L3F6VI0Vapuoc7V 9gfyHp8oBMwHK5gKv9Gq5v2nvsKvNzaSkCFHrZAD1FyeU5CmBGxlpafD08xZgD/IXitz zfRm1+5YaW/9pKE6vesbaqUPUi5nr86LM7y+U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OJiFDfsyOV1PrZSb2b5R31fUn8CXjSJkXlkTLmqQins=; b=SI0A4O8IVCERxUqh89TCvgeJZFY2lImU0DlS6eLat/Mg3C7veSsZc4SKKjrIRVOVZG NSdWNr7T+VdXBMF0P+4vgF7FSVcEFMzmKGW7rxL9yqsJbuQcwsrJD+pIkLi2AYBO+JrE od9zc/F72iMKYeZLB9BxWwELLzl5il2lbFhuvx4YWsPUQlCnt7TCozCxnNmi8Rn9UVfV uOkRV+SIKaqp/NyZN84NeQkY4Z3dXLpya/1EtmU89D2+jYGrDlijSRMf3ppP+4cy8YO/ wTYl8L4yJwffldLhdWZprhcdpUnYGe686nwZFLsG3T6oV7zkr6AbWcwrHaosakChevbt wiGg== X-Gm-Message-State: AFeK/H1Hn4TQNjy1g+W02E30GkWyxpsctgaa+nyUnd+W/oj2OHA/v8B9DgBcIpzHkxH14IT2 X-Received: by 10.99.117.66 with SMTP id f2mr29176561pgn.153.1491388363189; Wed, 05 Apr 2017 03:32:43 -0700 (PDT) Received: from localhost.localdomain ([106.51.240.246]) by smtp.gmail.com with ESMTPSA id a62sm36732075pgc.60.2017.04.05.03.32.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 05 Apr 2017 03:32:42 -0700 (PDT) From: Amit Pundir To: stable@vger.kernel.org Cc: gregkh@linuxfoundation.org, =?utf-8?q?Noralf_Tr=C3=B8nnes?= , Wolfram Sang Subject: [PATCH v2 for-4.9 07/32] i2c: bcm2835: Use dev_dbg logging on transfer errors Date: Wed, 5 Apr 2017 16:01:59 +0530 Message-Id: <1491388344-13521-8-git-send-email-amit.pundir@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1491388344-13521-1-git-send-email-amit.pundir@linaro.org> References: <1491388344-13521-1-git-send-email-amit.pundir@linaro.org> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Noralf Trønnes Writing to an AT24C32 generates on average 2x i2c transfer errors per 32-byte page write. Which amounts to a lot for a 4k write. This is due to the fact that the chip doesn't respond during it's internal write cycle when the at24 driver tries and retries the next write. Only a handful drivers use dev_err() on transfer error, so switch to dev_dbg() instead. Signed-off-by: Noralf Trønnes Reviewed-by: Eric Anholt Signed-off-by: Wolfram Sang (cherry picked from commit 23c9540b3ad1d7473fe40df80074d0fb0bf04869) Signed-off-by: Amit Pundir --- drivers/i2c/busses/i2c-bcm2835.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c index d2ba1a4..54d510a 100644 --- a/drivers/i2c/busses/i2c-bcm2835.c +++ b/drivers/i2c/busses/i2c-bcm2835.c @@ -216,7 +216,7 @@ static int bcm2835_i2c_xfer_msg(struct bcm2835_i2c_dev *i2c_dev, (msg->flags & I2C_M_IGNORE_NAK)) return 0; - dev_err(i2c_dev->dev, "i2c transfer failed: %x\n", i2c_dev->msg_err); + dev_dbg(i2c_dev->dev, "i2c transfer failed: %x\n", i2c_dev->msg_err); if (i2c_dev->msg_err & BCM2835_I2C_S_ERR) return -EREMOTEIO;