diff mbox series

[2/5] davinci: omapl138_lcdk: enable some filesystem related commands

Message ID 20170406092257.15541-3-nsekhar@ti.com
State Accepted
Commit 11b3156007e26b191b329385ce2873ec68696e34
Headers show
Series davinci: omapl138_lcdk: align mmcboot with rest of TI boards | expand

Commit Message

Sekhar Nori April 6, 2017, 9:22 a.m. UTC
Enable some generic filesystem commands as
well as disk partition related commands for
OMAP-L138 LCDK board.

These help in booting Linux from MMC/SD, for
example.

Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
 configs/omapl138_lcdk_defconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Lukasz Majewski April 6, 2017, 9:58 a.m. UTC | #1
On Thu, 6 Apr 2017 14:52:54 +0530
Sekhar Nori <nsekhar@ti.com> wrote:

> Enable some generic filesystem commands as
> well as disk partition related commands for
> OMAP-L138 LCDK board.
> 
> These help in booting Linux from MMC/SD, for
> example.
> 
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
> ---
>  configs/omapl138_lcdk_defconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/configs/omapl138_lcdk_defconfig
> b/configs/omapl138_lcdk_defconfig index 352c9b462544..7c8228bf5bcb
> 100644 --- a/configs/omapl138_lcdk_defconfig
> +++ b/configs/omapl138_lcdk_defconfig
> @@ -27,6 +27,8 @@ CONFIG_CMD_PING=y
>  CONFIG_CMD_EXT2=y
>  CONFIG_CMD_FAT=y
>  CONFIG_CMD_UBI=y
> +CONFIG_CMD_FS_GENERIC=y
> +CONFIG_CMD_PART=y
>  CONFIG_SYS_NAND_U_BOOT_LOCATIONS=y
>  CONFIG_SYS_NAND_U_BOOT_OFFS=0x28000
>  CONFIG_SPI_FLASH=y

Reviewed-by: Lukasz Majewski <lukma@denx.de>

Just one question -> was this generated with make savedefconfig or
added by hand?


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Tom Rini April 6, 2017, 4:23 p.m. UTC | #2
On Thu, Apr 06, 2017 at 02:52:54PM +0530, Sekhar Nori wrote:

> Enable some generic filesystem commands as

> well as disk partition related commands for

> OMAP-L138 LCDK board.

> 

> These help in booting Linux from MMC/SD, for

> example.

> 

> Signed-off-by: Sekhar Nori <nsekhar@ti.com>


Reviewed-by: Tom Rini <trini@konsulko.com>


-- 
Tom
Sekhar Nori April 7, 2017, 5:20 a.m. UTC | #3
Hi Lukasz,

On Thursday 06 April 2017 03:28 PM, Lukasz Majewski wrote:
> On Thu, 6 Apr 2017 14:52:54 +0530
> Sekhar Nori <nsekhar@ti.com> wrote:
> 
>> Enable some generic filesystem commands as
>> well as disk partition related commands for
>> OMAP-L138 LCDK board.
>>
>> These help in booting Linux from MMC/SD, for
>> example.
>>
>> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
>> ---
>>  configs/omapl138_lcdk_defconfig | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/configs/omapl138_lcdk_defconfig
>> b/configs/omapl138_lcdk_defconfig index 352c9b462544..7c8228bf5bcb
>> 100644 --- a/configs/omapl138_lcdk_defconfig
>> +++ b/configs/omapl138_lcdk_defconfig
>> @@ -27,6 +27,8 @@ CONFIG_CMD_PING=y
>>  CONFIG_CMD_EXT2=y
>>  CONFIG_CMD_FAT=y
>>  CONFIG_CMD_UBI=y
>> +CONFIG_CMD_FS_GENERIC=y
>> +CONFIG_CMD_PART=y
>>  CONFIG_SYS_NAND_U_BOOT_LOCATIONS=y
>>  CONFIG_SYS_NAND_U_BOOT_OFFS=0x28000
>>  CONFIG_SPI_FLASH=y
> 
> Reviewed-by: Lukasz Majewski <lukma@denx.de>
> 
> Just one question -> was this generated with make savedefconfig or
> added by hand?

Thanks for the review! This was added by hand.

Thanks,
Sekhar
Tom Rini April 10, 2017, 6:24 p.m. UTC | #4
On Thu, Apr 06, 2017 at 02:52:54PM +0530, Sekhar Nori wrote:

> Enable some generic filesystem commands as

> well as disk partition related commands for

> OMAP-L138 LCDK board.

> 

> These help in booting Linux from MMC/SD, for

> example.

> 

> Signed-off-by: Sekhar Nori <nsekhar@ti.com>

> Reviewed-by: Lukasz Majewski <lukma@denx.de>

> Reviewed-by: Tom Rini <trini@konsulko.com>


Applied to u-boot/master, thanks!

-- 
Tom
diff mbox series

Patch

diff --git a/configs/omapl138_lcdk_defconfig b/configs/omapl138_lcdk_defconfig
index 352c9b462544..7c8228bf5bcb 100644
--- a/configs/omapl138_lcdk_defconfig
+++ b/configs/omapl138_lcdk_defconfig
@@ -27,6 +27,8 @@  CONFIG_CMD_PING=y
 CONFIG_CMD_EXT2=y
 CONFIG_CMD_FAT=y
 CONFIG_CMD_UBI=y
+CONFIG_CMD_FS_GENERIC=y
+CONFIG_CMD_PART=y
 CONFIG_SYS_NAND_U_BOOT_LOCATIONS=y
 CONFIG_SYS_NAND_U_BOOT_OFFS=0x28000
 CONFIG_SPI_FLASH=y