diff mbox

[API-NEXT] api: ipsec: spi_overlap and lookup modes

Message ID 1491568520-28883-1-git-send-email-petri.savolainen@linaro.org
State Accepted
Commit aae51fd0f29d5746f2aa6153bfd0b571aed14369
Headers show

Commit Message

Petri Savolainen April 7, 2017, 12:35 p.m. UTC
Lookup modes are per SA and thus may be used in a mix. Spi_overlap
parameter is global. So, removed comment about ignoring it in
LOOKUP_SPI mode.

Signed-off-by: Petri Savolainen <petri.savolainen@linaro.org>

---
 include/odp/api/spec/ipsec.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

-- 
2.8.1

Comments

Bill Fischofer April 7, 2017, 12:47 p.m. UTC | #1
On Fri, Apr 7, 2017 at 7:35 AM, Petri Savolainen
<petri.savolainen@linaro.org> wrote:
> Lookup modes are per SA and thus may be used in a mix. Spi_overlap

> parameter is global. So, removed comment about ignoring it in

> LOOKUP_SPI mode.

>

> Signed-off-by: Petri Savolainen <petri.savolainen@linaro.org>


Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org>


> ---

>  include/odp/api/spec/ipsec.h | 4 +---

>  1 file changed, 1 insertion(+), 3 deletions(-)

>

> diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h

> index b3dc0ca..a0ceb11 100644

> --- a/include/odp/api/spec/ipsec.h

> +++ b/include/odp/api/spec/ipsec.h

> @@ -111,9 +111,7 @@ typedef struct odp_ipsec_inbound_config_t {

>                 uint32_t max_spi;

>

>                 /** Select if SPI values for SA lookup are unique or may contain

> -                *  the same value multiple times. This configuration is not

> -                *  relevant in ODP_IPSEC_LOOKUP_SPI mode. The default value

> -                *  is 0.

> +                *  the same SPI value multiple times. The default value is 0.

>                  *

>                  *  0: All SAs in SA lookup have unique SPI value

>                  *  1: The same SPI value may be used for multiple SAs

> --

> 2.8.1

>
Maxim Uvarov April 7, 2017, 6:52 p.m. UTC | #2
Merged this patch.

Maxim.

On 04/07/17 15:47, Bill Fischofer wrote:
> On Fri, Apr 7, 2017 at 7:35 AM, Petri Savolainen

> <petri.savolainen@linaro.org> wrote:

>> Lookup modes are per SA and thus may be used in a mix. Spi_overlap

>> parameter is global. So, removed comment about ignoring it in

>> LOOKUP_SPI mode.

>>

>> Signed-off-by: Petri Savolainen <petri.savolainen@linaro.org>

> 

> Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org>

> 

>> ---

>>  include/odp/api/spec/ipsec.h | 4 +---

>>  1 file changed, 1 insertion(+), 3 deletions(-)

>>

>> diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h

>> index b3dc0ca..a0ceb11 100644

>> --- a/include/odp/api/spec/ipsec.h

>> +++ b/include/odp/api/spec/ipsec.h

>> @@ -111,9 +111,7 @@ typedef struct odp_ipsec_inbound_config_t {

>>                 uint32_t max_spi;

>>

>>                 /** Select if SPI values for SA lookup are unique or may contain

>> -                *  the same value multiple times. This configuration is not

>> -                *  relevant in ODP_IPSEC_LOOKUP_SPI mode. The default value

>> -                *  is 0.

>> +                *  the same SPI value multiple times. The default value is 0.

>>                  *

>>                  *  0: All SAs in SA lookup have unique SPI value

>>                  *  1: The same SPI value may be used for multiple SAs

>> --

>> 2.8.1

>>
diff mbox

Patch

diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h
index b3dc0ca..a0ceb11 100644
--- a/include/odp/api/spec/ipsec.h
+++ b/include/odp/api/spec/ipsec.h
@@ -111,9 +111,7 @@  typedef struct odp_ipsec_inbound_config_t {
 		uint32_t max_spi;
 
 		/** Select if SPI values for SA lookup are unique or may contain
-		 *  the same value multiple times. This configuration is not
-		 *  relevant in ODP_IPSEC_LOOKUP_SPI mode. The default value
-		 *  is 0.
+		 *  the same SPI value multiple times. The default value is 0.
 		 *
 		 *  0: All SAs in SA lookup have unique SPI value
 		 *  1: The same SPI value may be used for multiple SAs