[Linaro-uefi,1/2] Chips/Hisilicon: add missing UefiBootManagerLib resolution to shared .inc

Message ID 20170411094832.8056-1-ard.biesheuvel@linaro.org
State Accepted
Commit 0b392eff24e30cb1f599e29b9037949201fc35ee
Headers show
Series
  • [Linaro-uefi,1/2] Chips/Hisilicon: add missing UefiBootManagerLib resolution to shared .inc
Related show

Commit Message

Ard Biesheuvel April 11, 2017, 9:48 a.m.
Upstream EDK2 changes now require platforms that build the UEFI Shell
from source to provide a resolution for UefiBootManagerLib, and some
other library class it transitively depends on. So add them to the
DSC include shared between the HiSilicon platforms.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 Chips/Hisilicon/Hisilicon.dsc.inc | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Leif Lindholm April 11, 2017, 10:23 p.m. | #1
On Tue, Apr 11, 2017 at 10:48:31AM +0100, Ard Biesheuvel wrote:
> Upstream EDK2 changes now require platforms that build the UEFI Shell
> from source to provide a resolution for UefiBootManagerLib, and some
> other library class it transitively depends on. So add them to the
> DSC include shared between the HiSilicon platforms.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

For this series, and the Marvell BdsLib resolution fixup:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

(both pushed)

> ---
>  Chips/Hisilicon/Hisilicon.dsc.inc | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Chips/Hisilicon/Hisilicon.dsc.inc b/Chips/Hisilicon/Hisilicon.dsc.inc
> index d856a659a8fb..716900874274 100644
> --- a/Chips/Hisilicon/Hisilicon.dsc.inc
> +++ b/Chips/Hisilicon/Hisilicon.dsc.inc
> @@ -198,7 +198,12 @@
>    HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
>    ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>    FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf
> +
> +[LibraryClasses.common.UEFI_DRIVER,LibraryClasses.common.UEFI_APPLICATION]
> +  DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
> +  ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
>    SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
> +  UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
>  
>  [LibraryClasses.common.UEFI_DRIVER]
>    ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
> -- 
> 2.9.3
>

Patch

diff --git a/Chips/Hisilicon/Hisilicon.dsc.inc b/Chips/Hisilicon/Hisilicon.dsc.inc
index d856a659a8fb..716900874274 100644
--- a/Chips/Hisilicon/Hisilicon.dsc.inc
+++ b/Chips/Hisilicon/Hisilicon.dsc.inc
@@ -198,7 +198,12 @@ 
   HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
   ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
   FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf
+
+[LibraryClasses.common.UEFI_DRIVER,LibraryClasses.common.UEFI_APPLICATION]
+  DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
+  ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
   SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
+  UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
 
 [LibraryClasses.common.UEFI_DRIVER]
   ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf