From patchwork Wed Apr 12 17:43:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sumit Semwal X-Patchwork-Id: 97331 Delivered-To: patch@linaro.org Received: by 10.140.109.52 with SMTP id k49csp374419qgf; Wed, 12 Apr 2017 10:44:42 -0700 (PDT) X-Received: by 10.98.157.150 with SMTP id a22mr19903172pfk.255.1492019082512; Wed, 12 Apr 2017 10:44:42 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l17si21057414pgj.292.2017.04.12.10.44.42; Wed, 12 Apr 2017 10:44:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753882AbdDLRoc (ORCPT + 6 others); Wed, 12 Apr 2017 13:44:32 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:34105 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755221AbdDLRo3 (ORCPT ); Wed, 12 Apr 2017 13:44:29 -0400 Received: by mail-pf0-f170.google.com with SMTP id c198so16979428pfc.1 for ; Wed, 12 Apr 2017 10:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=VLHjgau/bHn36t9u38eVY9C1h0TFKG2NxVBdYg6dTE8=; b=EKwK+S8zGLqcvCnVHDvbND6c52fvS1Vn2C/XE73/IA1xXYAqHsrUXdiWroD0iT8YQa J+3PGsBbQ4IjzMWR8oNtBcVsd3Y44nAHQYQSMmcvJKi7lH+vghLjqA5ASPGd8ek5RDpu GJRzMajNQXvcnjCnTS78Xl0njsFV2LHIPMNFA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=VLHjgau/bHn36t9u38eVY9C1h0TFKG2NxVBdYg6dTE8=; b=OH2PXxRalckBjScOGK0lnLVcFLAzAvweAs59Fl3qj2v40hRlep7h/EN9jXs7JMNKM6 y9TnQVqa69Tm1a/Mxigmty50MkQglfrbyhXjWPjh9QM0/dqnThI9IbQedPGDl9xyt/wM 8uSdGhz7gstFgLqqdkiGOcdQwt7BYxiVVqiwhQAg8n4ic0vy4qdm5WZ3JQnEaQ7gtQbQ qi6Jaee4oHkk4E1ELLEJaelymEjv0pqgEOK/et5V+4ynNkaNNh5QcUUWNUZQRBWJ6kf+ fuSFjMDcdStTW3o6q2rDB9pcRAU9RwglcCyQfdWa0X6Kxxor4kOOX8WhTGYfk96mc0Tj PfDA== X-Gm-Message-State: AFeK/H2lURAv6Nwk44IMb5k8gnt87u0EZA0zyZqQuoqLiHEVehEh7vWVjZVTZnfsKC0kDTqI X-Received: by 10.84.241.74 with SMTP id u10mr44177510plm.28.1492019063814; Wed, 12 Apr 2017 10:44:23 -0700 (PDT) Received: from phantom.lan ([106.51.225.38]) by smtp.gmail.com with ESMTPSA id r17sm37750019pfa.13.2017.04.12.10.44.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 12 Apr 2017 10:44:22 -0700 (PDT) From: Sumit Semwal To: stable@vger.kernel.org Cc: Vitaly Kuznetsov , "K . Y . Srinivasan" , Greg Kroah-Hartman , Sumit Semwal Subject: [v2 PATCH for-4.4 08/16] Drivers: hv: don't leak memory in vmbus_establish_gpadl() Date: Wed, 12 Apr 2017 23:13:42 +0530 Message-Id: <1492019030-13567-9-git-send-email-sumit.semwal@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1492019030-13567-1-git-send-email-sumit.semwal@linaro.org> References: <1492019030-13567-1-git-send-email-sumit.semwal@linaro.org> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Vitaly Kuznetsov [ Upstream commit 7cc80c98070ccc7940fc28811c92cca0a681015d ] In some cases create_gpadl_header() allocates submessages but we never free them. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sumit Semwal --- drivers/hv/channel.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) -- 2.7.4 diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c index fb1e3df..ec61ad8 100644 --- a/drivers/hv/channel.c +++ b/drivers/hv/channel.c @@ -373,7 +373,7 @@ int vmbus_establish_gpadl(struct vmbus_channel *channel, void *kbuffer, struct vmbus_channel_gpadl_header *gpadlmsg; struct vmbus_channel_gpadl_body *gpadl_body; struct vmbus_channel_msginfo *msginfo = NULL; - struct vmbus_channel_msginfo *submsginfo; + struct vmbus_channel_msginfo *submsginfo, *tmp; struct list_head *curr; u32 next_gpadl_handle; unsigned long flags; @@ -430,6 +430,10 @@ cleanup: spin_lock_irqsave(&vmbus_connection.channelmsg_lock, flags); list_del(&msginfo->msglistentry); spin_unlock_irqrestore(&vmbus_connection.channelmsg_lock, flags); + list_for_each_entry_safe(submsginfo, tmp, &msginfo->submsglist, + msglistentry) { + kfree(submsginfo); + } kfree(msginfo); return ret;