[V2,1/3] sched: topology: drop memset() from init_rootdomain()

Message ID fc2f6cc90b098040970c85a97046512572d765bc.1492065513.git.viresh.kumar@linaro.org
State New
Headers show
  • sched: Minor cleanups
Related show

Commit Message

Viresh Kumar April 13, 2017, 9:15 a.m.
There are only two callers of init_rootdomain(). One of them passes a
global to it and another one sends dynamically allocated root-domain.

There is no need to memset the root-domain in the first case as the
structure is already reset.

Update alloc_rootdomain() to allocate the memory with kzalloc() and
remove the memset() call from init_rootdomain().

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

 kernel/sched/topology.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)



diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index 1b0b4fb12837..a2497702e628 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -242,8 +242,6 @@  void rq_attach_root(struct rq *rq, struct root_domain *rd)
 static int init_rootdomain(struct root_domain *rd)
-	memset(rd, 0, sizeof(*rd));
 	if (!zalloc_cpumask_var(&rd->span, GFP_KERNEL))
 		goto out;
 	if (!zalloc_cpumask_var(&rd->online, GFP_KERNEL))
@@ -292,7 +290,7 @@  static struct root_domain *alloc_rootdomain(void)
 	struct root_domain *rd;
-	rd = kmalloc(sizeof(*rd), GFP_KERNEL);
+	rd = kzalloc(sizeof(*rd), GFP_KERNEL);
 	if (!rd)
 		return NULL;