[2/5] libtirpc: Expose key_secretkey_is_set API

Message ID 20170419015839.1294-2-raj.khem@gmail.com
State Superseded
Headers show
Series
  • [1/5] libtirpc: Backport fixes from 1.0.2rc3
Related show

Commit Message

Khem Raj April 19, 2017, 1:58 a.m.
libnsl needs this API

Signed-off-by: Khem Raj <raj.khem@gmail.com>

---
 .../libtirpc/export_key_secretkey_is_set.patch        | 19 +++++++++++++++++++
 meta/recipes-extended/libtirpc/libtirpc_1.0.1.bb      |  1 +
 2 files changed, 20 insertions(+)
 create mode 100644 meta/recipes-extended/libtirpc/libtirpc/export_key_secretkey_is_set.patch

-- 
2.12.2

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Ross Burton April 19, 2017, 8:52 a.m. | #1
On 19 April 2017 at 02:58, Khem Raj <raj.khem@gmail.com> wrote:

> +-    key_secret_is_set;

> ++    key_secretkey_is_set;

>


This removes key_secret_is_set, was this a typo upstream or a mistake in
the patch?

Ross
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Khem Raj April 19, 2017, 4:25 p.m. | #2
On Wed, Apr 19, 2017 at 1:52 AM, Burton, Ross <ross.burton@intel.com> wrote:
>

> On 19 April 2017 at 02:58, Khem Raj <raj.khem@gmail.com> wrote:

>>

>> +-    key_secret_is_set;

>> ++    key_secretkey_is_set;

>

>

> This removes key_secret_is_set, was this a typo upstream or a mistake in the

> patch?


key_secret_is_set is a typo in libtirpc map file which is fixed here.

>

> Ross

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Ross Burton April 19, 2017, 4:36 p.m. | #3
On 19 April 2017 at 17:25, Khem Raj <raj.khem@gmail.com> wrote:

> key_secret_is_set is a typo in libtirpc map file which is fixed here.

>


Can you resubmit with that in the commit log.  Are you pushing these
upstream?

Ross
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Khem Raj April 19, 2017, 4:37 p.m. | #4
On Wed, Apr 19, 2017 at 9:36 AM, Burton, Ross <ross.burton@intel.com> wrote:
>

> On 19 April 2017 at 17:25, Khem Raj <raj.khem@gmail.com> wrote:

>>

>> key_secret_is_set is a typo in libtirpc map file which is fixed here.

>

>

> Can you resubmit with that in the commit log.  Are you pushing these

> upstream?


Upstream already has a report and a patch for this
https://sourceforge.net/p/libtirpc/discussion/637321/thread/fd73d431/

>

> Ross

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-extended/libtirpc/libtirpc/export_key_secretkey_is_set.patch b/meta/recipes-extended/libtirpc/libtirpc/export_key_secretkey_is_set.patch
new file mode 100644
index 00000000000..bde7951ec1a
--- /dev/null
+++ b/meta/recipes-extended/libtirpc/libtirpc/export_key_secretkey_is_set.patch
@@ -0,0 +1,19 @@ 
+Add key_secretkey_is_set to exported symbols map
+
+Upstream-Status: Pending
+
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+
+Index: libtirpc-1.0.1/src/libtirpc.map
+===================================================================
+--- libtirpc-1.0.1.orig/src/libtirpc.map
++++ libtirpc-1.0.1/src/libtirpc.map
+@@ -298,7 +298,7 @@ TIRPC_0.3.2 {
+     key_gendes;
+     key_get_conv;
+     key_setsecret;
+-    key_secret_is_set;
++    key_secretkey_is_set;
+     key_setnet;
+     netname2host;
+     netname2user;
diff --git a/meta/recipes-extended/libtirpc/libtirpc_1.0.1.bb b/meta/recipes-extended/libtirpc/libtirpc_1.0.1.bb
index 8ba547506bf..b96abc4d57e 100644
--- a/meta/recipes-extended/libtirpc/libtirpc_1.0.1.bb
+++ b/meta/recipes-extended/libtirpc/libtirpc_1.0.1.bb
@@ -13,6 +13,7 @@  SRC_URI = "${SOURCEFORGE_MIRROR}/${BPN}/${BP}.tar.bz2;name=libtirpc \
            ${GENTOO_MIRROR}/${BPN}-glibc-nfs.tar.xz;name=glibc-nfs \
            file://libtirpc-1.0.2-rc3.patch \
            file://libtirpc-0.2.1-fortify.patch \
+           file://export_key_secretkey_is_set.patch \
           "
 
 SRC_URI_append_libc-uclibc = " file://remove-des-functionality.patch \