[1/5,v2] clk: qcom: Update DT bindings for the MSM8660/APQ8060 RPMCC

Message ID 20170419091326.11226-1-linus.walleij@linaro.org
State New
Headers show
Series
  • [1/5,v2] clk: qcom: Update DT bindings for the MSM8660/APQ8060 RPMCC
Related show

Commit Message

Linus Walleij April 19, 2017, 9:13 a.m.
These compatible strings need to be added to extend support
for the RPM CC to cover MSM8660/APQ8060. We also need to add
enumberators to the include file for a few clocks that were
missing.

Cc: devicetree@vger.kernel.org
Acked-by: Rob Herring <robh@kernel.org>

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

---
ChangeLog v1->v2:
- Collect Rob's ACK
---
 Documentation/devicetree/bindings/clock/qcom,rpmcc.txt | 2 ++
 include/dt-bindings/clock/qcom,rpmcc.h                 | 4 ++++
 2 files changed, 6 insertions(+)

-- 
2.9.3

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Linus Walleij May 24, 2017, 9:16 a.m. | #1
On Wed, May 17, 2017 at 9:23 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Wed, Apr 19, 2017 at 11:13 AM, Linus Walleij

> <linus.walleij@linaro.org> wrote:

>

>> These compatible strings need to be added to extend support

>> for the RPM CC to cover MSM8660/APQ8060. We also need to add

>> enumberators to the include file for a few clocks that were

>> missing.

>>

>> Cc: devicetree@vger.kernel.org

>> Acked-by: Rob Herring <robh@kernel.org>

>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

>> ---

>> ChangeLog v1->v2:

>> - Collect Rob's ACK

>

> Ping on this patch set. It's been sitting for a month and was

> not changed from v1 either, if you want me to change something

> it'd be good to know.


Ping on this again.

I am sorry if you guys are swamped, I just don't know what to do,
clock drivers are starting to become the bottleneck for everything
I do. I bet the ARM SoC maintainers must be noticing it too.

Unfortunately I am already managing two subsystems and cannot
volunteer to help out with a third, I would blow a fuse.

But it seems the CLK subsystem could use some co-maintainers?

Peter de Schrijver is a big authority in all things clocking (I clearly
remember him discussing the subject a lot at conferences with lots
of good points) so I would ask him to help, but I don't know how busy
Peter may be with nVidia business etc these days...

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Peter De Schrijver May 26, 2017, 11:57 a.m. | #2
On Wed, May 24, 2017 at 11:16:22AM +0200, Linus Walleij wrote:
> On Wed, May 17, 2017 at 9:23 AM, Linus Walleij <linus.walleij@linaro.org> wrote:

> > On Wed, Apr 19, 2017 at 11:13 AM, Linus Walleij

> > <linus.walleij@linaro.org> wrote:

> >

> >> These compatible strings need to be added to extend support

> >> for the RPM CC to cover MSM8660/APQ8060. We also need to add

> >> enumberators to the include file for a few clocks that were

> >> missing.

> >>

> >> Cc: devicetree@vger.kernel.org

> >> Acked-by: Rob Herring <robh@kernel.org>

> >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

> >> ---

> >> ChangeLog v1->v2:

> >> - Collect Rob's ACK

> >

> > Ping on this patch set. It's been sitting for a month and was

> > not changed from v1 either, if you want me to change something

> > it'd be good to know.

> 

> Ping on this again.

> 

> I am sorry if you guys are swamped, I just don't know what to do,

> clock drivers are starting to become the bottleneck for everything

> I do. I bet the ARM SoC maintainers must be noticing it too.

> 

> Unfortunately I am already managing two subsystems and cannot

> volunteer to help out with a third, I would blow a fuse.

> 

> But it seems the CLK subsystem could use some co-maintainers?

> 

> Peter de Schrijver is a big authority in all things clocking (I clearly

> remember him discussing the subject a lot at conferences with lots

> of good points) so I would ask him to help, but I don't know how busy

> Peter may be with nVidia business etc these days...

> 


I'm usually rather busy yes, but I could try to find some time for this if
asked for.

Peter.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt b/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt
index a7235e9e1c97..d470a0187035 100644
--- a/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt
+++ b/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt
@@ -10,6 +10,8 @@  Required properties :
 - compatible : shall contain only one of the following. The generic
                compatible "qcom,rpmcc" should be also included.
 
+			"qcom,rpmcc-msm8660", "qcom,rpmcc"
+			"qcom,rpmcc-apq8060", "qcom,rpmcc"
 			"qcom,rpmcc-msm8916", "qcom,rpmcc"
 			"qcom,rpmcc-msm8974", "qcom,rpmcc"
 			"qcom,rpmcc-apq8064", "qcom,rpmcc"
diff --git a/include/dt-bindings/clock/qcom,rpmcc.h b/include/dt-bindings/clock/qcom,rpmcc.h
index 96b63c00249e..44358562a031 100644
--- a/include/dt-bindings/clock/qcom,rpmcc.h
+++ b/include/dt-bindings/clock/qcom,rpmcc.h
@@ -37,6 +37,10 @@ 
 #define RPM_SYS_FABRIC_A_CLK			19
 #define RPM_SFPB_CLK				20
 #define RPM_SFPB_A_CLK				21
+#define RPM_PLL4_CLK				22
+#define RPM_PLL4_A_CLK				23
+#define RPM_SMI_CLK				24
+#define RPM_SMI_A_CLK				25
 
 /* SMD RPM clocks */
 #define RPM_SMD_XO_CLK_SRC				0