| Message ID | 20170421131134.27992-5-petri.savolainen@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Use HW time counter | expand |
On 04/21 16:11:30, Petri Savolainen wrote: > Added validation test for the new system info print call. > > Signed-off-by: Petri Savolainen <petri.savolainen@linaro.org> > --- > test/common_plat/validation/api/system/system.c | 8 ++++++++ > test/common_plat/validation/api/system/system.h | 1 + > 2 files changed, 9 insertions(+) > > diff --git a/test/common_plat/validation/api/system/system.c b/test/common_plat/validation/api/system/system.c > index 57ff34eb..5b7ca01a 100644 > --- a/test/common_plat/validation/api/system/system.c > +++ b/test/common_plat/validation/api/system/system.c > @@ -301,6 +301,13 @@ void system_test_odp_cpu_hz_max_id(void) > } > } > > +void system_test_info_print(void) > +{ > + printf("\n\nCalling system info print...\n"); > + odp_sys_info_print(); > + printf("...done. "); Do these printfs provide useful information? > +} > + > odp_testinfo_t system_suite[] = { > ODP_TEST_INFO(system_test_odp_version_numbers), > ODP_TEST_INFO(system_test_odp_cpu_count), > @@ -319,6 +326,7 @@ odp_testinfo_t system_suite[] = { > ODP_TEST_INFO(system_test_odp_cpu_cycles_max), > ODP_TEST_INFO(system_test_odp_cpu_cycles_resolution), > ODP_TEST_INFO(system_test_odp_cpu_cycles_diff), > + ODP_TEST_INFO(system_test_info_print), > ODP_TEST_INFO_NULL, > }; > > diff --git a/test/common_plat/validation/api/system/system.h b/test/common_plat/validation/api/system/system.h > index cbb994eb..c33729b9 100644 > --- a/test/common_plat/validation/api/system/system.h > +++ b/test/common_plat/validation/api/system/system.h > @@ -30,6 +30,7 @@ void system_test_odp_cpu_cycles_max(void); > void system_test_odp_cpu_cycles(void); > void system_test_odp_cpu_cycles_diff(void); > void system_test_odp_cpu_cycles_resolution(void); > +void system_test_info_print(void); > > /* test arrays: */ > extern odp_testinfo_t system_suite[]; > -- > 2.11.0 >
> -----Original Message----- > From: Brian Brooks [mailto:brian.brooks@arm.com] > Sent: Friday, April 21, 2017 7:58 PM > To: Petri Savolainen <petri.savolainen@linaro.org> > Cc: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH 4/8] test: validation: add > odp_sys_info_print test > > On 04/21 16:11:30, Petri Savolainen wrote: > > Added validation test for the new system info print call. > > > > Signed-off-by: Petri Savolainen <petri.savolainen@linaro.org> > > --- > > test/common_plat/validation/api/system/system.c | 8 ++++++++ > > test/common_plat/validation/api/system/system.h | 1 + > > 2 files changed, 9 insertions(+) > > > > diff --git a/test/common_plat/validation/api/system/system.c > b/test/common_plat/validation/api/system/system.c > > index 57ff34eb..5b7ca01a 100644 > > --- a/test/common_plat/validation/api/system/system.c > > +++ b/test/common_plat/validation/api/system/system.c > > @@ -301,6 +301,13 @@ void system_test_odp_cpu_hz_max_id(void) > > } > > } > > > > +void system_test_info_print(void) > > +{ > > + printf("\n\nCalling system info print...\n"); > > + odp_sys_info_print(); > > + printf("...done. "); > > Do these printfs provide useful information? Those make the validation test output look pretty. Otherwise, output is messed with Test: system_test_info_print ... passed text, since Cunit does not put line feeds in between of those two prints. -Petri
diff --git a/test/common_plat/validation/api/system/system.c b/test/common_plat/validation/api/system/system.c index 57ff34eb..5b7ca01a 100644 --- a/test/common_plat/validation/api/system/system.c +++ b/test/common_plat/validation/api/system/system.c @@ -301,6 +301,13 @@ void system_test_odp_cpu_hz_max_id(void) } } +void system_test_info_print(void) +{ + printf("\n\nCalling system info print...\n"); + odp_sys_info_print(); + printf("...done. "); +} + odp_testinfo_t system_suite[] = { ODP_TEST_INFO(system_test_odp_version_numbers), ODP_TEST_INFO(system_test_odp_cpu_count), @@ -319,6 +326,7 @@ odp_testinfo_t system_suite[] = { ODP_TEST_INFO(system_test_odp_cpu_cycles_max), ODP_TEST_INFO(system_test_odp_cpu_cycles_resolution), ODP_TEST_INFO(system_test_odp_cpu_cycles_diff), + ODP_TEST_INFO(system_test_info_print), ODP_TEST_INFO_NULL, }; diff --git a/test/common_plat/validation/api/system/system.h b/test/common_plat/validation/api/system/system.h index cbb994eb..c33729b9 100644 --- a/test/common_plat/validation/api/system/system.h +++ b/test/common_plat/validation/api/system/system.h @@ -30,6 +30,7 @@ void system_test_odp_cpu_cycles_max(void); void system_test_odp_cpu_cycles(void); void system_test_odp_cpu_cycles_diff(void); void system_test_odp_cpu_cycles_resolution(void); +void system_test_info_print(void); /* test arrays: */ extern odp_testinfo_t system_suite[];
Added validation test for the new system info print call. Signed-off-by: Petri Savolainen <petri.savolainen@linaro.org> --- test/common_plat/validation/api/system/system.c | 8 ++++++++ test/common_plat/validation/api/system/system.h | 1 + 2 files changed, 9 insertions(+) -- 2.11.0