[1/3,v2] xen: Export xen_reboot

Message ID 20170424175839.5262-2-julien.grall@arm.com
State New
Headers show
Series
  • xen: Implement EFI reset_system callback
Related show

Commit Message

Julien Grall April 24, 2017, 5:58 p.m.
The helper xen_reboot will be called by the EFI code in a later patch.

Note that the ARM version does not yet exist and will be added in a
later patch too.

Signed-off-by: Julien Grall <julien.grall@arm.com>


---

Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Juergen Gross <jgross@suse.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org

    Changes in v2:
        - Patch added
---
 arch/x86/xen/enlighten.c | 2 +-
 include/xen/xen-ops.h    | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

-- 
2.11.0

--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Boris Ostrovsky April 24, 2017, 6:21 p.m. | #1
On 04/24/2017 01:58 PM, Julien Grall wrote:
> The helper xen_reboot will be called by the EFI code in a later patch.

>

> Note that the ARM version does not yet exist and will be added in a

> later patch too.

>

> Signed-off-by: Julien Grall <julien.grall@arm.com>


I don't think these changes are worth a whole patch. They can be folded
into the third patch.

-boris

>

> ---

>

> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>

> Cc: Juergen Gross <jgross@suse.com>

> Cc: Thomas Gleixner <tglx@linutronix.de>

> Cc: Ingo Molnar <mingo@redhat.com>

> Cc: "H. Peter Anvin" <hpa@zytor.com>

> Cc: x86@kernel.org

>

>     Changes in v2:

>         - Patch added

> ---

>  arch/x86/xen/enlighten.c | 2 +-

>  include/xen/xen-ops.h    | 2 ++

>  2 files changed, 3 insertions(+), 1 deletion(-)

>

> diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c

> index ec1d5c46e58f..563f2d963a04 100644

> --- a/arch/x86/xen/enlighten.c

> +++ b/arch/x86/xen/enlighten.c

> @@ -1294,7 +1294,7 @@ static const struct pv_cpu_ops xen_cpu_ops __initconst = {

>  	.end_context_switch = xen_end_context_switch,

>  };

>  

> -static void xen_reboot(int reason)

> +void xen_reboot(int reason)

>  {

>  	struct sched_shutdown r = { .reason = reason };

>  	int cpu;

> diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h

> index b5486e648607..fc5ddb472f86 100644

> --- a/include/xen/xen-ops.h

> +++ b/include/xen/xen-ops.h

> @@ -22,6 +22,8 @@ void xen_timer_resume(void);

>  void xen_arch_resume(void);

>  void xen_arch_suspend(void);

>  

> +void xen_reboot(int reason);

> +

>  void xen_resume_notifier_register(struct notifier_block *nb);

>  void xen_resume_notifier_unregister(struct notifier_block *nb);

>  


--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Juergen Gross April 25, 2017, 4:02 a.m. | #2
On 24/04/17 20:21, Boris Ostrovsky wrote:
> On 04/24/2017 01:58 PM, Julien Grall wrote:

>> The helper xen_reboot will be called by the EFI code in a later patch.

>>

>> Note that the ARM version does not yet exist and will be added in a

>> later patch too.

>>

>> Signed-off-by: Julien Grall <julien.grall@arm.com>

> 

> I don't think these changes are worth a whole patch. They can be folded

> into the third patch.


No, the 2nd patch needs this, too.

So:

Reviewed-by: Juergen Gross <jgross@suse.com>



Thanks, Juergen
--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Juergen Gross April 28, 2017, 5:59 p.m. | #3
On 25/04/17 06:02, Juergen Gross wrote:
> On 24/04/17 20:21, Boris Ostrovsky wrote:

>> On 04/24/2017 01:58 PM, Julien Grall wrote:

>>> The helper xen_reboot will be called by the EFI code in a later patch.

>>>

>>> Note that the ARM version does not yet exist and will be added in a

>>> later patch too.

>>>

>>> Signed-off-by: Julien Grall <julien.grall@arm.com>

>>

>> I don't think these changes are worth a whole patch. They can be folded

>> into the third patch.

> 

> No, the 2nd patch needs this, too.

> 

> So:

> 

> Reviewed-by: Juergen Gross <jgross@suse.com>


Julien, this patch no longer applies to the for-linus-4.12 branch of
xen/tip. Can you please rebase?


Juergen

--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch hide | download patch | download mbox

diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
index ec1d5c46e58f..563f2d963a04 100644
--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -1294,7 +1294,7 @@  static const struct pv_cpu_ops xen_cpu_ops __initconst = {
 	.end_context_switch = xen_end_context_switch,
 };
 
-static void xen_reboot(int reason)
+void xen_reboot(int reason)
 {
 	struct sched_shutdown r = { .reason = reason };
 	int cpu;
diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
index b5486e648607..fc5ddb472f86 100644
--- a/include/xen/xen-ops.h
+++ b/include/xen/xen-ops.h
@@ -22,6 +22,8 @@  void xen_timer_resume(void);
 void xen_arch_resume(void);
 void xen_arch_suspend(void);
 
+void xen_reboot(int reason);
+
 void xen_resume_notifier_register(struct notifier_block *nb);
 void xen_resume_notifier_unregister(struct notifier_block *nb);