| Message ID | 20170503121143.25090-2-quentin.schulz@free-electrons.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] can: m_can: move Message RAM initialization to function | expand |
On 05/03/2017 02:11 PM, Quentin Schulz wrote: > This adds Power Management deep Suspend/Resume support for Bosch M_CAN > chip. > > When the chip resumes from deep sleep, the RAM needs to be initialized > as it is done when the driver probes. The net interface also needs to be > closed and reopened to be fully functional. Are you sure it's the closing and opening of the net interface. Maybe it's the m_can_start() and/or the subsequent m_can_chip_config()? Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index 3f0445440146..9e0143b528f1 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -1670,12 +1670,10 @@ static __maybe_unused int m_can_suspend(struct device *dev) struct m_can_priv *priv = netdev_priv(ndev); if (netif_running(ndev)) { - netif_stop_queue(ndev); netif_device_detach(ndev); + m_can_close(ndev); } - /* TODO: enter low power */ - priv->can.state = CAN_STATE_SLEEPING; return 0; @@ -1686,13 +1684,13 @@ static __maybe_unused int m_can_resume(struct device *dev) struct net_device *ndev = dev_get_drvdata(dev); struct m_can_priv *priv = netdev_priv(ndev); - /* TODO: exit low power */ + m_can_init_ram(priv); priv->can.state = CAN_STATE_ERROR_ACTIVE; if (netif_running(ndev)) { + m_can_open(ndev); netif_device_attach(ndev); - netif_start_queue(ndev); } return 0;
This adds Power Management deep Suspend/Resume support for Bosch M_CAN chip. When the chip resumes from deep sleep, the RAM needs to be initialized as it is done when the driver probes. The net interface also needs to be closed and reopened to be fully functional. Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com> --- drivers/net/can/m_can/m_can.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) -- 2.11.0