[API-NEXT,1/2] api: crypto: add digest length session parameter

Message ID 20170504125557.21688-1-petri.savolainen@linaro.org
State New
Headers show
Series
  • [API-NEXT,1/2] api: crypto: add digest length session parameter
Related show

Commit Message

Petri Savolainen May 4, 2017, 12:55 p.m.
Authentication capabilities list supported digest lengths
per algorithm, but application did not have means to select which
length is used.

Signed-off-by: Petri Savolainen <petri.savolainen@linaro.org>

---
 include/odp/api/spec/crypto.h | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

-- 
2.11.0

Comments

Dmitry Eremin-Solenikov May 4, 2017, 1:24 p.m. | #1
On 04.05.2017 15:55, Petri Savolainen wrote:
> Authentication capabilities list supported digest lengths

> per algorithm, but application did not have means to select which

> length is used.

> 

> Signed-off-by: Petri Savolainen <petri.savolainen@linaro.org>


Both patches:

Reviewed-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>


> ---

>  include/odp/api/spec/crypto.h | 8 +++++++-

>  1 file changed, 7 insertions(+), 1 deletion(-)

> 

> diff --git a/include/odp/api/spec/crypto.h b/include/odp/api/spec/crypto.h

> index 181c0cc4..76977204 100644

> --- a/include/odp/api/spec/crypto.h

> +++ b/include/odp/api/spec/crypto.h

> @@ -299,10 +299,16 @@ typedef struct odp_crypto_session_param_t {

>  

>  	/** Authentication key

>  	 *

> -	 *  Use odp_crypto_auth_capa() for supported digest and key lengths.

> +	 *  Use odp_crypto_auth_capa() for supported key lengths.

>  	 */

>  	odp_crypto_key_t auth_key;

>  

> +	/** Authentication digest length in bytes

> +	 *

> +	 *  Use odp_crypto_auth_capa() for supported digest lengths.

> +	 */

> +	uint32_t auth_digest_len;

> +

>  	/** Async mode completion event queue

>  	 *

>  	 *  When odp_crypto_operation() is asynchronous, the completion queue is

> 



-- 
With best wishes
Dmitry
Maxim Uvarov May 4, 2017, 7:19 p.m. | #2
Merged,
Maxim.

On 05/04/17 16:24, Dmitry Eremin-Solenikov wrote:
> On 04.05.2017 15:55, Petri Savolainen wrote:

>> Authentication capabilities list supported digest lengths

>> per algorithm, but application did not have means to select which

>> length is used.

>>

>> Signed-off-by: Petri Savolainen <petri.savolainen@linaro.org>

> 

> Both patches:

> 

> Reviewed-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

> 

>> ---

>>  include/odp/api/spec/crypto.h | 8 +++++++-

>>  1 file changed, 7 insertions(+), 1 deletion(-)

>>

>> diff --git a/include/odp/api/spec/crypto.h b/include/odp/api/spec/crypto.h

>> index 181c0cc4..76977204 100644

>> --- a/include/odp/api/spec/crypto.h

>> +++ b/include/odp/api/spec/crypto.h

>> @@ -299,10 +299,16 @@ typedef struct odp_crypto_session_param_t {

>>  

>>  	/** Authentication key

>>  	 *

>> -	 *  Use odp_crypto_auth_capa() for supported digest and key lengths.

>> +	 *  Use odp_crypto_auth_capa() for supported key lengths.

>>  	 */

>>  	odp_crypto_key_t auth_key;

>>  

>> +	/** Authentication digest length in bytes

>> +	 *

>> +	 *  Use odp_crypto_auth_capa() for supported digest lengths.

>> +	 */

>> +	uint32_t auth_digest_len;

>> +

>>  	/** Async mode completion event queue

>>  	 *

>>  	 *  When odp_crypto_operation() is asynchronous, the completion queue is

>>

> 

>

Patch hide | download patch | download mbox

diff --git a/include/odp/api/spec/crypto.h b/include/odp/api/spec/crypto.h
index 181c0cc4..76977204 100644
--- a/include/odp/api/spec/crypto.h
+++ b/include/odp/api/spec/crypto.h
@@ -299,10 +299,16 @@  typedef struct odp_crypto_session_param_t {
 
 	/** Authentication key
 	 *
-	 *  Use odp_crypto_auth_capa() for supported digest and key lengths.
+	 *  Use odp_crypto_auth_capa() for supported key lengths.
 	 */
 	odp_crypto_key_t auth_key;
 
+	/** Authentication digest length in bytes
+	 *
+	 *  Use odp_crypto_auth_capa() for supported digest lengths.
+	 */
+	uint32_t auth_digest_len;
+
 	/** Async mode completion event queue
 	 *
 	 *  When odp_crypto_operation() is asynchronous, the completion queue is