From patchwork Thu May 4 20:52:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 98572 Delivered-To: patch@linaro.org Received: by 10.140.89.200 with SMTP id v66csp806360qgd; Thu, 4 May 2017 13:52:24 -0700 (PDT) X-Received: by 10.84.131.34 with SMTP id 31mr53318059pld.120.1493931144159; Thu, 04 May 2017 13:52:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1493931144; cv=none; d=google.com; s=arc-20160816; b=l74ngCavDGJ2rezmRO8THYUxXPWq9Twmwvik5iQOAKf7A7csnpn5mR5jhrUfH7s14Q HmhhKqP6YRjsrQGvuVeXztN3QcqbZPcHmzfmRaNXwabz8dvMDqawhWABL86tli/Q4m3j HMu3xDlywC5kxj7aUqEtwJRnmatGjGhZJ7bSO3sHIxaocJxV5MTrQCYr7MeEXrtIyH4X JcHbSG35EWwDwn49vK8ngXi8T4i5KujD7BWhGsTMNoD0ui16vWpme8avwh3RbSw/nOoK 1ZdIXL1KO+irSgY29/Wvi0To7ye9RTLjD4l2ctDu291ZJSMiaCM2fx2i46nyQ3/TivAO TG4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=lK6W2N9bQLpq0NXDWClr2ztiJ8zD0qZJqgsdSrjzIpY=; b=kczSxk9fvG0IEm0beWvxB2wb7hocj8xpD2aQ4JXlJHxPCwS+tMAUedhAmTh1IoWQ7P 1cMPlSNsesP7lylei/dpHvIOlD/EMJfxkN2xN3wgCPe/csnHBKiBwqDJFHEvRTneUp/Y 5tVtUWOqFOt6sKmBA0797qFXMO5y/L8LEYfxlHm89OAsIHip1XZAWhsvygpRZnu2mIGT ew6rddCJiSGBvcfGYE+sqR0EPaWSowxPXQ39KJl1U8PPdrEZdTGDgzqdwlu9meJTz3a6 AkWo9DgqMwrk0VkrHMUIeyD1gAF6bINPN6VSxO8eGZHbjUTmVwTYoeuU/xI2ibIER263 HLjA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x7si3136031pls.89.2017.05.04.13.52.23; Thu, 04 May 2017 13:52:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751326AbdEDUwX (ORCPT + 6 others); Thu, 4 May 2017 16:52:23 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:53041 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751228AbdEDUwV (ORCPT ); Thu, 4 May 2017 16:52:21 -0400 Received: from wuerfel.lan ([78.42.17.5]) by mrelayeu.kundenserver.de (mreue001 [212.227.15.129]) with ESMTPA (Nemesis) id 0Lq1ku-1djp9m1maW-00dlB3; Thu, 04 May 2017 22:52:18 +0200 From: Arnd Bergmann To: gregkh@linuxfoundation.org Cc: stable@vger.kernel.org, Arnd Bergmann Subject: [PATCH 05/13] [3.18-stable] staging: bcm: add 32-bit host dependency Date: Thu, 4 May 2017 22:52:01 +0200 Message-Id: <20170504205209.498721-6-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170504205209.498721-1-arnd@arndb.de> References: <20170504205209.498721-1-arnd@arndb.de> X-Provags-ID: V03:K0:R2zx4k4rvAa2mnm485RFD58gzmtUFG5eWMyN/Oh6jRNBW+JHpbE 3KoE8WyGm7MYWCRth77ee7sTur4cfWrAz+KMInD56jUFFXwOEeB34uQPIke+R3bBJgEoSEj 86YxO+gJx2V8HWLMC4yRkfBeiQBz6jDkjZ4oO/jnW9CYUSHez/Vg+BjUjgCpsNZeBIevzJ+ EnPY7Dzt8efZeaS1NIASw== X-UI-Out-Filterresults: notjunk:1; V01:K0:fA9Me6Ojg9s=:0rIW09EwFeCYIAZEOFt78z 83HwTuqqlyBTJtfsUtVcRejUG6QTWAbaxD3RkTRzZXuyDYUsDDsZoq0+XWtbA+pgCYWdAZ2Vf mMWK4lYbASBJdndol7jn0g5jpBaU4aYrlUKcbO6syLhYHZ85XqEQuGwBau2BWTLxkv2EzwSjH f80C9cAHP7tvVWVFqgXh4SPVACjHSMlN2RAiK36bWTQiz5veX/oFhRPGu59CjzOwYb1dNW/wj hEhikLhJFItDnBtbeKo69YAIfHMaQdJUrvum5Y6WV7iPbrTwsouobz89Hss+437vxgPf+OmBA 7uCL9CcK2MizjzndiMmjnTZRSJyD5tW73m7q18BYnjlYarEG2VMrr6gFhrYGPnIwFmXzdSLW1 WgePBADRt3wp0X2thBk44yNys1h/CrIAExmWwhh3qEWBMdIP5mwq+biATPOo3R/k2RTeNPK39 YIS0vP22mKSK0pbqS6rdWc6+/aULUY11c5iruw95IuBb+lKL91TQH0+NVvJ3HP9/lAKUcxFxh 82C3q0qgR5QOliIzrKWKY8kar8AQQ97rF8dexPs82SAD8NH28VfNA3FigFHu8V5+0HcyYSpQn UXf0VB2HsBBLb7iLD5XHWfmuN6Z/FSXVvEUiYeVCtlu6HHE4SlucwLo+KXHhPtgaa2tjtME39 ZLn/u+Uzj+NqNbijKYcjLCtlK8rWhbGV2Vrl8CwwEXfncru1q0FCyCH5D75p/KZyKVA8= Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org The driver uses a 32-bit variable to store a pointer, causing a couple of warnings: ../drivers/staging/bcm/CmHost.c: In function 'StoreCmControlResponseMessage': ../drivers/staging/bcm/CmHost.c:1503:3: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] (struct bcm_connect_mgr_params *) ntohl( ^ ../drivers/staging/bcm/CmHost.c:1546:3: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] (struct bcm_connect_mgr_params *) ntohl( ^ ../drivers/staging/bcm/CmHost.c:1564:3: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] (struct bcm_connect_mgr_params *) ntohl( I fixed other warnings in an earlier commit 9f1c75ac2dba ("staging/bcm: fix most build warnings"), but couldn't figure out what was the intended behavior on 64-bit machines here. The driver was removed in linux-3.19, commit d09e9b160fc1 ("staging: bcm: remove driver") which explains that it never worked on 64-bit machines. This adds a Kconfig dependency instead to prevent it from being built in the known broken configuration. This workaround applies to v2.6.37 or higher. Fixes: f8942e07a3db ("staging: Beeceem USB Wimax driver") Signed-off-by: Arnd Bergmann --- drivers/staging/bcm/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.9.0 diff --git a/drivers/staging/bcm/Kconfig b/drivers/staging/bcm/Kconfig index 8acf4b24a7c9..94e04701e008 100644 --- a/drivers/staging/bcm/Kconfig +++ b/drivers/staging/bcm/Kconfig @@ -1,6 +1,7 @@ config BCM_WIMAX tristate "Beceem BCS200/BCS220-3 and BCSM250 wimax support" depends on USB && NET + depends on !64BIT help This is an experimental driver for the Beceem WIMAX chipset used by Sprint 4G.