From patchwork Fri May 5 10:38:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 98608 Delivered-To: patch@linaro.org Received: by 10.140.96.100 with SMTP id j91csp49264qge; Fri, 5 May 2017 03:38:12 -0700 (PDT) X-Received: by 10.55.24.9 with SMTP id j9mr11212606qkh.25.1493980692204; Fri, 05 May 2017 03:38:12 -0700 (PDT) Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id z93si4175657qtc.212.2017.05.05.03.38.11 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 05 May 2017 03:38:12 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:46164 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6acj-0001m4-P1 for patch@linaro.org; Fri, 05 May 2017 06:38:09 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52557) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6acO-0001kR-RU for qemu-devel@nongnu.org; Fri, 05 May 2017 06:37:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d6acM-0006hc-B4 for qemu-devel@nongnu.org; Fri, 05 May 2017 06:37:48 -0400 Received: from mail-wm0-x235.google.com ([2a00:1450:400c:c09::235]:33998) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d6acM-0006h4-47 for qemu-devel@nongnu.org; Fri, 05 May 2017 06:37:46 -0400 Received: by mail-wm0-x235.google.com with SMTP id u65so1973321wmu.1 for ; Fri, 05 May 2017 03:37:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jLILibzHXJUUa8wxesL+Eva8CzOGXRv70HjSijvpmwc=; b=bKlf/OUNgO+NtQBWowsCMLE3usthcDXyxxMvRkNmDCB+bKFZEnQAuyPQzuUZOXjfHL 4/eix6QtKK5LxRvauORqdRjC0KkzMyCRSj977CKxFwDZ3blQrfQ4eBr3lu+l1tEcjGdZ hFtW9y9/7OFMBAq1Zai+SZZps/5plBANbgTaE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jLILibzHXJUUa8wxesL+Eva8CzOGXRv70HjSijvpmwc=; b=ZQkm8nNCy0OXGR8OLPmtbkLH4CCzje4adYYetH2J/L51n34eRjmuMAilK584dS85e7 Hap7GAbs7QYPWltDGdx0YkzyPRBJP4YhHuKp66zugEaFpaqljBNziCTe61xR1Dw4e6DA g3ISDDkiO1SUOo7OhZ3B99THLvcgs9G+cm4Nq6vnyQnI2t8pwdL7bB9c3Vw0wAW9Ci6H Izji8U0aVzLio9L8zwmvQUb8ZcZIOEYN7/d4RMDncT4YSgREAXi7+cWY0Wccvh/OWQcU pg4H+43obIATw+/tRuYia+X8xBJBOoh9i9ZyUm8uk4Fvo5SZ6wxEmdB5w6SjbckIumFa XTyg== X-Gm-Message-State: AN3rC/4yMe1ucq7ABtKP+Lu3CUKyIeWlH/U1VoUZf8/GiBEMOdc2tsnz zwZ8CQjjsZ1mqFo4 X-Received: by 10.28.169.198 with SMTP id s189mr4797589wme.91.1493980663450; Fri, 05 May 2017 03:37:43 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id z14sm1607896wmz.2.2017.05.05.03.37.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 May 2017 03:37:41 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id BA6C93E0198; Fri, 5 May 2017 11:38:22 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: pbonzini@redhat.com, boost.lists@gmail.com, pavel.dovgaluk@ispras.ru Date: Fri, 5 May 2017 11:38:14 +0100 Message-Id: <20170505103822.20641-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170505103822.20641-1-alex.bennee@linaro.org> References: <20170505103822.20641-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::235 Subject: [Qemu-devel] [RFC PATCH v1 1/9] target/arm/arm-powertctl: drop BQL assertions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , cota@braap.org, =?utf-8?q?Al?= =?utf-8?q?ex_Benn=C3=A9e?= , qemu-devel@nongnu.org, "open list:ARM" Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The powerctl code is run in the context of the vCPU changing power state. It does not need the BQL to protect its changes. Signed-off-by: Alex Bennée --- target/arm/arm-powerctl.c | 8 -------- 1 file changed, 8 deletions(-) -- 2.11.0 diff --git a/target/arm/arm-powerctl.c b/target/arm/arm-powerctl.c index 25207cb850..9661a59dad 100644 --- a/target/arm/arm-powerctl.c +++ b/target/arm/arm-powerctl.c @@ -124,7 +124,6 @@ static void arm_set_cpu_on_async_work(CPUState *target_cpu_state, g_free(info); /* Finally set the power status */ - assert(qemu_mutex_iothread_locked()); target_cpu->power_state = PSCI_ON; } @@ -135,8 +134,6 @@ int arm_set_cpu_on(uint64_t cpuid, uint64_t entry, uint64_t context_id, ARMCPU *target_cpu; struct CpuOnInfo *info; - assert(qemu_mutex_iothread_locked()); - DPRINTF("cpu %" PRId64 " (EL %d, %s) @ 0x%" PRIx64 " with R0 = 0x%" PRIx64 "\n", cpuid, target_el, target_aa64 ? "aarch64" : "aarch32", entry, context_id); @@ -227,7 +224,6 @@ static void arm_set_cpu_off_async_work(CPUState *target_cpu_state, { ARMCPU *target_cpu = ARM_CPU(target_cpu_state); - assert(qemu_mutex_iothread_locked()); target_cpu->power_state = PSCI_OFF; target_cpu_state->halted = 1; target_cpu_state->exception_index = EXCP_HLT; @@ -238,8 +234,6 @@ int arm_set_cpu_off(uint64_t cpuid) CPUState *target_cpu_state; ARMCPU *target_cpu; - assert(qemu_mutex_iothread_locked()); - DPRINTF("cpu %" PRId64 "\n", cpuid); /* change to the cpu we are powering up */ @@ -274,8 +268,6 @@ int arm_reset_cpu(uint64_t cpuid) CPUState *target_cpu_state; ARMCPU *target_cpu; - assert(qemu_mutex_iothread_locked()); - DPRINTF("cpu %" PRId64 "\n", cpuid); /* change to the cpu we are resetting */