[6/9,3.18-stable] scsi: advansys: remove #warning message

Message ID 20170505115725.1424772-7-arnd@arndb.de
State Superseded
Headers show
Series
  • fixes for all remaining known warnings
Related show

Commit Message

Arnd Bergmann May 5, 2017, 11:57 a.m.
The advansys driver was converted to the proper DMA API in linux-4.2, but
the 3.18-stable kernel still warns about this:

drivers/scsi/advansys.c:71:2: warning: #warning this driver is still not properly converted to the DMA API [-Wcpp]

The warning clearly is not helpful in 3.18 any more, it just clutters up
the build log. This removes the warning instead, and clarifies the
comment above it.

Cc: Hannes Reinecke <hare@suse.de>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/scsi/advansys.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

-- 
2.9.0

Comments

Greg Kroah-Hartman May 5, 2017, 5:43 p.m. | #1
On Fri, May 05, 2017 at 01:57:22PM +0200, Arnd Bergmann wrote:
> The advansys driver was converted to the proper DMA API in linux-4.2, but

> the 3.18-stable kernel still warns about this:

> 

> drivers/scsi/advansys.c:71:2: warning: #warning this driver is still not properly converted to the DMA API [-Wcpp]

> 

> The warning clearly is not helpful in 3.18 any more, it just clutters up

> the build log. This removes the warning instead, and clarifies the

> comment above it.


I already did this one as well, now my local builds are down to 0
warnings :)

But your patch is nicer, I'll use it instead...

thanks,

greg k-h

Patch

diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 43761c1c46f0..620b04b7c13d 100644
--- a/drivers/scsi/advansys.c
+++ b/drivers/scsi/advansys.c
@@ -49,7 +49,7 @@ 
 #include <scsi/scsi.h>
 #include <scsi/scsi_host.h>
 
-/* FIXME:
+/* Fixed in linux-4.2, not backported to 3.18:
  *
  *  1. Although all of the necessary command mapping places have the
  *     appropriate dma_map.. APIs, the driver still processes its internal
@@ -68,7 +68,6 @@ 
  *  7. advansys_info is not safe against multiple simultaneous callers
  *  8. Add module_param to override ISA/VLB ioport array
  */
-#warning this driver is still not properly converted to the DMA API
 
 /* Enable driver /proc statistics. */
 #define ADVANSYS_STATS