From patchwork Fri May 5 19:47:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 98692 Delivered-To: patch@linaro.org Received: by 10.140.96.100 with SMTP id j91csp292853qge; Fri, 5 May 2017 12:48:44 -0700 (PDT) X-Received: by 10.98.13.220 with SMTP id 89mr5266066pfn.112.1494013724338; Fri, 05 May 2017 12:48:44 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n5si2698005pgk.367.2017.05.05.12.48.44; Fri, 05 May 2017 12:48:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755682AbdEETsh (ORCPT + 6 others); Fri, 5 May 2017 15:48:37 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:63669 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754515AbdEETsb (ORCPT ); Fri, 5 May 2017 15:48:31 -0400 Received: from wuerfel.lan ([78.42.17.5]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.129]) with ESMTPA (Nemesis) id 0LvtPB-1e7Vx50AzF-017kfI; Fri, 05 May 2017 21:48:30 +0200 From: Arnd Bergmann To: Ben Hutchings Cc: stable@vger.kernel.org, Arnd Bergmann Subject: [PATCH 3.16-stable 63/87] staging: bcm: add 32-bit host dependency Date: Fri, 5 May 2017 21:47:21 +0200 Message-Id: <20170505194745.3627137-64-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170505194745.3627137-1-arnd@arndb.de> References: <20170505194745.3627137-1-arnd@arndb.de> X-Provags-ID: V03:K0:6whl+1QCJPNzT0K5BHnQwK/Q1DBXIRIrmcQb+NGZgnJC7vPfy98 gyZDKZQUkTRkmvHmrwMANoFc8e9/lGIVdSx+VYr545iCOMSO8apUK2m7YL0S23L7SAX1wwF 5U63wjzssA/tRZhD/Q5qg8XvqBIXLWqpHkUBbcxDhjWeVX8Kad2Ujt8T4l05Am/OSpuvaBj XSnpDogYBYWIzsIEaMtxw== X-UI-Out-Filterresults: notjunk:1; V01:K0:79M/3E0A648=:26LEoFs0/Hj/wVkd1zsghF bKDUXj4v5tLVkqoJYNmGB0AGhLOkyO/KY+GnT9aIcDSR82bfPNp3nZdS6/iuOd+7zt12iJ9Im vRXm5YahPkrswiKbkDKmGxe6jaOqULdNlxUJqpviQRsLUjHTLUPZ/ruy+nToURiyLZK1HzkGv xi9kkBXUwTu65oyN3YY+VSIvo6JmmtBDvoXtxqNSXJkJPAxTy5gsLxGFPlf5zQOnoZk8oZ6Tb Fqev8UNsshBQ87oLxd1ZvwUqXax1ZI4adXl+jl0r6gjY7+jRopNzqp60UKqvNfEWm43DarRrl bEaLvYsgwFQJjdCVzz5XOBnDG3trW3kFS30CMNYICJW851tK6OgZ1kXVVbuuO9XAAgfNHoXJj PRHPtt8fySWpzb3q4mn4VyTQypN2eCutyKk3WM/9paAa5FBEVCPbGnLWZOIBdDIdRzvBnotFZ Z/cu/Rs5xH56rN7uE+PnWZ+p3oTlbyJL6YUZCY0PfWP5hGQB8rK4wHPyCDL415DHdVx8tFNmh 6wlterCCPB/WCPGQxvSDFqI4gfKWWL51bBgqmUbINA43ko2SCwJcQyUueGXrCSpqiZ66gzOWY P/Klk0gCBJPAquKPqr+7xoJcpY0+i6BlzL7sypTEYXpaL1zxXarTFklNOumVIgJk6LWuaIa7v dNwTTv0U6LN2lbAcQrQZxJMCxIpTv2AP1OGtOO3Y3VS6FEQMGYYAF6jvn5OD1wbqOkTE= Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org The driver uses a 32-bit variable to store a pointer, causing a couple of warnings: ../drivers/staging/bcm/CmHost.c: In function 'StoreCmControlResponseMessage': ../drivers/staging/bcm/CmHost.c:1503:3: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] (struct bcm_connect_mgr_params *) ntohl( ^ ../drivers/staging/bcm/CmHost.c:1546:3: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] (struct bcm_connect_mgr_params *) ntohl( ^ ../drivers/staging/bcm/CmHost.c:1564:3: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] (struct bcm_connect_mgr_params *) ntohl( I fixed other warnings in an earlier commit 9f1c75ac2dba ("staging/bcm: fix most build warnings"), but couldn't figure out what was the intended behavior on 64-bit machines here. The driver was removed in linux-3.19, commit d09e9b160fc1 ("staging: bcm: remove driver") which explains that it never worked on 64-bit machines. This adds a Kconfig dependency instead to prevent it from being built in the known broken configuration. This workaround applies to v2.6.37 or higher. Fixes: f8942e07a3db ("staging: Beeceem USB Wimax driver") Signed-off-by: Arnd Bergmann --- drivers/staging/bcm/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.9.0 diff --git a/drivers/staging/bcm/Kconfig b/drivers/staging/bcm/Kconfig index 8acf4b24a7c9..94e04701e008 100644 --- a/drivers/staging/bcm/Kconfig +++ b/drivers/staging/bcm/Kconfig @@ -1,6 +1,7 @@ config BCM_WIMAX tristate "Beceem BCS200/BCS220-3 and BCSM250 wimax support" depends on USB && NET + depends on !64BIT help This is an experimental driver for the Beceem WIMAX chipset used by Sprint 4G.