From patchwork Fri May 5 19:47:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 98710 Delivered-To: patch@linaro.org Received: by 10.140.96.100 with SMTP id j91csp293002qge; Fri, 5 May 2017 12:49:03 -0700 (PDT) X-Received: by 10.98.214.90 with SMTP id r87mr7810260pfg.204.1494013743406; Fri, 05 May 2017 12:49:03 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n5si2698005pgk.367.2017.05.05.12.49.03; Fri, 05 May 2017 12:49:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755960AbdEETs6 (ORCPT + 6 others); Fri, 5 May 2017 15:48:58 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:54732 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755338AbdEETsn (ORCPT ); Fri, 5 May 2017 15:48:43 -0400 Received: from wuerfel.lan ([78.42.17.5]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.129]) with ESMTPA (Nemesis) id 0Lq1p2-1dkAhg29IW-00doA1; Fri, 05 May 2017 21:48:28 +0200 From: Arnd Bergmann To: Ben Hutchings Cc: stable@vger.kernel.org, Arnd Bergmann , Kalle Valo Subject: [PATCH 3.16-stable 58/87] brcmfmac: avoid gcc-5.1 warning Date: Fri, 5 May 2017 21:47:16 +0200 Message-Id: <20170505194745.3627137-59-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170505194745.3627137-1-arnd@arndb.de> References: <20170505194745.3627137-1-arnd@arndb.de> X-Provags-ID: V03:K0:ptz5ryBb02mp5b7lciuq1ENHmXcZffMfVRt9+VQr7N2lPva6rCQ K7YOa/EMrHBA2ctetZD+W+wzDPPxqyB5NnCyaXFjWvXeWHNQQdDYe6px+gtyIDVuwzCffwF KsQzza/scwBuEfrgVkbqgClitc9NWeP8kap2cIwWDRvOfl847RO07KUxOBnDcwQ5TduDiQ4 xH51ge89SkNAq7iIdfxlQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:Xr72FbDJXso=:KXy54xvdPl7/OoXwHvQ79H ze4NMZA5mYn3lLSPtiixBSPkawT+7kmFbMuvWcLw6mnJBfS6dwIA10iIYTcX/L0fi2TdLs8hE 6NGMi93J91T1sU4Ued5AKOK+kUzED5GEjX1tiZR0Sogy5FfUuV+6oj0yggM54XqT4LHRxBkw7 IyQP2TQAjmVRkBwdMiapv7R7n0SZZPPkwz1Pt19hHWQqQmkvwkNKfA1FHa2I3qteDMglmuJK+ vlG99ZjmZfE0XkVXH3+fC9Ir2ukNNmMwLGTe4/QWGqAort8kiHaaTp2heJ74PYMXZ6KnRkYBV 4nphwP04QnA3+IaNGUDuFNnyOIUf44c0ppgp3/o55/X/O+FwMEUcFvi4IZX499Mam40cX7h5I GdTg0lPyZGrjF9G2AFFOgVOLCZWfXAkTipv0iTW1DrzBvCRLnDsutp6L5wDRfrKZZacE1xL13 Y5zpIwK4CpkDp8fedwrXml44P1wjAz4+/Tdld5ZsIKoMqGqePCRBmEf2t3orceNCCsNOrYYfs iXHEn4QHiDcUtrNc1G1G7jMdZ98dKkE/yVd4w3CneIUqWAUQBy1R89rX5WCmyEWcTkICkTDqD 7V7CscvF4iP+fRiXOwH2P2cD4fFVTJsYuwUqwYwAx7gzwLf4SQ14bj89VR+icBrkLatnGho8x RKsjeGvHXOlK6TdmONVQ6soRpNugxti8x9CYYemtcjHblxeIpd0Alq7llLXEN0u63jqI= Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Commit 85773e14ccccddaa9ee4b5bc08b3cf9d62d2c1a8 upstream. gcc-5.0 gained a new warning in the fwsignal portion of the brcmfmac driver: drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c: In function 'brcmf_fws_txs_process': drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c:1478:8: warning: 'skb' may be used uninitialized in this function [-Wmaybe-uninitialized] This is a false positive, and marking the brcmf_fws_hanger_poppkt function as 'static inline' makes the warning go away. I have checked the object file output and while a little code gets moved around, the size of the binary remains identical. Signed-off-by: Arnd Bergmann Signed-off-by: Kalle Valo Signed-off-by: Arnd Bergmann --- drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0 diff --git a/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c b/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c index 699908de314a..c9b0586d7b58 100644 --- a/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c +++ b/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c @@ -607,7 +607,7 @@ static int brcmf_fws_hanger_pushpkt(struct brcmf_fws_hanger *h, return 0; } -static int brcmf_fws_hanger_poppkt(struct brcmf_fws_hanger *h, +static inline int brcmf_fws_hanger_poppkt(struct brcmf_fws_hanger *h, u32 slot_id, struct sk_buff **pktout, bool remove_item) {