From patchwork Fri May 5 19:46:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 98725 Delivered-To: patch@linaro.org Received: by 10.140.96.100 with SMTP id j91csp293451qge; Fri, 5 May 2017 12:50:09 -0700 (PDT) X-Received: by 10.84.224.66 with SMTP id a2mr31704337plt.191.1494013808932; Fri, 05 May 2017 12:50:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1494013808; cv=none; d=google.com; s=arc-20160816; b=WgKC7qC59waFONySCoueDPxnYtl2ZT4CZJMN/lqFAYcVBH79rhJA8zw2cE55gTzEX9 tsYC/aW31SRG+yRUIbMUrPn4IWEUFOHomg+4/CngzckhJEau0m+EwHBOLRD/tqY5alkk uw1EXjpM6dVRf+PXCf1GFFM0FbVB8vysbO6skxknA2K0/AP7rjMCBPIypHg5xTbe3uml Av+Lk48kneWDVIvzujNsbepBESKtJ9aSKIPA9JQbLlYV4P5YfhvOpg3EaRk/m95j80qv mnmX4DL0YzeAUiKuPciwtO+L2a7vArmTC0q/D2dq3DHSUDbXPkM9G80TZx7uR/grMMAK 5A2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=Oa71NQLlXuffHcvvpUuvPUN/N3uxCs5liIt7X1qkv2o=; b=oGbjtf0xmrZJ60CgNkdLnnXIgPnVVuqWznrxr0fZUF6++WdGR4eYPdrHuEp60PQpaP z/ZHTF8v7XsNNETZeP3S9HJv7D9wXLLIKTL9g6iLaRGl50DTd7kgrvzncrjKK8TfNu8c n8vz9oHgxD1i067aEePVFCFw6hMjF4Sow9q26diRwOO9r0nsv+OwWezpRex5RH50KjdQ 3sGTRbYIciVuSk8Cj9nVBKHPecyUR9KupzdjbzHS25FcT2LZQisVh/Wlvu1UTp+MshYJ dq4Wm3bjwiKkGIhUnIKrzEbmISIlUJObRYxmS0v2sar2OCRo0u+4H6psowd5R4wOLR5S wXFw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c5si2571475pga.119.2017.05.05.12.50.08; Fri, 05 May 2017 12:50:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755830AbdEETuH (ORCPT + 6 others); Fri, 5 May 2017 15:50:07 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:51174 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755640AbdEETsx (ORCPT ); Fri, 5 May 2017 15:48:53 -0400 Received: from wuerfel.lan ([78.42.17.5]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.129]) with ESMTPA (Nemesis) id 0MDYoX-1dGvIj1aNZ-00Gszo; Fri, 05 May 2017 21:48:16 +0200 From: Arnd Bergmann To: Ben Hutchings Cc: stable@vger.kernel.org, Tim Gardner , Jayamohan Kallickal , Minh Tran , John Soni Jose , "James E.J. Bottomley" , "Martin K . Petersen" , Arnd Bergmann Subject: [PATCH 3.16-stable 38/87] be2iscsi: Fix bogus WARN_ON length check Date: Fri, 5 May 2017 21:46:56 +0200 Message-Id: <20170505194745.3627137-39-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170505194745.3627137-1-arnd@arndb.de> References: <20170505194745.3627137-1-arnd@arndb.de> X-Provags-ID: V03:K0:yvGX7i8doaS1uDPWSoyhF5cxwOTBXxwLUcW2wE9Jh8EGMm9e/F/ EXWrnPRMt+ye41OhamEpLZDAgGIg52RbnwgA/vtlWKQ/6y7CU2ZKzGqp0BfigfwhIfkn+KX nRIHeeeAhEVmwKx9B1UztLn2LXEfF5Z+SqpVMYkyPSqPZw30plC7FtCzv1NGnrHfPp3rK18 uSkKPtrd8cg5Lvu+rfPjw== X-UI-Out-Filterresults: notjunk:1; V01:K0:Awkm6LiyEG4=:zEFL45HK0sX9uULzPqPzx8 jyd2WbrwShESGbpuhToicjZHxr1yZv51yukVh+hK2mkuskLCdFry/GG2cSuWJhv2RO8U6USTF xkCWYl3WCUohoKoN8o3ieBGHtDAxhkgunv1DM+amMixnz72XS9QuvweYh1XJCwaZneDrw1hBC TP8/nV08sIKYsLpbUGL2jI8vib765eT+igVH/Qtlq4DhR0FoP1b4KZWYwpoI79uawgIKIOa47 B3CHmGFeA9m0W5FGVEJk9khvVmlhZ+3r592zK4HBZUg8H0nTA5k4+V9pZAuQF1dRZ2TLxJYlQ cQNV9x1mbrKXB8cN76hQuIsNg7cqBmB7DQROWQlHB4y9sN/Diac82xi+FogKivPCXhst8XlGn 4IfwAG1B/RHzzLJ4Z3w9My3y6sLIbJ8Dw+sVanHVIFiuJ/YvBOco0CZ0N6zPRkDnUjlxpkDrx IkYLBDQM+9aSwH/iO9S/BHi9hGmGwK9Po2VX4XY0ykyTYoq9XKUT10e1z9bYknhK8hudputwl CBVSXf9FpUeW85hloi9pHVhxfLS/nyjefn7Zk9uEJnJBInHY3wHlOQ4l4r433Q9ucRMk2+WSB j8QAxhtW4vqden5FAAIlWhnHwT2yZAQVoh8e3LjhURHbsBmWfkrPXHwmoXTKCK3imFeHywpiI DG+n0yvFXQDUKvJDwnN9+vwL9UnwoI7juqIbM76igeLVNNH7/EGgOZSuqa49cSFphgJQ= Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Tim Gardner Commit ff5260af23815ff79dffa9b4a3cca1260692b094 upstream. drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous': drivers/scsi/be2iscsi/be_main.c:3187:18: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] WARN_ON(!length > 0); gcc version 5.2.1 Signed-off-by: Tim Gardner Cc: Jayamohan Kallickal Cc: Minh Tran Cc: John Soni Jose Cc: "James E.J. Bottomley" Reported-by: Joel Stanley Reviewed-by: Manoj Kumar Signed-off-by: Martin K. Petersen Signed-off-by: Arnd Bergmann --- drivers/scsi/be2iscsi/be_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0 diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index 1075b7001e4a..d5068e43cfc5 100644 --- a/drivers/scsi/be2iscsi/be_main.c +++ b/drivers/scsi/be2iscsi/be_main.c @@ -3152,7 +3152,7 @@ be_sgl_create_contiguous(void *virtual_address, { WARN_ON(!virtual_address); WARN_ON(!physical_address); - WARN_ON(!length > 0); + WARN_ON(!length); WARN_ON(!sgl); sgl->va = virtual_address;