From patchwork Fri May 5 19:46:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 98734 Delivered-To: patch@linaro.org Received: by 10.140.96.100 with SMTP id j91csp293642qge; Fri, 5 May 2017 12:50:39 -0700 (PDT) X-Received: by 10.98.75.6 with SMTP id y6mr12274720pfa.157.1494013726401; Fri, 05 May 2017 12:48:46 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n5si2698005pgk.367.2017.05.05.12.48.46; Fri, 05 May 2017 12:48:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755786AbdEETsl (ORCPT + 6 others); Fri, 5 May 2017 15:48:41 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:60808 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755606AbdEETsd (ORCPT ); Fri, 5 May 2017 15:48:33 -0400 Received: from wuerfel.lan ([78.42.17.5]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.129]) with ESMTPA (Nemesis) id 0MWKgT-1dZYeB0UKf-00XJv2; Fri, 05 May 2017 21:48:18 +0200 From: Arnd Bergmann To: Ben Hutchings Cc: stable@vger.kernel.org, Luis de Bethencourt , "Martin K . Petersen" , Arnd Bergmann Subject: [PATCH 3.16-stable 39/87] mvsas: fix misleading indentation Date: Fri, 5 May 2017 21:46:57 +0200 Message-Id: <20170505194745.3627137-40-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170505194745.3627137-1-arnd@arndb.de> References: <20170505194745.3627137-1-arnd@arndb.de> X-Provags-ID: V03:K0:pYQnk4xywGiLjjFZjMqq5CjWmosIuk4N9KzxG1MXHq91SvC4tHZ /5s1Yb97AK3BV3FYtE3qhrEDetq9TQIIDhx70f3pvMfQkwxlr4wh2gdrt99JS6Qc4z1CrRY K+DfUT8c1mo9Lkq7AP+5XbHh0P8HRsMJ24D1T2evGcpoM67RoW5a5ek7ZlLgANqgv0u0Y4P kZBBr+O+Y2U18Rkob2Bmg== X-UI-Out-Filterresults: notjunk:1; V01:K0:XsUyjGyd/kk=:UxAtz/n+fnCRkbLZk/MIBg 3LtoxOnNjtzCIMP7geMAN8/xdvATUFHtLv2gtZ1ukH4PC1WvtY351Ko92yL250OxgvT4KT+y0 gtHG4MZ2QwHSg7nZmOyo+Y8oMeAAP3P0oUp10M3W1dtjzlcKd5CmAn1ylB6rgLNodu+uy+oXp ivCvzXXA/qTY4GVZ5Vqh6MZr5NJSsa7Oee9sDO9F3UAB8pn1W5HsMs7RsoTnpCtzT/1lKFnlZ neGf06AyN0zE2KCAl3jXP8avQwmbNripzaNzG53bIq29YXFzT1uYmg9a6O3Y+AFbCz6kNDMMF 8/lhsSvTw8/wYKqvzY+esKpZ6B3Ux8Dfh+3HuIpqmXWk98qVSR+qCu/lXirCvS3dlmsR0Qd0x Ij7dvwpBrkFvksu1cW8n/4uELvK2noLkFsCqALGBnIEYCFzR8Smqs9DSBLLoqtXQhFiBfZBjN NbNpYH7sHo4jUnwIZhItSrp/qQMOPT6XfSBWaBTvBRqBWuohj2VMgpLiWaW2mJhmNG3/yeJli 6lNrx3o5sRIdgBFka994AjlueWGOERxE+GQ4ieV+6EVaXqXp7ib7ZvBDAbeXc0t6mjtEvCA23 wXu7Xs6k3CKXY7WUytbE13xDDPtXvUtVsJTIzEtBNWwr7L+6a7Up+RZJdqZ4xA8Id6sNn308f x7/gN+4ENHPKIh7b6NK1C2PPhMoIXaI9/rvtbiI+iZD+Y7KWLUttziy4LvVidlRgCftY= Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Luis de Bethencourt Commit f8fe5d3a9286263fb8aad500b91f39dda0a302eb upstream. Fix a smatch warning: drivers/scsi/mvsas/mv_sas.c:740 mvs_task_prep() warn: curly braces intended? The code is correct, the indention is misleading. When the device is not ready we want to return SAS_PHY_DOWN. But current indentation makes it look like we only do so in the else branch of if (mvi_dev). Signed-off-by: Luis de Bethencourt Reviewed-by: Johannes Thumshirn Signed-off-by: Martin K. Petersen Signed-off-by: Arnd Bergmann --- drivers/scsi/mvsas/mv_sas.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.9.0 diff --git a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c index 42b1f3318e59..eab05c5f8b0e 100644 --- a/drivers/scsi/mvsas/mv_sas.c +++ b/drivers/scsi/mvsas/mv_sas.c @@ -737,8 +737,8 @@ static int mvs_task_prep(struct sas_task *task, struct mvs_info *mvi, int is_tmf mv_dprintk("device %016llx not ready.\n", SAS_ADDR(dev->sas_addr)); - rc = SAS_PHY_DOWN; - return rc; + rc = SAS_PHY_DOWN; + return rc; } tei.port = dev->port->lldd_port; if (tei.port && !tei.port->port_attached && !tmf) {