[3.16-stable,04/14] MIPS: ip27: Disable mpt2sas driver in defconfig

Message ID 20170509100502.1358298-5-arnd@arndb.de
State New
Headers show
Series
  • [3.16-stable,01/14] staging: r8192ee: prorperly format warning message
Related show

Commit Message

Arnd Bergmann May 9, 2017, 10:04 a.m.
Similar to commit c64ebe32d3fc90c52277257d6c9fa7d589877cc2 upstream,
this fixes one more 3.16 build failure in kernelci.org that results
from a gcc bug:

drivers/scsi/mpt2sas/mpt2sas_base.c:3550:1: error: insn does not satisfy its constraints:
drivers/scsi/mpt2sas/mpt2sas_base.c:3550:1: internal compiler error: in extract_constrain_insn, at recog.c:2190

This is apparently broken in gcc-6 but fixed in gcc-7, and I cannot
reproduce the problem here. However, it is clear that ip27_defconfig
does not actually need this driver as the platform has only PCI-X but
not PCIe, and the qlge adapter in turn is PCIe-only.

The driver was originally enabled in 2010 along with lots of other
drivers.

Fixes: 59d302b342e5 ("MIPS: IP27: Make defconfig useful again.")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 arch/mips/configs/ip27_defconfig | 1 -
 1 file changed, 1 deletion(-)

-- 
2.9.0

Comments

Ben Hutchings Nov. 6, 2017, 7:26 p.m. | #1
On Tue, 2017-05-09 at 12:04 +0200, Arnd Bergmann wrote:
> Similar to commit c64ebe32d3fc90c52277257d6c9fa7d589877cc2 upstream,

> this fixes one more 3.16 build failure in kernelci.org that results

> from a gcc bug:

> 

> drivers/scsi/mpt2sas/mpt2sas_base.c:3550:1: error: insn does not satisfy its constraints:

> drivers/scsi/mpt2sas/mpt2sas_base.c:3550:1: internal compiler error: in extract_constrain_insn, at recog.c:2190

> 

> This is apparently broken in gcc-6 but fixed in gcc-7, and I cannot

> reproduce the problem here. However, it is clear that ip27_defconfig

> does not actually need this driver as the platform has only PCI-X but

> not PCIe, and the qlge adapter in turn is PCIe-only.


Then wouldn't it make sense to apply this upstream too?

Ben.

> The driver was originally enabled in 2010 along with lots of other

> drivers.

> 

> Fixes: 59d302b342e5 ("MIPS: IP27: Make defconfig useful again.")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

> ---

>  arch/mips/configs/ip27_defconfig | 1 -

>  1 file changed, 1 deletion(-)

> 

> diff --git a/arch/mips/configs/ip27_defconfig b/arch/mips/configs/ip27_defconfig

> index 7446284dd7b3..cb56ff8d0cdd 100644

> --- a/arch/mips/configs/ip27_defconfig

> +++ b/arch/mips/configs/ip27_defconfig

> @@ -129,7 +129,6 @@ CONFIG_SCSI_AIC94XX=m

>  CONFIG_SCSI_MVSAS=m

>  # CONFIG_SCSI_MVSAS_DEBUG is not set

>  CONFIG_SCSI_DPT_I2O=m

> -CONFIG_SCSI_MPT2SAS=m

>  CONFIG_LIBFC=m

>  CONFIG_SCSI_QLOGIC_1280=y

>  CONFIG_SCSI_PMCRAID=m

-- 
Ben Hutchings
It is a miracle that curiosity survives formal education. - Albert
Einstein
Arnd Bergmann Nov. 6, 2017, 8:30 p.m. | #2
On Mon, Nov 6, 2017 at 8:26 PM, Ben Hutchings <ben@decadent.org.uk> wrote:
> On Tue, 2017-05-09 at 12:04 +0200, Arnd Bergmann wrote:

>> Similar to commit c64ebe32d3fc90c52277257d6c9fa7d589877cc2 upstream,

>> this fixes one more 3.16 build failure in kernelci.org that results

>> from a gcc bug:

>>

>> drivers/scsi/mpt2sas/mpt2sas_base.c:3550:1: error: insn does not satisfy its constraints:

>> drivers/scsi/mpt2sas/mpt2sas_base.c:3550:1: internal compiler error: in extract_constrain_insn, at recog.c:2190

>>

>> This is apparently broken in gcc-6 but fixed in gcc-7, and I cannot

>> reproduce the problem here. However, it is clear that ip27_defconfig

>> does not actually need this driver as the platform has only PCI-X but

>> not PCIe, and the qlge adapter in turn is PCIe-only.

>

> Then wouldn't it make sense to apply this upstream too?


I don't think it matters much either way, it's only about building an
unused module on
a platform that probably nobody cares about. If you prefer to create a patch and
send that upstream before backporting it, feel free to add my Reported-by and
Acked-by tags.

      Arnd

Patch

diff --git a/arch/mips/configs/ip27_defconfig b/arch/mips/configs/ip27_defconfig
index 7446284dd7b3..cb56ff8d0cdd 100644
--- a/arch/mips/configs/ip27_defconfig
+++ b/arch/mips/configs/ip27_defconfig
@@ -129,7 +129,6 @@  CONFIG_SCSI_AIC94XX=m
 CONFIG_SCSI_MVSAS=m
 # CONFIG_SCSI_MVSAS_DEBUG is not set
 CONFIG_SCSI_DPT_I2O=m
-CONFIG_SCSI_MPT2SAS=m
 CONFIG_LIBFC=m
 CONFIG_SCSI_QLOGIC_1280=y
 CONFIG_SCSI_PMCRAID=m