From patchwork Tue May 9 10:04:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 98899 Delivered-To: patch@linaro.org Received: by 10.140.96.100 with SMTP id j91csp1739469qge; Tue, 9 May 2017 03:05:26 -0700 (PDT) X-Received: by 10.98.194.69 with SMTP id l66mr37182941pfg.55.1494324326448; Tue, 09 May 2017 03:05:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1494324326; cv=none; d=google.com; s=arc-20160816; b=OQE9XuAW7l9emxkn/AjNzrkUnUrK3EV8OcLEqkQyAviKbp1kduIX78g6Y8j6Ao8bLF 2Axv5QGYEYjePT9hYjeR/XffcK6VgiVE6iMJYsbWsWuCWoz1n5E3leCWE0uYz/e/qKm0 08lGsOPb+QygQMd0JhxG4lWeOtudjgfP+kmJNJLAOg4X2CSAOOaO2F5H5f/xuVNDbApi 7asO20lkxJ7M+YpwtG/m5yD1v2MbIQp6tRLyswyRUP9uH3D1NFdNoinATtXbVWfWK59d BHhT507BHTCfU9tAbrz6wASekkK96m0EitjfkkUToT82EIL/+nmO34OG6B4Usy7l0cYg L1Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=xhLCAPeg2AGAO5SaayC2wP4EmLq6PB9iFPhpl9BZVd0=; b=sCY6Ul4kAMnWEiXkbZHTj4/vY5ZruRMdu3GKo0438UWU+0nG3b/HYdmnRiUvjRUuXU 153BOKC+ZXwrI4GuLPvBiIt1gy6x5aZJRSuVDfJUU4KYfRn2zFG+RTXmNjPDJzJ39mnD Aj0wNPzPJwYo8IXSfFVn/HCVmSMmhOu6xd9RbmclFFCKCNvLYXS93layIDK0LmIFMNcN wwy4c+raWotN7qKwIFlp7Pf65w+CqpW2FdFrl+z7kVKQ3PP/AEtXjd0Gi+j27D/O1XEQ YEPjCc2NbwSnaLG1c6Lx7sbQk2Lk7RhCZ2uefu16JCpuX3pIYVnBtN/NB8cZTShOoKE2 M1Eg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h13si12805392pgn.51.2017.05.09.03.05.26; Tue, 09 May 2017 03:05:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752183AbdEIKFZ (ORCPT + 6 others); Tue, 9 May 2017 06:05:25 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:56368 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752140AbdEIKFY (ORCPT ); Tue, 9 May 2017 06:05:24 -0400 Received: from wuerfel.lan ([78.42.17.5]) by mrelayeu.kundenserver.de (mreue004 [212.227.15.129]) with ESMTPA (Nemesis) id 0M2HkO-1dzr5h0rau-00s6E8; Tue, 09 May 2017 12:05:13 +0200 From: Arnd Bergmann To: Ben Hutchings Cc: stable@vger.kernel.org, Arnd Bergmann , Lars-Peter Clausen Subject: [PATCH 3.16-stable 06/14] MIPS: jz4740: fix build error in irq.h Date: Tue, 9 May 2017 12:04:54 +0200 Message-Id: <20170509100502.1358298-7-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170509100502.1358298-1-arnd@arndb.de> References: <20170509100502.1358298-1-arnd@arndb.de> X-Provags-ID: V03:K0:7AJo1gii9CgJti19mX2yRovk6+QVYqlLxbrZDXdp5/WCEMlJTjO EYyOkMidELZQJUFgJJGFgMtOcNcvm+Es0KK5WOVNl9wVehhDVemxI61EzjAf/QWQl+3X6OO IYsA1Ywj+Xp+it8NI/nYZUmjcDEWhmodH/mJe0+xfoOxiNWmRFiidszR8r5a71OF+yHqSX4 Mxg0ycjd2n3D4a6RvGpKA== X-UI-Out-Filterresults: notjunk:1; V01:K0:vVLUEAQaB2w=:903FJ1xzlSaTGr9dKI+OTV OeXgOsuoIRpSMnqfJYNjWmmBiabKHE5ZkFpyTuHVSRYbdBr0y189vV16EzaAuilkvVhMTC+VL /7Bo6HqOrgZ2G+R69xHHw7Vf6bo4nqLr5J7tbrdHiSZ4UAYCl15hfG/oukcNGjHKLhXMF5FJA 2uim/pBcSOkFbjiP97+qoBOu/nP49xaJ7AYgTK/wiSGsb8JNUegbiIQR8g67ZMJYsb854m+lD QZPW7i/z38KDX5L0HjYHjdn+aJLxPTO+GKglVXKoIg4AkuZZxhIkmVpselR9zWdsu9FmKzRd1 dZONEcfduy3FSxyGJOhdamyASBDQlHHLtCpLw1RPIJhB2FZc4mw6O1RWJ6+5ywsfl9vgB8ObQ JkwV/R1LjRF+kxfb5l8hSubGtosB0ojHUVJDdy9jfknAzSTydSDiAJBpxPqsYoU5YJxq+i6Ry TlMpjMS3OFNoKA1DzD7L270SM3TpAZjjo9zJmXUTRJuVfMn+/HRcOnyQPS/0Nb905Cu87XVZT 8lgWKjxZ+dcD5hcKHu/Cdr1Klb6pA1uteoszjuDW83G5KJVb+hfIBH7nXkHxzlBYlijTz12yo PagKTD5x/daJbMNrYSl2Mv3qUIPIXmpJTtj55sl7voMQ5jLIKFq7esrBM/Lbknq7X35nLbpnB BB0tSHa4b4pmCWSSHTSuoDEJsYk7yDHBGIDRZt906UMnYdE12LGUR1LiSGmKJH5A4nFU= Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org kernelci found build error on the 3.16 and 3.18 stable trees that don't show up in later versions: arch/mips/jz4740/irq.h:21:38: error: 'struct irq_data' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] arch/mips/jz4740/irq.h:20:39: error: 'struct irq_data' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] include/linux/irqdesc.h:92:33: error: 'NR_IRQS' undeclared here (not in a function) arch/mips/jz4740/irq.c:91:41: error: 'JZ4740_IRQ_BASE' undeclared (first use in this function) arch/mips/jz4740/irq.c:68:6: error: conflicting types for 'jz4740_irq_resume' arch/mips/jz4740/irq.c:62:6: error: conflicting types for 'jz4740_irq_suspend' arch/mips/jz4740/irq.c:49:39: error: 'JZ4740_IRQ_BASE' undeclared (first use in this function) arch/mips/jz4740/gpio.c:47:32: error: initializer element is not constant arch/mips/jz4740/gpio.c:46:32: error: initializer element is not constant arch/mips/jz4740/gpio.c:45:32: error: initializer element is not constant arch/mips/jz4740/gpio.c:44:32: error: initializer element is not constant arch/mips/jz4740/gpio.c:447:22: error: assignment from incompatible pointer type [-Werror=incompatible-pointer-types] arch/mips/jz4740/gpio.c:446:23: error: assignment from incompatible pointer type [-Werror=incompatible-pointer-types] arch/mips/jz4740/gpio.c:427:14: error: implicit declaration of function 'JZ4740_IRQ_INTC_GPIO' [-Werror=implicit-function-declaration] arch/mips/jz4740/gpio.c:269:9: error: implicit declaration of function 'JZ4740_IRQ_GPIO' [-Werror=implicit-function-declaration] The problem seems to be caused by commit 83bc76920080 ("MIPS: JZ4740: Use generic irq chip") from linux-3.2, but only showed up in a defconfig build when qi_lb60_defconfig was added in linux-3.13 and that configuration never successfully built. The code has changed in a number of ways before 4.4, which builds fine. While I did not bisect the problem to a specific change, I found a simple fix by including the obviously missing header. Cc: Lars-Peter Clausen Signed-off-by: Arnd Bergmann --- arch/mips/jz4740/irq.h | 2 ++ 1 file changed, 2 insertions(+) -- 2.9.0 diff --git a/arch/mips/jz4740/irq.h b/arch/mips/jz4740/irq.h index 0f48720b5b63..486db78808cc 100644 --- a/arch/mips/jz4740/irq.h +++ b/arch/mips/jz4740/irq.h @@ -16,7 +16,9 @@ #define __MIPS_JZ4740_IRQ_H__ #include +#include +struct irq_data; extern void jz4740_irq_suspend(struct irq_data *data); extern void jz4740_irq_resume(struct irq_data *data);