From patchwork Tue May 9 14:42:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Amit Pundir X-Patchwork-Id: 98932 Delivered-To: patch@linaro.org Received: by 10.140.96.100 with SMTP id j91csp1857641qge; Tue, 9 May 2017 07:43:42 -0700 (PDT) X-Received: by 10.84.150.101 with SMTP id g92mr628255plg.149.1494341022320; Tue, 09 May 2017 07:43:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1494341022; cv=none; d=google.com; s=arc-20160816; b=sZFdihb3K/Wqe/JBcUqmcAWZR47nngBYfwa1G9aYFlfW5ZqpNhtSPW9Dkb73aClEvc aHIjpyJKXiTE6aaLWgIXO/TNBTTAhgLu6bmWdZ1bfYEOBRgswhJPeCbJ+ReBffiQFbPQ oqARwBPYi1XoMSwZtE2SY0H2VK2WWyDZj9aNyCb0TdDxlFjWGP8wi7RrgTbz5PVnnQmR JD1BESQepU4lgfBMX78BhN4Q4PgtGGQwFMXpa1E6sCk+83KzkKVqq2rCaAsoM09G/iDt ntHA98DhXBVWTs9UpYoZSlz/JtmbWFHZyHl91PU4NIYVAYdIo+Eb3mbAbcLPOvsxctUw 56Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=bosPbjRiJA5iHgoQSA5by+AXFXeagQujq6EU+87HqDo=; b=XSO9hdhgvn2JniCGksVIecq9s6NYJYc7tjb0wQcpT2yCBqgHbVdbFz9NNXKHLyXoU+ ob3pjB/rmiewvtx1FVidDDpZEyGq+9kdbltecvuQ60KIkANwcO2UZ2qrSRJSdtncApAG mEKURgeL4gqmaXOrGfDBUER9ZnelGfOhnPd0adgjMhhXh7Db6HmnozTI3qLKAt4PqsMj Cec/1U6PlFyOnFgXZ9zz2nx9AAOKmncWf1vTQQtnF5VaO71dwHxPrHP3sIQLrzDsatzP lb4za1YD50JJcaOj4gmdV9FE5aLjUCBvnkBuya3VEU1Pm9IHLaTGCFLjxY08pNctU5U8 F9EA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h2si99892pli.322.2017.05.09.07.43.42; Tue, 09 May 2017 07:43:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754291AbdEIOnj (ORCPT + 6 others); Tue, 9 May 2017 10:43:39 -0400 Received: from mail-pg0-f44.google.com ([74.125.83.44]:35983 "EHLO mail-pg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754270AbdEIOni (ORCPT ); Tue, 9 May 2017 10:43:38 -0400 Received: by mail-pg0-f44.google.com with SMTP id 64so733591pgb.3 for ; Tue, 09 May 2017 07:43:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bosPbjRiJA5iHgoQSA5by+AXFXeagQujq6EU+87HqDo=; b=id3u0Q+Mj6hBf+z2pz+0XRe5nUsr4MZJeAn6mAf3pKzYOVR2hMXDZJ1zvxA3qvO+gx UuRYPqO+LmpLXeDW7GEE033V3LHgFYB6Kuvdaxsdw2WsNQ2FmtFubS7TozKdI3PcU/R6 jEeDOdKNhf2jwlrutUd7Boyza5n+ylnllsqpw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bosPbjRiJA5iHgoQSA5by+AXFXeagQujq6EU+87HqDo=; b=UCOta8XBB9DtKBz2hl+PJ0sshOZz0e/MGW4CITV5LSjbUmy6SdnKlwxrf/SSK5fuCN FleytSFb8QlaPr8YcWKxBJLMdQ6N5rtkEXPyiK/ej3G/8EeNSH9d8wUZ8TCqYHvpVLL7 Qwb8M/IkxQDzLUEermqFGlYkMNXdrMqjASf+FuSrppKLy77BctlNaWT+Rx2fm9SdAvj5 g8ONidTDysKfntPm3y4FUuuq0SkjewoTeljApEJAbY+n8yNFcnSE3kHO7skXOrB03cv/ dxIo0OeHYfoEn3H4l754ASlpS0R1x1iqOYC/oKk3yrxPgQqk3DksrmV9NvgcRPydVmSz /+gA== X-Gm-Message-State: AODbwcCJRSHlhcuFI+hvb/lsvGjKbTZPFi3TnnPkswAZPNNivNC8D2Rn tjaiOZz69qAuzg3aiEwbpp9Z X-Received: by 10.99.2.78 with SMTP id 75mr485753pgc.157.1494341018230; Tue, 09 May 2017 07:43:38 -0700 (PDT) Received: from localhost.localdomain ([106.51.135.126]) by smtp.gmail.com with ESMTPSA id 11sm341811pfj.59.2017.05.09.07.43.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 09 May 2017 07:43:37 -0700 (PDT) From: Amit Pundir To: Greg KH Cc: stable@vger.kernel.org, Kangjie Lu , Kangjie Lu , Takashi Iwai Subject: [PATCH for-3.18 19/24] ALSA: timer: Fix leak in SNDRV_TIMER_IOCTL_PARAMS Date: Tue, 9 May 2017 20:12:43 +0530 Message-Id: <1494340968-17152-20-git-send-email-amit.pundir@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1494340968-17152-1-git-send-email-amit.pundir@linaro.org> References: <1494340968-17152-1-git-send-email-amit.pundir@linaro.org> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Kangjie Lu commit cec8f96e49d9be372fdb0c3836dcf31ec71e457e upstream. The stack object “tread” has a total size of 32 bytes. Its field “event” and “val” both contain 4 bytes padding. These 8 bytes padding bytes are sent to user without being initialized. Signed-off-by: Kangjie Lu Signed-off-by: Takashi Iwai Signed-off-by: Amit Pundir --- sound/core/timer.c | 1 + 1 file changed, 1 insertion(+) -- 2.7.4 diff --git a/sound/core/timer.c b/sound/core/timer.c index fa4ded0c2230..ede058bd49a4 100644 --- a/sound/core/timer.c +++ b/sound/core/timer.c @@ -1759,6 +1759,7 @@ static int snd_timer_user_params(struct file *file, if (tu->timeri->flags & SNDRV_TIMER_IFLG_EARLY_EVENT) { if (tu->tread) { struct snd_timer_tread tread; + memset(&tread, 0, sizeof(tread)); tread.event = SNDRV_TIMER_EVENT_EARLY; tread.tstamp.tv_sec = 0; tread.tstamp.tv_nsec = 0;